event filtering with trace-cmd
Hi Steven
I wanted to filter my debug events getting only one specific level. So I followed the instruction found online, but I get a parse error.
Running on 3.10-rc1 using trace-cmd 1.0.3. Should I upgrade?
Regards,
Arend ----8<----------------------------------------------------------------- events/brcmfmac/brcmf_dbg# cat format
name: brcmf_dbg
ID: 1133
format:
field:unsigned short common_type; offset:0; size:2;
signed:0;
field:unsigned char common_flags; offset:2; size:1;
signed:0;
field:unsigned char common_preempt_count; offset:3;
size:1; signed:0;
field:int common_pid; offset:4; size:4; signed:1;
field:u32 level; offset:8; size:4; signed:0;
field:__data_loc char[] func; offset:12; size:4; signed:1;
field:__data_loc char[] msg; offset:16; size:4; signed:1;print fmt: "%s: %s", __get_str(func), __get_str(msg)
# sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level & 0x40000' disable all enable brcmfmac:brcmf_dbg path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable (level & 0x40000) ^ parse_error: Invalid operator
trace-cmd: Invalid argument
Failed filter of/sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/filter
Steven Rostedt
maintainerQuoted 6 lines · Arend van Spriel
Hi Steven
I wanted to filter my debug events getting only one specific level. So I followed the instruction found online, but I get a parse error.
Running on 3.10-rc1 using trace-cmd 1.0.3. Should I upgrade?
I would recommend upgrading regardless, but that's not an issue here.
Quoted 24 lines
Regards,
Arend ----8<----------------------------------------------------------------- events/brcmfmac/brcmf_dbg# cat format
name:brcmf_dbg
ID: 1133
format:field:unsigned short common_type; offset:0; size:2; signed:0; field:unsigned char common_flags; offset:2; size:1; signed:0; field:unsigned char common_preempt_count; offset:3; size:1; signed:0; field:int common_pid; offset:4; size:4; signed:1; field:u32 level; offset:8; size:4; signed:0; field:__data_loc char[] func; offset:12; size:4; signed:1; field:__data_loc char[] msg; offset:16; size:4; signed:1;print fmt: "%s: %s",
__get_str(func),__get_str(msg)
Quoted 8 lines
# sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level & 0x40000' disable all enable brcmfmac:brcmf_dbg path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable (level & 0x40000) ^ parse_error: Invalid operator
The record -f command passes the filter into the kernel
file /sys/kerne/debug/tracing/events/brcmfmac/brcmf_dbg/filter, and the error is actually coming from the kernel itself. Looking at the code, we do not currently accept binary operations. Although, it shouldn't be too hard to add. I may go and implement it for 3.11.
Thanks!
-- Steve
Quoted 3 lines
trace-cmd: Invalid argument
Failed filter of/sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/filter
Steven Rostedt
maintainerQuoted 9 lines · Steven Rostedt
Quoted 8 lines
# sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level & 0x40000' disable all enable brcmfmac:brcmf_dbg path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable (level & 0x40000) ^ parse_error: Invalid operator
Quoted 6 lines
The record -f command passes the filter into the kernel
file/sys/kerne/debug/tracing/events/brcmfmac/brcmf_dbg/filter, and the error is actually coming from the kernel itself. Looking at the code, we do not currently accept binary operations. Although, it shouldn't be too hard to add. I may go and implement it for 3.11.
Here, can you apply this patch and see if it does what you expect?
Thanks,
-- Steve
kernel/trace/trace_events_filter.c +5 -0
@@ -35,6 +35,7 @@enum filter_op_ids { +OP_BAND ,OP_OR ,OP_AND ,OP_GLOB ,
@@ -64,6 +65,7 @@ static struct filter_op filter_ops[] = { { OP_LE, "<=", 5 }, { OP_GT, ">", 5 }, { OP_GE, ">=", 5 }, + { OP_BAND, "&", 6 }, { OP_NONE, "OP_NONE", 0 }, { OP_OPEN_PAREN, "(", 0 }, };
@@ -156,6 +158,9 @@ static int filter_pred_##type(struct filter_pred *pred, void *event) \case OP_GE : \ match = (*addr >= val); \break ; \ +case OP_BAND : \ + match = (*addr & val); \ +break ; \default : \break ; \ } \
Quoted 11 lines · Steven Rostedt
Quoted 9 lines · Steven Rostedt
Quoted 8 lines
# sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level & 0x40000' disable all enable brcmfmac:brcmf_dbg path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable (level & 0x40000) ^ parse_error: Invalid operator
Quoted 8 lines
Quoted 6 lines
The record -f command passes the filter into the kernel
file/sys/kerne/debug/tracing/events/brcmfmac/brcmf_dbg/filter, and the error is actually coming from the kernel itself. Looking at the code, we do not currently accept binary operations. Although, it shouldn't be too hard to add. I may go and implement it for 3.11.Here, can you apply this patch and see if it does what you expect?
Not right now, but you can bet I will first thing tomorrow :-)
Thanks,
Arend
Quoted 8 lines
Thanks,
-- Steve
kernel/trace/trace_events_filter.c +0
-0
Quoted 11 lines · Steven Rostedt
Quoted 9 lines · Steven Rostedt
Quoted 8 lines
# sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level & 0x40000' disable all enable brcmfmac:brcmf_dbg path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable (level & 0x40000) ^ parse_error: Invalid operator
Quoted 8 lines
Quoted 6 lines
The record -f command passes the filter into the kernel
file/sys/kerne/debug/tracing/events/brcmfmac/brcmf_dbg/filter, and the error is actually coming from the kernel itself. Looking at the code, we do not currently accept binary operations. Although, it shouldn't be too hard to add. I may go and implement it for 3.11.Here, can you apply this patch and see if it does what you expect?
Hi Steven,
That patch does exactly what I expect. Thanks.
Regards,
Arend