Skip to contentSkip to conversation

ibstat.c: fix buffer-not-null-terminated

PATCH Applied Hal Rosenstock 2 participants 2 messages Jun 12, 2013 1 message not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 3/6 ibstat.c: fix buffer-not-null-terminated

From: Dan Ben Yosef <[email protected]>

Buffer may not have a null terminator if the source string's length is equal to the buffer size.

---
 src/ibstat.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/ibstat.c +1 -1
index acb9e8e..bdc021b 100644
@@ -279,7 +279,7 @@ int main(int argc, char *argv[])
 	int dev_port = -1;
 	int n, i;
 
-	memset(names, 0, sizeof(names[0][0] * UMAD_MAX_DEVICES * UMAD_CA_NAME_LEN));
+	memset(names, 0, sizeof(names[0][0]) * UMAD_MAX_DEVICES * UMAD_CA_NAME_LEN);
 	const struct ibdiag_opt opts[] = {
 		{"list_of_cas", 'l', 0, NULL, "list all IB devices"},
 		{"short", 's', 0, NULL, "short output"},
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 51B87DD9.1080701-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

#2 lore raw

Same comment as previous patch and this should have been rolled into that patch anyway.

Ira

Quoted 31 lines · On Wed, 12 Jun 2013 09:55:37 -0400 Hal Rosenstock…

From: Dan Ben Yosef <[email protected]>

Buffer may not have a null terminator if the source string's length is equal to the buffer size.

---
 src/ibstat.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/ibstat.c +1 -1
index acb9e8e..bdc021b 100644
@@ -279,7 +279,7 @@ int main(int argc, char *argv[])
 	int dev_port = -1;
 	int n, i;
 
-	memset(names, 0, sizeof(names[0][0] * UMAD_MAX_DEVICES * UMAD_CA_NAME_LEN));
+	memset(names, 0, sizeof(names[0][0]) * UMAD_MAX_DEVICES * UMAD_CA_NAME_LEN);
 	const struct ibdiag_opt opts[] = {
 		{"list_of_cas", 'l', 0, NULL, "list all IB devices"},
 		{"short", 's', 0, NULL, "short output"},
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 5 lines
Ira Weiny <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html