Skip to contentSkip to conversation

ibtracert.c: Uninitialized variable

PATCH Applied Hal Rosenstock 2 participants 2 messages Jun 12, 2013 1 message not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 5/6 ibtracert.c: Uninitialized variable

From: Dan Ben Yosef <[email protected]>

Reading from uninitialized variable

---
 src/ibtracert.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
src/ibtracert.c +7 -0
index cc0ac98..9699ccc 100644
@@ -250,6 +250,13 @@ static int find_route(ib_portid_t * from, ib_portid_t * to, int dump)
 	int maxhops = MAXHOPS;
 	int portnum, outport;
 
+	memset(&fromnode,0,sizeof(Node));
+	memset(&tonode,0,sizeof(Node));
+	memset(&nextnode,0,sizeof(Node));
+	memset(&fromport,0,sizeof(Port));
+	memset(&toport,0,sizeof(Port));
+	memset(&nextport,0,sizeof(Port));
+
 	DEBUG("from %s", portid2str(from));
 
 	if (get_node(&fromnode, &fromport, from) < 0 ||
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 51B87DE4.3040707-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Applied
#2 lore raw
Quoted 1 line · On Wed, 12 Jun 2013 09:55:48 -0400 Hal Rosenstock…

From: Dan Ben Yosef <[email protected]>

Thanks applied!
Ira

Quoted 30 lines

Reading from uninitialized variable

---
 src/ibtracert.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
src/ibtracert.c +7 -0
index cc0ac98..9699ccc 100644
@@ -250,6 +250,13 @@ static int find_route(ib_portid_t * from, ib_portid_t * to, int dump)
 	int maxhops = MAXHOPS;
 	int portnum, outport;
 
+	memset(&fromnode,0,sizeof(Node));
+	memset(&tonode,0,sizeof(Node));
+	memset(&nextnode,0,sizeof(Node));
+	memset(&fromport,0,sizeof(Port));
+	memset(&toport,0,sizeof(Port));
+	memset(&nextport,0,sizeof(Port));
+
 	DEBUG("from %s", portid2str(from));
 
 	if (get_node(&fromnode, &fromport, from) < 0 ||
Signature · 1 line
1.7.8.2
Signature · 5 lines
Ira Weiny <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html