Skip to contentSkip to conversation

e1000e + suspend, 3.9-rc2

DISCUSSION Borislav Petkov 5 participants 14 messages Mar 11, 2013 – Jul 15, 2013

lore
Share & tools
lore
#0 lore raw

Hi,

When I try to suspend with 3.9-rc2, it fails to do so and returns back to the prompt. Below's what's in dmesg.

Jeff, am I assuming correctly that the fixes I was testing last week haven't trickled upstream yet?

If so, then it's a no biggie, I'll wait. This mail is then just FYI.

Thanks.

[ 1294.992955] PM: Syncing filesystems ... done.
[ 1295.002976] Freezing user space processes ... (elapsed 0.01 seconds) done.
[ 1295.014973] PM: Preallocating image memory... done (allocated 153845 pages)
[ 1295.187511] PM: Allocated 615380 kbytes in 0.17 seconds (3619.88 MB/s)
[ 1295.187529] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
[ 1295.199398] Suspending console(s) (use no_console_suspend to debug)
[ 1295.200746] xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 0 with no TDs queued?
[ 1295.764171] e1000e 0000:00:19.0 eth0: Hardware Error						<--- ***
[ 1296.599206] pci_pm_freeze(): e1000_suspend+0x0/0x20 returns -2				<--- ***
[ 1296.599208] dpm_run_callback(): pci_pm_freeze+0x0/0xc0 returns -2				<--- ***
[ 1296.599212] PM: Device 0000:00:19.0 failed to freeze async: error -2
[ 1296.659254] xhci_hcd 0000:00:14.0: setting latency timer to 64
[ 1296.659272] ehci-pci 0000:00:1d.0: setting latency timer to 64
[ 1296.659282] ehci-pci 0000:00:1a.0: setting latency timer to 64
[ 1296.659294] usb usb1: root hub lost power or was reset
[ 1296.659295] usb usb2: root hub lost power or was reset
[ 1296.659303] usb usb3: root hub lost power or was reset
[ 1296.659308] i915 0000:00:02.0: setting latency timer to 64
[ 1296.659316] usb usb4: root hub lost power or was reset
[ 1296.659370] xhci_hcd 0000:00:14.0: Slot 1 endpoint 2 not removed from BW list!
[ 1296.659580] xhci_hcd 0000:00:14.0: irq 44 for MSI/MSI-X
[ 1296.659874] ahci 0000:00:1f.2: setting latency timer to 64
[ 1296.663218] ehci-pci 0000:00:1d.0: cache line size of 64 is not supported
[ 1296.663219] ehci-pci 0000:00:1a.0: cache line size of 64 is not supported
[ 1296.670498] snd_hda_intel 0000:00:1b.0: irq 45 for MSI/MSI-X
[ 1296.964331] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[ 1296.965388] ata1.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded
[ 1296.965393] ata1.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out
[ 1296.966335] ata2: SATA link down (SStatus 0 SControl 300)
[ 1296.967626] ata1.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded
[ 1296.967630] ata1.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out
[ 1296.968326] usb 3-1: reset high-speed USB device number 2 using ehci-pci
[ 1296.968368] ata3: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
[ 1296.968480] ata1.00: configured for UDMA/133
[ 1296.969113] sd 0:0:0:0: [sda] Starting disk
[ 1296.969137] ata3.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded
[ 1296.969141] ata3.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out
[ 1296.969306] ata5: SATA link down (SStatus 0 SControl 300)
[ 1296.970071] ata3.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded
[ 1296.970075] ata3.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out
[ 1296.970402] ata3.00: configured for UDMA/100
[ 1296.970566] sd 2:0:0:0: [sdb] Starting disk
[ 1297.184472] usb 4-1: reset high-speed USB device number 2 using ehci-pci
[ 1297.550690] usb 1-2: reset low-speed USB device number 2 using xhci_hcd
[ 1297.564794] xhci_hcd 0000:00:14.0: xHCI xhci_drop_endpoint called with disabled ep ffff880211766300
[ 1297.564804] usb 1-2: ep 0x81 - rounding interval to 64 microframes, ep desc says 80 microframes
[ 1297.569277] PM: restore of devices complete after 910.002 msecs
[ 1297.573285] Restarting tasks ... done.
[ 1297.577501] video LNXVIDEO:00: Restoring backlight state
[ 1298.066775] [drm] Enabling RC6 states: RC6 on, RC6p on, RC6pp off
[ 1301.986071] PM: Syncing filesystems ... done.
[ 1301.999421] Freezing user space processes ... (elapsed 0.01 seconds) done.
[ 1302.012647] PM: Preallocating image memory... done (allocated 153541 pages)
[ 1302.177618] PM: Allocated 614164 kbytes in 0.16 seconds (3838.52 MB/s)
[ 1302.178208] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
[ 1302.190493] Suspending console(s) (use no_console_suspend to debug)
[ 1302.192179] xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 0 with no TDs queued?
[ 1302.751858] e1000e 0000:00:19.0 eth0: Hardware Error
[ 1302.959582] ------------[ cut here ]------------
[ 1302.959587] WARNING: at kernel/irq/manage.c:1249 __free_irq+0xa3/0x1e0()
[ 1302.959588] Hardware name: 2320CTO
[ 1302.959588] Trying to free already-free IRQ 20
[ 1302.959612] Modules linked in: cpufreq_powersave cpufreq_userspace cpufreq_conservative cpufreq_stats uinput loop hid_generic usbhid hid arc4 coretemp kvm_intel kvm crc32_pclmul crc32c_intel ghash_clmulni_intel aesni_intel xts aes_x86_64 lrw gf128mul ablk_helper cryptd iTCO_wdt iTCO_vendor_support snd_hda_codec_hdmi snd_hda_codec_realtek microcode sdhci_pci snd_hda_intel snd_hda_codec lpc_ich snd_hwdep mfd_core sdhci snd_pcm i2c_i801 pcspkr mmc_core thinkpad_acpi snd_page_alloc battery ac nvram snd_timer led_class snd ehci_pci soundcore xhci_hcd ehci_hcd wmi acpi_cpufreq mperf processor thermal [last unloaded: cfg80211]
[ 1302.959613] Pid: 3966, comm: kworker/u:49 Not tainted 3.9.0-rc2+ #32
[ 1302.959614] Call Trace:
[ 1302.959618]  [<ffffffff8103f53f>] warn_slowpath_common+0x7f/0xc0
[ 1302.959620]  [<ffffffff8103f636>] warn_slowpath_fmt+0x46/0x50
[ 1302.959623]  [<ffffffff815ac69e>] ? _raw_spin_lock_irqsave+0x4e/0x60
[ 1302.959624]  [<ffffffff810bcef5>] ? __free_irq+0x55/0x1e0
[ 1302.959625]  [<ffffffff810bcf43>] __free_irq+0xa3/0x1e0
[ 1302.959627]  [<ffffffff810bd0d4>] free_irq+0x54/0xc0
[ 1302.959630]  [<ffffffff8142e26d>] e1000_free_irq+0x7d/0x90
[ 1302.959631]  [<ffffffff8143a3a7>] __e1000_shutdown+0x97/0x880
[ 1302.959633]  [<ffffffff815b0ac9>] ? sub_preempt_count+0x79/0xd0
[ 1302.959634]  [<ffffffff8143abe7>] e1000_suspend+0x17/0x20
[ 1302.959637]  [<ffffffff812a4445>] pci_pm_freeze+0x55/0xc0
[ 1302.959638]  [<ffffffff812a43f0>] ? pci_pm_resume_noirq+0xd0/0xd0
[ 1302.959640]  [<ffffffff813ca1e5>] dpm_run_callback.isra.5+0x25/0x50
[ 1302.959642]  [<ffffffff813ca973>] __device_suspend+0xe3/0x200
[ 1302.959643]  [<ffffffff813caaaf>] async_suspend+0x1f/0xa0
[ 1302.959645]  [<ffffffff8106c29b>] async_run_entry_fn+0x3b/0x140
[ 1302.959648]  [<ffffffff8105d5ad>] process_one_work+0x1ed/0x510
[ 1302.959649]  [<ffffffff8105d54b>] ? process_one_work+0x18b/0x510
[ 1302.959651]  [<ffffffff8105ed55>] worker_thread+0x115/0x390
[ 1302.959652]  [<ffffffff8105ec40>] ? manage_workers+0x300/0x300
[ 1302.959654]  [<ffffffff810653ca>] kthread+0xea/0xf0
[ 1302.959656]  [<ffffffff810652e0>] ? kthread_create_on_node+0x160/0x160
[ 1302.959657]  [<ffffffff815b4a1c>] ret_from_fork+0x7c/0xb0
[ 1302.959659]  [<ffffffff810652e0>] ? kthread_create_on_node+0x160/0x160
[ 1302.959660] ---[ end trace 65d7a9f7d60cfc59 ]---
[ 1303.582835] pci_pm_freeze(): e1000_suspend+0x0/0x20 returns -2
[ 1303.582836] dpm_run_callback(): pci_pm_freeze+0x0/0xc0 returns -2
[ 1303.582839] PM: Device 0000:00:19.0 failed to freeze async: error -2
[ 1303.637977] xhci_hcd 0000:00:14.0: setting latency timer to 64
[ 1303.637986] ehci-pci 0000:00:1a.0: setting latency timer to 64
[ 1303.638000] usb usb1: root hub lost power or was reset
[ 1303.638002] usb usb2: root hub lost power or was reset
[ 1303.638015] usb usb3: root hub lost power or was reset
[ 1303.638017] i915 0000:00:02.0: setting latency timer to 64
[ 1303.638090] xhci_hcd 0000:00:14.0: Slot 1 endpoint 2 not removed from BW list!
[ 1303.638280] xhci_hcd 0000:00:14.0: irq 44 for MSI/MSI-X
[ 1303.638407] ehci-pci 0000:00:1d.0: setting latency timer to 64
[ 1303.638439] usb usb4: root hub lost power or was reset
[ 1303.638621] ahci 0000:00:1f.2: setting latency timer to 64
[ 1303.641895] ehci-pci 0000:00:1a.0: cache line size of 64 is not supported
[ 1303.642323] ehci-pci 0000:00:1d.0: cache line size of 64 is not supported
[ 1303.649289] snd_hda_intel 0000:00:1b.0: irq 45 for MSI/MSI-X
[ 1303.945201] ata2: SATA link down (SStatus 0 SControl 300)
[ 1303.945243] usb 3-1: reset high-speed USB device number 2 using ehci-pci
[ 1303.945260] ata3: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
[ 1303.945937] ata3.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded
[ 1303.945942] ata3.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out
[ 1303.946876] ata3.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded
[ 1303.946880] ata3.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out
[ 1303.947205] ata3.00: configured for UDMA/100
[ 1303.947357] sd 2:0:0:0: [sdb] Starting disk
[ 1303.948182] ata5: SATA link down (SStatus 0 SControl 300)
[ 1303.950186] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[ 1303.951521] ata1.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded
[ 1303.951525] ata1.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out
[ 1303.954302] ata1.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded
[ 1303.954306] ata1.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out
[ 1303.955467] ata1.00: configured for UDMA/133
[ 1303.955614] sd 0:0:0:0: [sda] Starting disk
[ 1304.161332] usb 4-1: reset high-speed USB device number 2 using ehci-pci
[ 1304.527527] usb 1-2: reset low-speed USB device number 2 using xhci_hcd
[ 1304.541319] xhci_hcd 0000:00:14.0: xHCI xhci_drop_endpoint called with disabled ep ffff880211766300
[ 1304.541329] usb 1-2: ep 0x81 - rounding interval to 64 microframes, ep desc says 80 microframes
[ 1304.545981] PM: restore of devices complete after 907.843 msecs
[ 1304.610202] Restarting tasks ... done.
[ 1304.611516] video LNXVIDEO:00: Restoring backlight state
[ 1305.064547] [drm] Enabling RC6 states: RC6 on, RC6p on, RC6pp off
Signature · 4 lines
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
#1 lore raw
Quoted 11 lines · Borislav Petkov

Hi,

When I try to suspend with 3.9-rc2, it fails to do so and returns back to the prompt. Below's what's in dmesg.

Jeff, am I assuming correctly that the fixes I was testing last week haven't trickled upstream yet?

If so, then it's a no biggie, I'll wait. This mail is then just FYI.

Thanks.

No, the patches have not made it into Linus's tree yet. They are in David Miller's net tree, and he just sent a pull request to Linus this morning. So expect them to be in 3.9-rc3.

#2 lore raw
Quoted 3 lines · Jeff Kirsher

No, the patches have not made it into Linus's tree yet. They are in David Miller's net tree, and he just sent a pull request to Linus this morning. So expect them to be in 3.9-rc3.

You mean this pull request:

commit 0cb77508252e2d0e00c5ec7e57b4be9b3f7eb24d
Merge: ffb6a445e7cd 9026c4927254
Author: Linus Torvalds <[email protected]>
Date: Mon Mar 11 07:51:59 2013 -0700

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Pull networking fixes from David Miller:

?

Yeah, it is already upstream. And yeah, it did trigger with it.

$ git describe
v3.9-rc2-112-g7c6baa304b84

But it somehow doesn't trigger with that same kernel anymore so I'll consider it a glitch and watch it over the next days.

Thanks.

Signature · 5 lines
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
#3 lore raw
Quoted 7 lines · Borislav Petkov

Yeah, it is already upstream. And yeah, it did trigger with it.

$ git describe
v3.9-rc2-112-g7c6baa304b84

But it somehow doesn't trigger with that same kernel anymore so I'll consider it a glitch and watch it over the next days.

Ok, I can still see the hardware error message when suspending:

...

Mar 12 18:11:15 nazgul vmunix: [ 3001.399727] PM: Syncing filesystems ... done.
Mar 12 18:11:42 nazgul vmunix: [ 3001.407296] Freezing user space processes ... (elapsed 0.01 seconds) done.
Mar 12 18:11:42 nazgul vmunix: [ 3001.420156] PM: Preallocating image memory... done (allocated 109074 pages)
Mar 12 18:11:42 nazgul vmunix: [ 3001.575708] PM: Allocated 436296 kbytes in 0.15 seconds (2908.64 MB/s)
Mar 12 18:11:42 nazgul vmunix: [ 3001.576290] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
Mar 12 18:11:42 nazgul vmunix: [ 3001.588245] ehci-pci 0000:00:1a.0: power state changed by ACPI to D0
Mar 12 18:11:42 nazgul vmunix: [ 3001.690813] ehci-pci 0000:00:1a.0: setting latency timer to 64
Mar 12 18:11:42 nazgul vmunix: [ 3001.703795] ehci-pci 0000:00:1d.0: power state changed by ACPI to D0
Mar 12 18:11:42 nazgul vmunix: [ 3001.805842] ehci-pci 0000:00:1d.0: setting latency timer to 64
Mar 12 18:11:42 nazgul vmunix: [ 3001.808563] Suspending console(s) (use no_console_suspend to debug)
Mar 12 18:11:42 nazgul vmunix: [ 3001.811022] xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 0 with no TDs queued?
Mar 12 18:11:42 nazgul vmunix: [ 3002.372862] e1000e 0000:00:19.0 eth0: Hardware Error
									^^^^^

But that's the only line there, nothing more from e1000e.. After that the box suspends ok and I can resume back normally... AFAICT.

Signature · 5 lines
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
#4 lore raw
Quoted 10 lines · Borislav Petkov
Quoted 7 lines · Borislav Petkov

Yeah, it is already upstream. And yeah, it did trigger with it.

$ git describe
v3.9-rc2-112-g7c6baa304b84

But it somehow doesn't trigger with that same kernel anymore so I'll consider it a glitch and watch it over the next days.

Ok, I can still see the hardware error message when suspending:

And with 3.8 plus these:
PCI/PM: Clear state_saved during suspend
e1000e: fix pci-device enable-counter balance
e1000e: fix runtime power management transitions
e1000e: fix accessing to suspended device

I sometimes see this:
pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2

Any ideas? Am I missing some patch still?

thanks,

Signature · 2 lines
js
suse labs
#5 lore raw
Quoted 18 lines · Jiri Slaby
Quoted 10 lines · Borislav Petkov
Quoted 7 lines · Borislav Petkov

Yeah, it is already upstream. And yeah, it did trigger with it.

$ git describe
v3.9-rc2-112-g7c6baa304b84

But it somehow doesn't trigger with that same kernel anymore so I'll consider it a glitch and watch it over the next days.

Ok, I can still see the hardware error message when suspending:

And with 3.8 plus these:
PCI/PM: Clear state_saved during suspend
e1000e: fix pci-device enable-counter balance
e1000e: fix runtime power management transitions
e1000e: fix accessing to suspended device

Quoted 6 lines

I sometimes see this:
pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2

Any ideas? Am I missing some patch still?

Try this:
"PCI: Don't try to disable Bus Master on disconnected PCI devices"
https://patchwork.kernel.org/patch/2271641/

But I'm not sure, probably it is unrelated because this code works only (?) during shutdown/kexec sequences.

#6 lore raw
Quoted 24 lines · Konstantin Khlebnikov
Quoted 23 lines · Jiri Slaby
Quoted 10 lines · Borislav Petkov
Quoted 7 lines · Borislav Petkov

Yeah, it is already upstream. And yeah, it did trigger with it.

$ git describe
v3.9-rc2-112-g7c6baa304b84

But it somehow doesn't trigger with that same kernel anymore so I'll consider it a glitch and watch it over the next days.

Ok, I can still see the hardware error message when suspending:

And with 3.8 plus these:
PCI/PM: Clear state_saved during suspend
e1000e: fix pci-device enable-counter balance
e1000e: fix runtime power management transitions
e1000e: fix accessing to suspended device

I sometimes see this:
pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2

Quoted 8 lines
Quoted 1 line

Any ideas? Am I missing some patch still?

Try this:
"PCI: Don't try to disable Bus Master on disconnected PCI devices"
https://patchwork.kernel.org/patch/2271641/

But I'm not sure, probably it is unrelated because this code works only (?) during shutdown/kexec sequences.

I don't think it will help either. -2 here is -E1000_ERR_PHY from e1000e_write_phy_reg_mdic if I'm looking correctly. I.e. MDIC not ready or unlike MDIC_ERROR.

I think this happened after I put the link down and tried to suspend.

Signature · 2 lines
js
suse labs
#7 lore raw
Quoted 34 lines

-----Original Message-----
From: Jiri Slaby [mailto:[email protected]] On Behalf Of Jiri Slaby
Sent: Tuesday, March 19, 2013 5:23 AM
To: Konstantin Khlebnikov
Cc: Borislav Petkov; Kirsher, Jeffrey T; Rafael J. Wysocki; Bjorn Helgaas; [email protected]; lkml; [email protected]; Allan, Bruce W
Subject: Re: e1000e + suspend, 3.9-rc2

Quoted 13 lines
Quoted 13 lines
Quoted 1 line

Ok, I can still see the hardware error message when suspending:

And with 3.8 plus these:
PCI/PM: Clear state_saved during suspend
e1000e: fix pci-device enable-counter balance
e1000e: fix runtime power management transitions
e1000e: fix accessing to suspended device

I sometimes see this:
pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2

Quoted 8 lines
Quoted 1 line

Any ideas? Am I missing some patch still?

Try this:
"PCI: Don't try to disable Bus Master on disconnected PCI devices"
https://patchwork.kernel.org/patch/2271641/

But I'm not sure, probably it is unrelated because this code works only (?) during shutdown/kexec sequences.

I don't think it will help either. -2 here is -E1000_ERR_PHY from e1000e_write_phy_reg_mdic if I'm looking correctly. I.e. MDIC not ready or unlike MDIC_ERROR.

Quoted 5 lines

I think this happened after I put the link down and tried to suspend.

--
js
suse labs

Sorry for not replying sooner, for some reason some of this thread was filtered to my junk folder and I didn’t see it until now.

Jiri, can you provide the output of 'lspci -s 00:19.0 -n -vv' and confirm the scenario in which the problem occurs? Is this easily reproduced?

Thanks,
Bruce.

���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�

#8 lore raw
Quoted 40 lines · Bruce W
Quoted 34 lines

-----Original Message-----
From: Jiri Slaby [mailto:[email protected]] On Behalf Of Jiri Slaby
Sent: Tuesday, March 19, 2013 5:23 AM
To: Konstantin Khlebnikov
Cc: Borislav Petkov; Kirsher, Jeffrey T; Rafael J. Wysocki; Bjorn Helgaas; [email protected]; lkml; [email protected]; Allan, Bruce W
Subject: Re: e1000e + suspend, 3.9-rc2

Quoted 13 lines
Quoted 13 lines
Quoted 1 line

Ok, I can still see the hardware error message when suspending:

And with 3.8 plus these:
PCI/PM: Clear state_saved during suspend
e1000e: fix pci-device enable-counter balance
e1000e: fix runtime power management transitions
e1000e: fix accessing to suspended device

I sometimes see this:
pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2

Quoted 8 lines
Quoted 1 line

Any ideas? Am I missing some patch still?

Try this:
"PCI: Don't try to disable Bus Master on disconnected PCI devices"
https://patchwork.kernel.org/patch/2271641/

But I'm not sure, probably it is unrelated because this code works only (?) during shutdown/kexec sequences.

I don't think it will help either. -2 here is -E1000_ERR_PHY from e1000e_write_phy_reg_mdic if I'm looking correctly. I.e. MDIC not ready or unlike MDIC_ERROR.

Quoted 5 lines

I think this happened after I put the link down and tried to suspend.

--
js
suse labs

Quoted 5 lines

Sorry for not replying sooner, for some reason some of this thread was filtered to my junk folder and I didn’t see it until now.

Jiri, can you provide the output of 'lspci -s 00:19.0 -n -vv' and confirm the scenario in which the problem occurs? Is this easily reproduced?

Sorry about the late reply, I totally forgot about this. lspci output is attached below. The scenario is not rigid as I'm not sure when exactly this happens. It looks like I have to use power saving on that device. And I don't need to use that device at all. Here is an excerpt from one kernel boot modulo e1000e where the error occurred.

e1000e: Copyright(c) 1999 - 2012 Intel Corporation.
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: Interrupt Throttling Rate (ints/sec) set to dynamic conservative mode
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0 eth0: (PCI Express:2.5GT/s:Width x1) 3c:97:0e:35:3d:dd e1000e 0000:00:19.0 eth0: Intel(R) PRO/1000 Network Connection e1000e 0000:00:19.0 eth0: MAC: 10, PHY: 11, PBA No: 1000FF-0FF e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2

00:19.0 Ethernet controller [0200]: Intel Corporation 82579LM Gigabit Network Connection [8086:1502] (rev 04)
Subsystem: Lenovo Device [17aa:21f3]
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx+
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0
Interrupt: pin A routed to IRQ 46
Region 0: Memory at f2500000 (32-bit, non-prefetchable) [size=128K] Region 1: Memory at f253b000 (32-bit, non-prefetchable) [size=4K] Region 2: I/O ports at 5080 [size=32]
Capabilities: [c8] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [d0] MSI: Enable+ Count=1/1 Maskable- 64bit+
Address: 00000000fee00398 Data: 0000
Capabilities: [e0] PCI Advanced Features
AFCap: TP+ FLR+
AFCtrl: FLR-
AFStatus: TP-
Kernel driver in use: e1000e

thanks,

Signature · 2 lines
js
suse labs
#9 lore raw
Quoted 79 lines · Jiri Slaby
Quoted 40 lines · Bruce W
Quoted 34 lines

-----Original Message-----
From: Jiri Slaby [mailto:[email protected]] On Behalf Of Jiri Slaby
Sent: Tuesday, March 19, 2013 5:23 AM
To: Konstantin Khlebnikov
Cc: Borislav Petkov; Kirsher, Jeffrey T; Rafael J. Wysocki; Bjorn Helgaas; [email protected]; lkml; [email protected]; Allan, Bruce W
Subject: Re: e1000e + suspend, 3.9-rc2

Quoted 13 lines
Quoted 13 lines
Quoted 1 line

Ok, I can still see the hardware error message when suspending:

And with 3.8 plus these:
PCI/PM: Clear state_saved during suspend
e1000e: fix pci-device enable-counter balance
e1000e: fix runtime power management transitions
e1000e: fix accessing to suspended device

I sometimes see this:
pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2

Quoted 8 lines
Quoted 1 line

Any ideas? Am I missing some patch still?

Try this:
"PCI: Don't try to disable Bus Master on disconnected PCI devices"
https://patchwork.kernel.org/patch/2271641/

But I'm not sure, probably it is unrelated because this code works only (?) during shutdown/kexec sequences.

I don't think it will help either. -2 here is -E1000_ERR_PHY from e1000e_write_phy_reg_mdic if I'm looking correctly. I.e. MDIC not ready or unlike MDIC_ERROR.

Quoted 5 lines

I think this happened after I put the link down and tried to suspend.

--
js
suse labs

Quoted 5 lines

Sorry for not replying sooner, for some reason some of this thread was filtered to my junk folder and I didn’t see it until now.

Jiri, can you provide the output of 'lspci -s 00:19.0 -n -vv' and confirm the scenario in which the problem occurs? Is this easily reproduced?

Sorry about the late reply, I totally forgot about this. lspci output is attached below. The scenario is not rigid as I'm not sure when exactly this happens. It looks like I have to use power saving on that device. And I don't need to use that device at all. Here is an excerpt from one kernel boot modulo e1000e where the error occurred.

e1000e: Copyright(c) 1999 - 2012 Intel Corporation.
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: Interrupt Throttling Rate (ints/sec) set to dynamic conservative mode
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0 eth0: (PCI Express:2.5GT/s:Width x1) 3c:97:0e:35:3d:dd e1000e 0000:00:19.0 eth0: Intel(R) PRO/1000 Network Connection e1000e 0000:00:19.0 eth0: MAC: 10, PHY: 11, PBA No: 1000FF-0FF e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X

Quoted 8 lines

e1000e 0000:00:19.0: setting latency timer to 64 e1000e 0000:00:19.0: irq 45 for MSI/MSI-X pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2

This still happens with 3.9.5 ...

I don't use wired net at all. This usually happens after I enable power saving.

Quoted 27 lines

00:19.0 Ethernet controller [0200]: Intel Corporation 82579LM Gigabit Network Connection [8086:1502] (rev 04)
Subsystem: Lenovo Device [17aa:21f3]
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx+
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0
Interrupt: pin A routed to IRQ 46
Region 0: Memory at f2500000 (32-bit, non-prefetchable) [size=128K] Region 1: Memory at f253b000 (32-bit, non-prefetchable) [size=4K] Region 2: I/O ports at 5080 [size=32]
Capabilities: [c8] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [d0] MSI: Enable+ Count=1/1 Maskable- 64bit+
Address: 00000000fee00398 Data: 0000
Capabilities: [e0] PCI Advanced Features
AFCap: TP+ FLR+
AFCtrl: FLR-
AFStatus: TP-
Kernel driver in use: e1000e

thanks,

Signature · 2 lines
js
suse labs
#10 lore raw
Quoted 89 lines · Jiri Slaby
Quoted 79 lines · Jiri Slaby
Quoted 40 lines · Bruce W
Quoted 34 lines

-----Original Message-----
From: Jiri Slaby [mailto:[email protected]] On Behalf Of Jiri Slaby
Sent: Tuesday, March 19, 2013 5:23 AM
To: Konstantin Khlebnikov
Cc: Borislav Petkov; Kirsher, Jeffrey T; Rafael J. Wysocki; Bjorn Helgaas; [email protected]; lkml; [email protected]; Allan, Bruce W
Subject: Re: e1000e + suspend, 3.9-rc2

Quoted 13 lines
Quoted 13 lines
Quoted 1 line

Ok, I can still see the hardware error message when suspending:

And with 3.8 plus these:
PCI/PM: Clear state_saved during suspend
e1000e: fix pci-device enable-counter balance
e1000e: fix runtime power management transitions
e1000e: fix accessing to suspended device

I sometimes see this:
pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2

Quoted 8 lines
Quoted 1 line

Any ideas? Am I missing some patch still?

Try this:
"PCI: Don't try to disable Bus Master on disconnected PCI devices"
https://patchwork.kernel.org/patch/2271641/

But I'm not sure, probably it is unrelated because this code works only (?) during shutdown/kexec sequences.

I don't think it will help either. -2 here is -E1000_ERR_PHY from e1000e_write_phy_reg_mdic if I'm looking correctly. I.e. MDIC not ready or unlike MDIC_ERROR.

Quoted 5 lines

I think this happened after I put the link down and tried to suspend.

--
js
suse labs

Quoted 5 lines

Sorry for not replying sooner, for some reason some of this thread was filtered to my junk folder and I didn’t see it until now.

Jiri, can you provide the output of 'lspci -s 00:19.0 -n -vv' and confirm the scenario in which the problem occurs? Is this easily reproduced?

Sorry about the late reply, I totally forgot about this. lspci output is attached below. The scenario is not rigid as I'm not sure when exactly this happens. It looks like I have to use power saving on that device. And I don't need to use that device at all. Here is an excerpt from one kernel boot modulo e1000e where the error occurred.

e1000e: Copyright(c) 1999 - 2012 Intel Corporation.
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: Interrupt Throttling Rate (ints/sec) set to dynamic conservative mode
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0 eth0: (PCI Express:2.5GT/s:Width x1) 3c:97:0e:35:3d:dd e1000e 0000:00:19.0 eth0: Intel(R) PRO/1000 Network Connection e1000e 0000:00:19.0 eth0: MAC: 10, PHY: 11, PBA No: 1000FF-0FF e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X

Quoted 8 lines

e1000e 0000:00:19.0: setting latency timer to 64 e1000e 0000:00:19.0: irq 45 for MSI/MSI-X pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2

Quoted 4 lines

This still happens with 3.9.5 ...

I don't use wired net at all. This usually happens after I enable power saving.

I guess that '-2' is one of 'return -E1000_ERR_PHY', but all that debug messages are omitted by default.

Please enable CONFIG_DYNAMIC_DEBUG=y and mount debugfs, after that:

# echo module e1000e +p > /sys/kernel/debug/dynamic_debug/control
If it would be too verbose you can enable these messages more selective.
Quoted 30 lines
Quoted 28 lines

00:19.0 Ethernet controller [0200]: Intel Corporation 82579LM Gigabit Network Connection [8086:1502] (rev 04)
Subsystem: Lenovo Device [17aa:21f3]
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx+
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast>TAbort-
<TAbort-<MAbort->SERR-<PERR- INTx-
Latency: 0
Interrupt: pin A routed to IRQ 46
Region 0: Memory at f2500000 (32-bit, non-prefetchable) [size=128K] Region 1: Memory at f253b000 (32-bit, non-prefetchable) [size=4K] Region 2: I/O ports at 5080 [size=32]
Capabilities: [c8] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [d0] MSI: Enable+ Count=1/1 Maskable- 64bit+
Address: 00000000fee00398 Data: 0000
Capabilities: [e0] PCI Advanced Features
AFCap: TP+ FLR+
AFCtrl: FLR-
AFStatus: TP-
Kernel driver in use: e1000e

thanks,

#11 lore raw
Quoted 8 lines · Konstantin Khlebnikov
Quoted 7 lines · Jiri Slaby
Quoted 6 lines

pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2

Quoted 7 lines
Quoted 4 lines

This still happens with 3.9.5 ...

I don't use wired net at all. This usually happens after I enable power saving.

I guess that '-2' is one of 'return -E1000_ERR_PHY', but all that debug messages are omitted by default.

Yeah, I wrote that in one of my past reports too.

Quoted 3 lines

Please enable CONFIG_DYNAMIC_DEBUG=y and mount debugfs, after that:

# echo module e1000e +p > /sys/kernel/debug/dynamic_debug/control
If it would be too verbose you can enable these messages more selective.

I have CONFIG_DYNAMIC_DEBUG=y, but the issue is pretty hard to reproduce. As soon as it recurs, I will report the results of the above...

thanks,

Signature · 2 lines
js
suse labs
#12 lore raw
In reply to Konstantin Khlebnikov
Quoted 102 lines · Konstantin Khlebnikov
Quoted 96 lines · Jiri Slaby
Quoted 86 lines · Jiri Slaby
Quoted 44 lines · Bruce W
Quoted 33 lines

-----Original Message-----
From: Jiri Slaby [mailto:[email protected]] On Behalf Of Jiri Slaby
Sent: Tuesday, March 19, 2013 5:23 AM
To: Konstantin Khlebnikov
Cc: Borislav Petkov; Kirsher, Jeffrey T; Rafael J. Wysocki; Bjorn Helgaas;
[email protected]; lkml; [email protected]; Allan, Bruce W
Subject: Re: e1000e + suspend, 3.9-rc2

Quoted 15 lines
Quoted 8 lines
Quoted 1 line

Ok, I can still see the hardware error message when suspending:

And with 3.8 plus these:
PCI/PM: Clear state_saved during suspend
e1000e: fix pci-device enable-counter balance
e1000e: fix runtime power management transitions
e1000e: fix accessing to suspended device

Quoted 6 lines

I sometimes see this:
pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2

Any ideas? Am I missing some patch still?

Quoted 7 lines

Try this:
"PCI: Don't try to disable Bus Master on disconnected PCI devices"
https://patchwork.kernel.org/patch/2271641/

But I'm not sure, probably it is unrelated because this code works only (?)
during shutdown/kexec sequences.

Quoted 10 lines

I don't think it will help either. -2 here is -E1000_ERR_PHY from e1000e_write_phy_reg_mdic if I'm looking correctly. I.e. MDIC not ready
or unlike MDIC_ERROR.

I think this happened after I put the link down and tried to suspend.

Signature · 2 lines
js
suse labs
Quoted 7 lines

Sorry for not replying sooner, for some reason some of this thread was filtered
to my junk folder and I didn’t see it until now.

Jiri, can you provide the output of 'lspci -s 00:19.0 -n -vv' and confirm the scenario
in which the problem occurs? Is this easily reproduced?

Sorry about the late reply, I totally forgot about this. lspci output is attached below. The scenario is not rigid as I'm not sure when exactly this happens. It looks like I have to use power saving on that device. And I don't need to use that device at all. Here is an excerpt from one kernel boot modulo e1000e where the error occurred.

e1000e: Copyright(c) 1999 - 2012 Intel Corporation.
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: Interrupt Throttling Rate (ints/sec) set to dynamic conservative mode
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0 eth0: (PCI Express:2.5GT/s:Width x1) 3c:97:0e:35:3d:dd
e1000e 0000:00:19.0 eth0: Intel(R) PRO/1000 Network Connection e1000e 0000:00:19.0 eth0: MAC: 10, PHY: 11, PBA No: 1000FF-0FF e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X

Quoted 8 lines

e1000e 0000:00:19.0: setting latency timer to 64 e1000e 0000:00:19.0: irq 45 for MSI/MSI-X pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2

Quoted 4 lines

This still happens with 3.9.5 ...

I don't use wired net at all. This usually happens after I enable power saving.

Quoted 6 lines

I guess that '-2' is one of 'return -E1000_ERR_PHY', but all that debug messages are omitted by default.

Please enable CONFIG_DYNAMIC_DEBUG=y and mount debugfs, after that:

# echo module e1000e +p > /sys/kernel/debug/dynamic_debug/control
If it would be too verbose you can enable these messages more selective.\

Here we go at last:

e1000e 0000:00:19.0 eth0: Setting page 0x6020
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Setting page 0x6020
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: failed to enable jumbo frame workaround mode e1000e 0000:00:19.0 eth0: Setting page 0x0
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Setting page 0x0
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Setting page 0x6020
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Could not set Port Control page e1000e 0000:00:19.0 eth0: Setting page 0x6020
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Could not set Port Control page pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2
PM: Some devices failed to suspend

Quoted 32 lines
Quoted 31 lines
Quoted 29 lines

00:19.0 Ethernet controller [0200]: Intel Corporation 82579LM Gigabit Network Connection [8086:1502] (rev 04)
Subsystem: Lenovo Device [17aa:21f3]
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx+
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast>TAbort-
<TAbort-<MAbort->SERR-<PERR- INTx-
Latency: 0
Interrupt: pin A routed to IRQ 46
Region 0: Memory at f2500000 (32-bit, non-prefetchable)
[size=128K]

         Region 1: Memory at f253b000 (32-bit, non-prefetchable)

[size=4K]
Region 2: I/O ports at 5080 [size=32]
Capabilities: [c8] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [d0] MSI: Enable+ Count=1/1 Maskable- 64bit+
Address: 00000000fee00398 Data: 0000
Capabilities: [e0] PCI Advanced Features
AFCap: TP+ FLR+
AFCtrl: FLR-
AFStatus: TP-
Kernel driver in use: e1000e

thanks,

Signature · 2 lines
js
suse labs
#13 lore raw

Any ideas on this?

Quoted 166 lines · Jiri Slaby
Quoted 102 lines · Konstantin Khlebnikov
Quoted 96 lines · Jiri Slaby
Quoted 86 lines · Jiri Slaby
Quoted 44 lines · Bruce W
Quoted 33 lines

-----Original Message-----
From: Jiri Slaby [mailto:[email protected]] On Behalf Of Jiri Slaby
Sent: Tuesday, March 19, 2013 5:23 AM
To: Konstantin Khlebnikov
Cc: Borislav Petkov; Kirsher, Jeffrey T; Rafael J. Wysocki; Bjorn Helgaas;
[email protected]; lkml; [email protected]; Allan, Bruce W
Subject: Re: e1000e + suspend, 3.9-rc2

Quoted 15 lines
Quoted 8 lines
Quoted 1 line

Ok, I can still see the hardware error message when suspending:

And with 3.8 plus these:
PCI/PM: Clear state_saved during suspend
e1000e: fix pci-device enable-counter balance
e1000e: fix runtime power management transitions
e1000e: fix accessing to suspended device

Quoted 6 lines

I sometimes see this:
pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2

Any ideas? Am I missing some patch still?

Quoted 7 lines

Try this:
"PCI: Don't try to disable Bus Master on disconnected PCI devices"
https://patchwork.kernel.org/patch/2271641/

But I'm not sure, probably it is unrelated because this code works only (?)
during shutdown/kexec sequences.

Quoted 10 lines

I don't think it will help either. -2 here is -E1000_ERR_PHY from e1000e_write_phy_reg_mdic if I'm looking correctly. I.e. MDIC not ready
or unlike MDIC_ERROR.

I think this happened after I put the link down and tried to suspend.

Signature · 2 lines
js
suse labs
Quoted 7 lines

Sorry for not replying sooner, for some reason some of this thread was filtered
to my junk folder and I didn’t see it until now.

Jiri, can you provide the output of 'lspci -s 00:19.0 -n -vv' and confirm the scenario
in which the problem occurs? Is this easily reproduced?

Sorry about the late reply, I totally forgot about this. lspci output is attached below. The scenario is not rigid as I'm not sure when exactly this happens. It looks like I have to use power saving on that device. And I don't need to use that device at all. Here is an excerpt from one kernel boot modulo e1000e where the error occurred.

e1000e: Copyright(c) 1999 - 2012 Intel Corporation.
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: Interrupt Throttling Rate (ints/sec) set to dynamic conservative mode
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0 eth0: (PCI Express:2.5GT/s:Width x1) 3c:97:0e:35:3d:dd
e1000e 0000:00:19.0 eth0: Intel(R) PRO/1000 Network Connection e1000e 0000:00:19.0 eth0: MAC: 10, PHY: 11, PBA No: 1000FF-0FF e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: irq 46 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 43 for MSI/MSI-X
e1000e 0000:00:19.0: setting latency timer to 64
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X
e1000e 0000:00:19.0: irq 45 for MSI/MSI-X

Quoted 8 lines

e1000e 0000:00:19.0: setting latency timer to 64 e1000e 0000:00:19.0: irq 45 for MSI/MSI-X pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2

Quoted 4 lines

This still happens with 3.9.5 ...

I don't use wired net at all. This usually happens after I enable power saving.

Quoted 6 lines

I guess that '-2' is one of 'return -E1000_ERR_PHY', but all that debug messages are omitted by default.

Please enable CONFIG_DYNAMIC_DEBUG=y and mount debugfs, after that:

# echo module e1000e +p > /sys/kernel/debug/dynamic_debug/control
If it would be too verbose you can enable these messages more selective.\

Here we go at last:

e1000e 0000:00:19.0 eth0: Setting page 0x6020
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Setting page 0x6020
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: failed to enable jumbo frame workaround mode e1000e 0000:00:19.0 eth0: Setting page 0x0
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Setting page 0x0
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Setting page 0x6020
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Could not set Port Control page e1000e 0000:00:19.0 eth0: Setting page 0x6020
e1000e 0000:00:19.0 eth0: MDI Write did not complete
e1000e 0000:00:19.0 eth0: Could not set Port Control page pci_pm_suspend(): e1000_suspend+0x0/0x10 [e1000e] returns -2 dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
PM: Device 0000:00:19.0 failed to suspend async: error -2
PM: Some devices failed to suspend

Quoted 32 lines
Quoted 31 lines
Quoted 29 lines

00:19.0 Ethernet controller [0200]: Intel Corporation 82579LM Gigabit Network Connection [8086:1502] (rev 04)
Subsystem: Lenovo Device [17aa:21f3]
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx+
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast>TAbort-
<TAbort-<MAbort->SERR-<PERR- INTx-
Latency: 0
Interrupt: pin A routed to IRQ 46
Region 0: Memory at f2500000 (32-bit, non-prefetchable)
[size=128K]

         Region 1: Memory at f253b000 (32-bit, non-prefetchable)

[size=4K]
Region 2: I/O ports at 5080 [size=32]
Capabilities: [c8] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [d0] MSI: Enable+ Count=1/1 Maskable- 64bit+
Address: 00000000fee00398 Data: 0000
Capabilities: [e0] PCI Advanced Features
AFCap: TP+ FLR+
AFCtrl: FLR-
AFStatus: TP-
Kernel driver in use: e1000e

thanks,

Signature · 2 lines
js
suse labs