exynos5250: remove redundant SPI and PMIC related configs

PATCH Superseded Inderpal Singh 3 participants 6 messages Jun 7, 2013 – Jan 7, 2014 Arm Samsung Exynos

lore

Share & tools

lore

Inderpal Singh

author

2013-06-07 11:55 UTC #0 lore raw

PATCH v2 1/1 exynos5250: remove redundant SPI and PMIC related configs

They have been defined once already. Hence remove the redundant definitions.

Signed-off-by Inderpal Singh <[email protected]>

---
v1 was posted as the first patch of [1]

Changes in v2:
- split from the patchset at [1]
- removed redundant configs for PMIC
- rebased to latest u-boot-samsung master branch

[1] http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/157101

 include/configs/exynos5250-dt.h |   26 --------------------------
 1 file changed, 26 deletions(-)

include/configs/exynos5250-dt.h +0 ~~-26~~

index 62b83d4..03b07b2 100644
@@ -246,11 +246,6 @@
 #define CONFIG_SYS_I2C_SLAVE    0x0
 #define CONFIG_I2C_EDID
 
-/* PMIC */
-#define CONFIG_PMIC
-#define CONFIG_PMIC_I2C
-#define CONFIG_PMIC_MAX77686
-
 /* SPI */
 #define CONFIG_ENV_IS_IN_SPI_FLASH
 #define CONFIG_SPI_FLASH

@@ -278,27 +273,6 @@
 #define CONFIG_POWER_I2C
 #define CONFIG_POWER_MAX77686
 
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SF_DEFAULT_MODE		SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED		50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS	5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE	SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE	CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS	1
-#define CONFIG_ENV_SPI_MAX_HZ	50000000
-#endif
-
 /* Ethernet Controllor Driver */
 #ifdef CONFIG_CMD_NET
 #define CONFIG_SMC911X

Signature · 1 line

1.7.9.5

Jagan Teki

2013-06-12 19:38 UTC #1 lore raw

PATCH v2 1/1 exynos5250: remove redundant SPI and PMIC related configs

Hi,

Can you separate the PMIC and SPI changes into two different patches.

Also may i know why you remove the SPI from configs, does it defined some where or you don't want SPI at all.?

--
Thanks,
Jagan.

Quoted 61 lines · Inderpal Singh

They have been defined once already. Hence remove the redundant definitions.

Signed-off-by Inderpal Singh <[email protected]>

---
v1 was posted as the first patch of [1]

Changes in v2:
- split from the patchset at [1]
- removed redundant configs for PMIC
- rebased to latest u-boot-samsung master branch

[1] http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/157101

  include/configs/exynos5250-dt.h |   26 --------------------------
  1 file changed, 26 deletions(-)

include/configs/exynos5250-dt.h +0 ~~-26~~

index 62b83d4..03b07b2 100644
@@ -246,11 +246,6 @@
  #define CONFIG_SYS_I2C_SLAVE    0x0
  #define CONFIG_I2C_EDID
 
-/* PMIC */
-#define CONFIG_PMIC
-#define CONFIG_PMIC_I2C
-#define CONFIG_PMIC_MAX77686
-
  /* SPI */
  #define CONFIG_ENV_IS_IN_SPI_FLASH
  #define CONFIG_SPI_FLASH

@@ -278,27 +273,6 @@
  #define CONFIG_POWER_I2C
  #define CONFIG_POWER_MAX77686
 
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SF_DEFAULT_MODE		SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED		50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS	5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE	SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE	CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS	1
-#define CONFIG_ENV_SPI_MAX_HZ	50000000
-#endif
-
  /* Ethernet Controllor Driver */
  #ifdef CONFIG_CMD_NET
  #define CONFIG_SMC911X

Inderpal Singh

author

2013-06-20 08:10 UTC #2 lore raw

PATCH v2 1/1 exynos5250: remove redundant SPI and PMIC related configs

Hi Jagan,

Quoted 5 lines · Jagan Teki

Hi,
Can you separate the PMIC and SPI changes into two different patches.

Since its a minor clean up patch. I feel there is no need to split it into two.

Quoted 4 lines

Also may i know why you remove the SPI from configs, does it defined some where or you don't want SPI at all.?

As I mentioned in the commit message , these configs are redundant. They have already been defined in the same file.

Thanks,
Inder

Quoted 72 lines

--
Thanks,
Jagan.

Quoted 64 lines · Inderpal Singh

They have been defined once already. Hence remove the redundant definitions.

Signed-off-by Inderpal Singh <[email protected]>

---
v1 was posted as the first patch of [1]

Changes in v2:
- split from the patchset at [1]
- removed redundant configs for PMIC
- rebased to latest u-boot-samsung master branch

[1] http://comments.gmane.org/**gmane.comp.boot-loaders.u-**boot/157101<http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/157101>

  include/configs/exynos5250-dt.**h |   26 --------------------------
  1 file changed, 26 deletions(-)

include/configs/exynos5250-**dt.h +0 ~~-26~~

index 62b83d4..03b07b2 100644
@@ -246,11 +246,6 @@
  #define CONFIG_SYS_I2C_SLAVE    0x0
  #define CONFIG_I2C_EDID
 
-/* PMIC */
-#define CONFIG_PMIC
-#define CONFIG_PMIC_I2C
-#define CONFIG_PMIC_MAX77686
-
  /* SPI */
  #define CONFIG_ENV_IS_IN_SPI_FLASH
  #define CONFIG_SPI_FLASH

@@ -278,27 +273,6 @@
  #define CONFIG_POWER_I2C
  #define CONFIG_POWER_MAX77686
 
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SF_DEFAULT_MODE         SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED                50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS    5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE    SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE   CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS     1
-#define CONFIG_ENV_SPI_MAX_HZ  50000000
-#endif
-
  /* Ethernet Controllor Driver */
  #ifdef CONFIG_CMD_NET
  #define CONFIG_SMC911X

Jagan Teki

2013-08-08 13:45 UTC #3 lore raw

PATCH v2 1/1 exynos5250: remove redundant SPI and PMIC related configs

Hi,

Quoted 19 lines · Inderpal Singh

Hi Jagan,
Quoted 5 lines · Jagan Teki
Hi,
Can you separate the PMIC and SPI changes into two different patches.
Since its a minor clean up patch. I feel there is no need to split it into two.
Quoted 4 lines
Also may i know why you remove the SPI from configs, does it defined some where or you don't want SPI at all.?

Quoted 79 lines

As I mentioned in the commit message , these configs are redundant. They have already been defined in the same file.

Thanks,
Inder

Quoted 72 lines

--
Thanks,
Jagan.

Quoted 64 lines · Inderpal Singh

They have been defined once already. Hence remove the redundant definitions.

Signed-off-by Inderpal Singh <[email protected]>

---
v1 was posted as the first patch of [1]

Changes in v2:
- split from the patchset at [1]
- removed redundant configs for PMIC
- rebased to latest u-boot-samsung master branch

[1] http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/157101

  include/configs/exynos5250-dt.h |   26 --------------------------
  1 file changed, 26 deletions(-)

include/configs/exynos5250-dt.h +0 ~~-26~~

index 62b83d4..03b07b2 100644
@@ -246,11 +246,6 @@
  #define CONFIG_SYS_I2C_SLAVE    0x0
  #define CONFIG_I2C_EDID
 
-/* PMIC */
-#define CONFIG_PMIC
-#define CONFIG_PMIC_I2C
-#define CONFIG_PMIC_MAX77686
-
  /* SPI */
  #define CONFIG_ENV_IS_IN_SPI_FLASH
  #define CONFIG_SPI_FLASH

@@ -278,27 +273,6 @@
  #define CONFIG_POWER_I2C
  #define CONFIG_POWER_MAX77686
 
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SF_DEFAULT_MODE         SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED                50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS    5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE    SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE   CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS     1
-#define CONFIG_ENV_SPI_MAX_HZ  50000000
-#endif
-
  /* Ethernet Controllor Driver */
  #ifdef CONFIG_CMD_NET
  #define CONFIG_SMC911X

Planning to apply this.
Please comment Inder.

--
Thanks,
Jagan.

Jagan Teki

2013-12-20 19:00 UTC #4 lore raw

PATCH v2 1/1 exynos5250: remove redundant SPI and PMIC related configs

Hi Inderpal Singh,

Quoted 103 lines · Jagan Teki

Hi,
Quoted 19 lines · Inderpal Singh
Hi Jagan,
Quoted 5 lines · Jagan Teki
Hi,
Can you separate the PMIC and SPI changes into two different patches.
Since its a minor clean up patch. I feel there is no need to split it into two.
Quoted 4 lines
Also may i know why you remove the SPI from configs, does it defined some where or you don't want SPI at all.?
Quoted 79 lines
As I mentioned in the commit message , these configs are redundant. They have already been defined in the same file.
Thanks,
Inder
Quoted 72 lines
--
Thanks,
Jagan.
Quoted 64 lines · Inderpal Singh
They have been defined once already. Hence remove the redundant definitions.
Signed-off-by Inderpal Singh <[email protected]>
---
v1 was posted as the first patch of [1]
Changes in v2:
- split from the patchset at [1]
- removed redundant configs for PMIC
- rebased to latest u-boot-samsung master branch
[1] http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/157101
  include/configs/exynos5250-dt.h |   26 --------------------------
  1 file changed, 26 deletions(-)
include/configs/exynos5250-dt.h +0 ~~-26~~
index 62b83d4..03b07b2 100644
@@ -246,11 +246,6 @@
  #define CONFIG_SYS_I2C_SLAVE    0x0
  #define CONFIG_I2C_EDID
 
-/* PMIC */
-#define CONFIG_PMIC
-#define CONFIG_PMIC_I2C
-#define CONFIG_PMIC_MAX77686
-
  /* SPI */
  #define CONFIG_ENV_IS_IN_SPI_FLASH
  #define CONFIG_SPI_FLASH
@@ -278,27 +273,6 @@
  #define CONFIG_POWER_I2C
  #define CONFIG_POWER_MAX77686
 
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SF_DEFAULT_MODE         SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED                50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS    5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE    SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE   CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS     1
-#define CONFIG_ENV_SPI_MAX_HZ  50000000
-#endif
-
  /* Ethernet Controllor Driver */
  #ifdef CONFIG_CMD_NET
  #define CONFIG_SMC911X

Quoted 2 lines

Planning to apply this.
Please comment Inder.

Any inputs on this patch - was not directly apply on master. Let me know this changes are still require - if yes, please sent the relevant patch again,

Signature · 2 lines

Thanks,
Jagan.

Minkyu Kang

2014-01-07 02:13 UTC #5 lore raw

PATCH v2 1/1 exynos5250: remove redundant SPI and PMIC related configs

Dear Jagan Teki,

Quoted 106 lines · Jagan Teki

Hi Inderpal Singh,
Quoted 103 lines · Jagan Teki
Hi,
Quoted 98 lines · Inderpal Singh
Hi Jagan,
Quoted 5 lines · Jagan Teki
Hi,
Can you separate the PMIC and SPI changes into two different patches.
Since its a minor clean up patch. I feel there is no need to split it into two.
Quoted 4 lines
Also may i know why you remove the SPI from configs, does it defined some where or you don't want SPI at all.?
As I mentioned in the commit message , these configs are redundant. They have already been defined in the same file.
Thanks,
Inder
Quoted 72 lines
--
Thanks,
Jagan.
Quoted 64 lines · Inderpal Singh
They have been defined once already. Hence remove the redundant definitions.
Signed-off-by Inderpal Singh <[email protected]>
---
v1 was posted as the first patch of [1]
Changes in v2:
- split from the patchset at [1]
- removed redundant configs for PMIC
- rebased to latest u-boot-samsung master branch
[1] http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/157101
  include/configs/exynos5250-dt.h |   26 --------------------------
  1 file changed, 26 deletions(-)
include/configs/exynos5250-dt.h +0 ~~-26~~
index 62b83d4..03b07b2 100644
@@ -246,11 +246,6 @@
  #define CONFIG_SYS_I2C_SLAVE    0x0
  #define CONFIG_I2C_EDID
 
-/* PMIC */
-#define CONFIG_PMIC
-#define CONFIG_PMIC_I2C
-#define CONFIG_PMIC_MAX77686
-
  /* SPI */
  #define CONFIG_ENV_IS_IN_SPI_FLASH
  #define CONFIG_SPI_FLASH
@@ -278,27 +273,6 @@
  #define CONFIG_POWER_I2C
  #define CONFIG_POWER_MAX77686
 
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SF_DEFAULT_MODE         SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED                50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS    5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE    SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE   CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS     1
-#define CONFIG_ENV_SPI_MAX_HZ  50000000
-#endif
-
  /* Ethernet Controllor Driver */
  #ifdef CONFIG_CMD_NET
  #define CONFIG_SMC911X

Quoted 7 lines

Quoted 2 lines
Planning to apply this.
Please comment Inder.
Any inputs on this patch - was not directly apply on master. Let me know this changes are still require - if yes, please sent the relevant patch again,

In samsung tree, this patch does not need any more because another patch was fixed this issue. Please ignore this patch.

Thanks,
Minkyu Kang.