Skip to contentSkip to conversation

x86: fix typo in kexec register clearing

PATCH In review Kees Cook 3 participants 3 messages Jun 5, 2013 – Jun 12, 2013 x86

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 x86: fix typo in kexec register clearing

Fixes a typo in register clearing code. Thanks to PaX Team for fixing this originally, and James Troup for pointing it out.

---
 arch/x86/kernel/relocate_kernel_64.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/relocate_kernel_64.S +1 -1
index 7a6f3b3..f2bb9c9 100644
@@ -160,7 +160,7 @@ identity_mapped:
 	xorq    %rbp, %rbp
 	xorq	%r8,  %r8
 	xorq	%r9,  %r9
-	xorq	%r10, %r9
+	xorq	%r10, %r10
 	xorq	%r11, %r11
 	xorq	%r12, %r12
 	xorq	%r13, %r13
Signature · 6 lines
1.7.9.5


-- 
Kees Cook
Chrome OS Security
#1 lore raw

[tip:x86/urgent] x86: Fix typo in kexec register clearing

x86: Fix typo in kexec register clearing
Commit-ID:  c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
Gitweb:     http://git.kernel.org/tip/c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
Author:     Kees Cook <[email protected]>
AuthorDate: Wed, 5 Jun 2013 11:47:18 -0700
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Wed, 12 Jun 2013 15:16:18 -0700

x86: Fix typo in kexec register clearing

Fixes a typo in register clearing code. Thanks to PaX Team for fixing this originally, and James Troup for pointing it out.

---
 arch/x86/kernel/relocate_kernel_64.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/relocate_kernel_64.S +1 -1
index 7a6f3b3..f2bb9c9 100644
@@ -160,7 +160,7 @@ identity_mapped:
 	xorq    %rbp, %rbp
 	xorq	%r8,  %r8
 	xorq	%r9,  %r9
-	xorq	%r10, %r9
+	xorq	%r10, %r10
 	xorq	%r11, %r11
 	xorq	%r12, %r12
 	xorq	%r13, %r13
#2 lore raw

Re: [tip:x86/urgent] x86: Fix typo in kexec register clearing

Quoted 27 lines · tip-bot for Kees Cook
Commit-ID:  c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
Gitweb:     http://git.kernel.org/tip/c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
Author:     Kees Cook <[email protected]>
AuthorDate: Wed, 5 Jun 2013 11:47:18 -0700
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Wed, 12 Jun 2013 15:16:18 -0700

x86: Fix typo in kexec register clearing

Fixes a typo in register clearing code. Thanks to PaX Team for fixing this originally, and James Troup for pointing it out.

---
 arch/x86/kernel/relocate_kernel_64.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/relocate_kernel_64.S +0 -0
index 7a6f3b3..f2bb9c9 100644

arch/x86/kernel/relocate_kernel_64.S identity_mapped: · line 166

Quoted 8 lines
arch/x86/kernel/relocate_kernel_64.S +1 -1
@@ -160,7 +160,7 @@ identity_mapped:
 	xorq    %rbp, %rbp
 	xorq	%r8,  %r8
 	xorq	%r9,  %r9
-	xorq	%r10, %r9
+	xorq	%r10, %r10
 	xorq	%r11, %r11
 	xorq	%r12, %r12
 	xorq	%r13, %r13

As an aside: using xorq here is totally pointless; xorl would work just fine.

-hpa