Skip to contentSkip to conversation

EXYNOS: Move includes from setup.h to tzpc_init.c

PATCH New Rajeshwari Shinde 3 participants 3 messages Apr 3, 2013 – Jun 13, 2013

lore
Share & tools
lore

Rajeshwari Shinde

author
#0 lore raw

PATCH 1/1 EXYNOS: Move includes from setup.h to tzpc_init.c

These should not be in the header since not every C file needs them. Move them to the file that needs them.

Signed-off-by Simon Glass <[email protected]>
Signed-off-by Rajeshwari Shinde <[email protected]>
---
 board/samsung/smdk5250/setup.h     |    3 ---
 board/samsung/smdk5250/tzpc_init.c |    2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)
board/samsung/smdk5250/setup.h +0 -3
index 34d8bc3..68f48ea 100644
@@ -25,9 +25,6 @@
 #ifndef _SMDK5250_SETUP_H
 #define _SMDK5250_SETUP_H
 
-#include <config.h>
-#include <asm/arch/dmc.h>
-
 /* TZPC : Register Offsets */
 #define TZPC0_BASE		0x10100000
 #define TZPC1_BASE		0x10110000
board/samsung/smdk5250/tzpc_init.c +2 -0
index c833541..96e5a6c 100644
@@ -22,6 +22,8 @@
  * MA 02111-1307 USA
  */
 
+#include <config.h>
+#include <asm/arch/dmc.h>
 #include <asm/arch/tzpc.h>
 #include"setup.h"
Signature · 1 line
1.7.4.4
#1 lore raw

PATCH 1/1 EXYNOS: Move includes from setup.h to tzpc_init.c

Quoted 5 lines · Rajeshwari Shinde

These should not be in the header since not every C file needs them. Move them to the file that needs them.

Signed-off-by Simon Glass <[email protected]>
Signed-off-by Rajeshwari Shinde <[email protected]>

Tested on snow.

Acked-by Simon Glass <[email protected]>
Tested-by Simon Glass <[email protected]>
Quoted 35 lines
---
 board/samsung/smdk5250/setup.h     |    3 ---
 board/samsung/smdk5250/tzpc_init.c |    2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)
board/samsung/smdk5250/setup.h +0 -3
index 34d8bc3..68f48ea 100644
@@ -25,9 +25,6 @@
 #ifndef _SMDK5250_SETUP_H
 #define _SMDK5250_SETUP_H
 
-#include <config.h>
-#include <asm/arch/dmc.h>
-
 /* TZPC : Register Offsets */
 #define TZPC0_BASE             0x10100000
 #define TZPC1_BASE             0x10110000
board/samsung/smdk5250/tzpc_init.c +2 -1
index c833541..96e5a6c 100644
@@ -22,6 +22,8 @@
  * MA 02111-1307 USA
  */
 
+#include <config.h>
+#include <asm/arch/dmc.h>
 #include <asm/arch/tzpc.h>
 #include"setup.h"
 
--

1.7.4.4

#2 lore raw

PATCH 1/1 EXYNOS: Move includes from setup.h to tzpc_init.c

Quoted 5 lines · Simon Glass
Quoted 3 lines · Rajeshwari Shinde

These should not be in the header since not every C file needs them. Move them to the file that needs them.

Quoted 13 lines
Quoted 2 lines
Signed-off-by Simon Glass <[email protected]>
Signed-off-by Rajeshwari Shinde <[email protected]>

Tested on snow.

Acked-by Simon Glass <[email protected]>
Tested-by Simon Glass <[email protected]>
Quoted 5 lines
---
 board/samsung/smdk5250/setup.h     |    3 ---
 board/samsung/smdk5250/tzpc_init.c |    2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)

Since tzpc_init.c is moved to arch/arm/cpu/armv7/exynos, this patch is rejected.

commit 72af2fc8504daccd2f8ae2459e3e225e9c2cc512

Author: Inderpal Singh <[email protected]>
Date:   Thu Apr 4 23:09:19 2013 +0000

exynos: move tzpc_init to armv7/exynos

tzpc_init is common for all exynos5 boards, hence move it to armv7/exynos so that all other boards can use it.

Also update the smdk5250 Makefile and config file.

Signed-off-by Inderpal Singh <[email protected]>
Acked-by Chander Kashyap <[email protected]>
Signed-off-by Minkyu Kang <[email protected]>

Thanks,
Minkyu Kang.