sf: spansion: Update the name for S25FL256S flash

As the per the ID tabl the flash is under Uniform 64-kB sector architecture, hence updated with proper name.

Signed-off-by Jagannadha Sutradharudu Teki <[email protected]>

---
Changes for v2:
- none

  drivers/mtd/spi/spansion.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mtd/spi/spansion.c +0 -0

index 307b852..2218e2f 100644

This commit is based on the patch from Xie Xiaobo <[email protected]> with commit head title as "sf: spansion: Add support for S25FL128S". pulled the same code changes into current u-boot tree with little update on the name field.

http://patchwork.ozlabs.org/patch/218145/

SPANSION recommend S25FL128S supersedes S25FL129P, and the two flash memory have the same device ID and Memory architecture. So they can use the same config parameters.

Signed-off-by Xie Xiaobo <[email protected]>

Signed-off-by Jagannadha Sutradharudu Teki <[email protected]>

---
Changes for v2:
- none

 drivers/mtd/spi/spansion.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mtd/spi/spansion.c +0 -0

index 2218e2f..dad4fbb 100644

Add support for Winbond W25Q80BW SPI flash.

This patch corrected the flash name, nr_blocks and also commit message header from below patch. "sf: winbond: add W25Q32"
(sha1: c969abc47033d6f810d3c9dbdb994ea9d691d038)

Signed-off-by Jagannadha Sutradharudu Teki <[email protected]>

---
Changes for v2:
- none

  drivers/mtd/spi/winbond.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/mtd/spi/winbond.c +0 -0

index cb57ce0..a7cd51f 100644

This patch corrected the nr_blocks used for W25Q32DW SPI flash.

nr_blcoks are incorrectly assigned on below patch
"sf: winbond: add W25Q32DW"
(sha1: 772ba15474f73adc942e817cc072b6e9750836cc)

Signed-off-by Jagannadha Sutradharudu Teki <[email protected]>

---
Changes for v2:
- none

  drivers/mtd/spi/winbond.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mtd/spi/winbond.c +0 -0

index a7cd51f..8457808 100644

Use the exact names for W25Q 0x40XX ID's flash parts, as the same sizes of flashes comes with different ID's. so-that the distinguishes becomes easy with this change.

Signed-off-by Jagannadha Sutradharudu Teki <[email protected]>

---
Changes for v2:
- none

 drivers/mtd/spi/winbond.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

drivers/mtd/spi/winbond.c +0 -0

index 8457808..3c0ca88 100644
@@ -55,27 +55,27 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {

drivers/mtd/spi/winbond.c +3 -4

        },
        {
                .id                     = 0x4016,
                .nr_blocks              = 64,
-               .name                   = "W25Q32",
+               .name                   = "W25Q32BV",
        },
        {
                .id                     = 0x4017,
                .nr_blocks              = 128,
-               .name                   = "W25Q64",
+               .name                   = "W25Q64CV",
        },
        {
                .id                     = 0x4018,
                .nr_blocks              = 256,
-               .name                   = "W25Q128",
+               .name                   = "W25Q128BV",
        },
        {
                .id                     = 0x4019,
--

1.8.3

Hi,

Quoted 24 lines · Jagannadha Sutradharudu Teki

Use the exact names for W25Q 0x40XX ID's flash parts, as the same sizes of flashes comes with different ID's. so-that the distinguishes becomes easy with this change.

Signed-off-by Jagannadha Sutradharudu Teki <[email protected]>

---
Changes for v2:
- none

 drivers/mtd/spi/winbond.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

drivers/mtd/spi/winbond.c +1 -1

index 8457808..3c0ca88 100644
@@ -55,27 +55,27 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
                .id                     = 0x4014,
                .nr_blocks              = 16,
-               .name                   = "W25Q80BL",
+               .name                   = "W25Q80BL/W25Q80BV",
        },
        {

drivers/mtd/spi/winbond.c static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { · line 63

Quoted 4 lines

drivers/mtd/spi/winbond.c +1 -1

                .id                     = 0x4015,
                .nr_blocks              = 32,
-               .name                   = "W25Q16",
+               .name                   = "W25Q16CL/W25Q16DV",

The id codes were same for these two parts, I think there is no way to detect the separately.
Any idea?

Hi,

Quoted 24 lines · Jagannadha Sutradharudu Teki

Use the exact names for W25Q 0x40XX ID's flash parts, as the same sizes of flashes comes with different ID's. so-that the distinguishes becomes easy with this change.

Signed-off-by Jagannadha Sutradharudu Teki <[email protected]>

---
Changes for v2:
- none

 drivers/mtd/spi/winbond.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

drivers/mtd/spi/winbond.c +1 -1

index 8457808..3c0ca88 100644
@@ -55,27 +55,27 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
                .id                     = 0x4014,
                .nr_blocks              = 16,
-               .name                   = "W25Q80BL",
+               .name                   = "W25Q80BL/W25Q80BV",
        },
        {

drivers/mtd/spi/winbond.c static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { · line 63

Quoted 4 lines

drivers/mtd/spi/winbond.c +1 -1

                .id                     = 0x4015,
                .nr_blocks              = 32,
-               .name                   = "W25Q16",
+               .name                   = "W25Q16CL/W25Q16DV",

The id codes were same for these two parts, I think there is no way to detect the separately.
Any idea?

Hi,

Quoted 24 lines · Jagannadha Sutradharudu Teki

Use the exact names for W25Q 0x40XX ID's flash parts, as the same sizes of flashes comes with different ID's. so-that the distinguishes becomes easy with this change.

Signed-off-by Jagannadha Sutradharudu Teki <[email protected]>

---
Changes for v2:
- none

 drivers/mtd/spi/winbond.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

drivers/mtd/spi/winbond.c +1 -1

index 8457808..3c0ca88 100644
@@ -55,27 +55,27 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
        {
                .id                     = 0x4014,
                .nr_blocks              = 16,
-               .name                   = "W25Q80BL",
+               .name                   = "W25Q80BL/W25Q80BV",
        },
        {

drivers/mtd/spi/winbond.c static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { · line 63

Quoted 4 lines

drivers/mtd/spi/winbond.c +1 -1

                .id                     = 0x4015,
                .nr_blocks              = 32,
-               .name                   = "W25Q16",
+               .name                   = "W25Q16CL/W25Q16DV",

The id codes were same for these two parts, I think there is no way to detect the separately.
Any idea?

Jagan,

So far, our major customer request is to have the same ID for backward compatibility. Therefore the IDs are the same for W25Q16C and W25Q16D. As for the 2.5V parts (W25Q80BL/W25Q16CL), they are the same die as the 3V (W25Q80BV/W25Q16CV), so the IDs are the same as well.

The differences between the pairs are not that significant. We consider them as drop-in compatible.

Jagan,

So far, our major customer request is to have the same ID for backward compatibility. Therefore the IDs are the same for W25Q16C and W25Q16D. As for the 2.5V parts (W25Q80BL/W25Q16CL), they are the same die as the 3V (W25Q80BV/W25Q16CV), so the IDs are the same as well.

The differences between the pairs are not that significant. We consider them as drop-in compatible.

Quoted 16 lines

Quoted 15 lines

Review

Quoted 9 lines

And are your ok with below representation for common id's parts ?

(quoted diff) +8 -0

+               .name                   = "W25Q80BL/W25Q80BV",
+               .name                   = "W25Q16CL/W25Q16DV",
+               .name                   = "W25Q32BV/W25Q32FV_SPI",
+               .name                   = "W25Q64CV/W25Q64FV_SPI",
+               .name                   = "W25Q128BV/W25Q128FV_SPI",
+               .name                   = "W25Q32DW/W25Q32FV_QPI",
+               .name                   = "W25Q64DW/W25Q64FV_QPI",
+               .name                   = "W25Q128FW/W25Q128FV_QPI",

Any comments on above representation of part names, as the id's to these pairs are common.
This will enhance u-boot sf to support all parts from winbond, but seems like different view of names.

Quoted 1 line

what's the difference between that parts?

parts were diff in terms of voltages and sone SPI and QPI configurations. but from the manufacture defeat, pair of parts were same ID's

Quoted 3 lines

Does software care if it is W25G80BL or BV?
Or software behaviour is the same and there is only difference in voltage or so.

SW is same even if it 1.8 or 3.3 v.
The only reason for giving the pair of names to support all different parts

Quoted 1 line

I don't care about it so much but it is increase u-boot size.

Why does u-boot size increase, is it because of below representation on name filed

      = "W25Q80BL/W25Q80BV"

move this discussion back to mailing list.

Quoted 16 lines · Jagan Teki

Quoted 16 lines

Quoted 15 lines

Review

Quoted 9 lines

And are your ok with below representation for common id's parts ?

(quoted diff) +8 -0

+               .name                   = "W25Q80BL/W25Q80BV",
+               .name                   = "W25Q16CL/W25Q16DV",
+               .name                   = "W25Q32BV/W25Q32FV_SPI",
+               .name                   = "W25Q64CV/W25Q64FV_SPI",
+               .name                   = "W25Q128BV/W25Q128FV_SPI",
+               .name                   = "W25Q32DW/W25Q32FV_QPI",
+               .name                   = "W25Q64DW/W25Q64FV_QPI",
+               .name                   = "W25Q128FW/W25Q128FV_QPI",

Any comments on above representation of part names, as the id's to these pairs are common.
This will enhance u-boot sf to support all parts from winbond, but seems like different view of names.

Quoted 4 lines

Quoted 1 line

what's the difference between that parts?

parts were diff in terms of voltages and sone SPI and QPI configurations. but from the manufacture defeat, pair of parts were same ID's

ok.

Quoted 6 lines

Quoted 3 lines

Does software care if it is W25G80BL or BV?
Or software behaviour is the same and there is only difference in voltage or so.

SW is same even if it 1.8 or 3.3 v.
The only reason for giving the pair of names to support all different parts

You are supporting them but you are just not list them.

Quoted 4 lines

Quoted 1 line

I don't care about it so much but it is increase u-boot size.

Why does u-boot size increase, is it because of below representation on name filed

      = "W25Q80BL/W25Q80BV"

Just because of longer names which go probably to rodata section.

It is not a problem for me at all.