Skip to contentSkip to conversation

ARM: OMAP5: Fix omap5 standalone build break

PATCH New Rajendra Nayak 2 participants 2 messages Jun 14, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP5: Fix omap5 standalone build break

Building omap5 standalone results in the below errors..

arch/arm/mach-omap2/built-in.o: In function `scu_gp_set':
arch/arm/mach-omap2/sleep44xx.S:132: undefined reference to scu_power_mode' arch/arm/mach-omap2/built-in.o: In function scu_gp_clear':
arch/arm/mach-omap2/sleep44xx.S:229: undefined reference to scu_power_mode' arch/arm/mach-omap2/built-in.o: In function omap4_smp_prepare_cpus':
arch/arm/mach-omap2/omap-smp.c:211: undefined reference to scu_enable' arch/arm/mach-omap2/built-in.o: In function omap4_smp_init_cpus':
arch/arm/mach-omap2/omap-smp.c:185: undefined reference to `scu_get_core_count'

Fix this by adding the missing select for HAVE_ARM_SCU for SOC_OMAP5

---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-omap2/Kconfig +1 -0
index f49cd51..81690a2 100644
@@ -109,6 +109,7 @@ config SOC_OMAP5
 	select ARM_CPU_SUSPEND if PM
 	select ARM_GIC
 	select CPU_V7
+	select HAVE_ARM_SCU if SMP
 	select HAVE_SMP
 	select COMMON_CLK
 	select HAVE_ARM_ARCH_TIMER
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: OMAP5: Fix omap5 standalone build break

Quoted 11 lines · Rajendra Nayak

Building omap5 standalone results in the below errors..

arch/arm/mach-omap2/built-in.o: In function `scu_gp_set':
arch/arm/mach-omap2/sleep44xx.S:132: undefined reference to scu_power_mode' arch/arm/mach-omap2/built-in.o: In function scu_gp_clear':
arch/arm/mach-omap2/sleep44xx.S:229: undefined reference to scu_power_mode' arch/arm/mach-omap2/built-in.o: In function omap4_smp_prepare_cpus':
arch/arm/mach-omap2/omap-smp.c:211: undefined reference to scu_enable' arch/arm/mach-omap2/built-in.o: In function omap4_smp_init_cpus':
arch/arm/mach-omap2/omap-smp.c:185: undefined reference to `scu_get_core_count'

Quoted 5 lines

Fix this by adding the missing select for HAVE_ARM_SCU for SOC_OMAP5

---

NAK. Similar patch [1] was posted by Vincent a while back. The right fix to remove the scu related dependency with OMAP5 code.

Regards,
Santosh

[1] https://patchwork.kernel.org/patch/2568091/