ARM: shmobile: BOCK-W: add Ether support
PATCH v3 1/1 ARM: shmobile: BOCK-W: add Ether support
Register Ether device from bockw_init(), passing the platform data to it, adding only the RMII pin group to bockw_pinctrl_map[]. Although the LINK signal exists on the board, it's connected to the link/activity LED output of the PHY, thus the link disappears and reappears after each packet. We'd be better off ignoring such signal and getting the link state from the PHY indirectly.
---
The patch is atop of Simon's 'renesas.git' repo, 'renesas-next-20130528' tag and the USB patches just reposted. I decided to move it ahead of the VIN patches as it can be merged right now since all dependecies have been already met.
Changes from version 2:
- resolved rejects due to patch move;
- removed the code dealing with the pin conflict with VIN1 and the note related to it from the changelog.
Changes from the original posting:
- refreshed the patch.
arch/arm/mach-shmobile/board-bockw.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
arch/arm/mach-shmobile/board-bockw.c +18 -0
@@ -65,7 +65,24 @@ static struct sh_mobile_sdhi_info sdhi0_static struct rcar_phy_platform_data usb_phy_platform_data__initdata ; +static struct sh_eth_plat_data ether_platform_data__initdata = { + .phy =0x01 , + .edmac_endian =EDMAC_LITTLE_ENDIAN , + .register_type =SH_ETH_REG_FAST_RCAR , + .phy_interface =PHY_INTERFACE_MODE_RMII , +/* +* Although the LINK signal is available on the board, it's connected to +* the link/activity LED output of the PHY, thus the link disappears and +* reappears after each packet. We'd be better off ignoring such signal +* and getting the link state from the PHY indirectly. +*/ + .no_ether_link =1 , +}; +static const struct pinctrl_map bockw_pinctrl_map[] = { +/* Ether */ +PIN_MAP_MUX_GROUP_DEFAULT ("sh-eth" ,"pfc-r8a7778" , +"ether_rmii" ,"ether" ),/* SCIF0 */ PIN_MAP_MUX_GROUP_DEFAULT ("sh-sci.0" ,"pfc-r8a7778" ,"scif0_data_a" ,"scif0" ),
@@ -98,6 +115,7 @@ static void __init bockw_init(void)r8a7778_init_irq_extpin (1 );r8a7778_add_standard_devices ();r8a7778_add_usb_phy_device (&usb_phy_platform_data); +r8a7778_add_ether_device (ðer_platform_data);pinctrl_register_mappings (bockw_pinctrl_map,ARRAY_SIZE (bockw_pinctrl_map));
PATCH v3 1/1 ARM: shmobile: BOCK-W: add Ether support
Quoted 6 lines · Sergei Shtylyov
Register Ether device from
bockw_init(), passing the platform data to it, adding only the RMII pin group to bockw_pinctrl_map[]. Although the LINK signal exists on the board, it's connected to the link/activity LED output of the PHY, thus the link disappears and reappears after each packet. We'd be better off ignoring such signal and getting the link state from the PHY indirectly.
Quoted 6 lines
Signed-off-by Sergei Shtylyov <[email protected]>---
The patch is atop of Simon's 'renesas.git' repo, 'renesas-next-20130528' tag and the USB patches just reposted. I decided to move it ahead of the VIN patches as it can be merged right now since all dependecies have been already met.
Thanks, queued up in the boards branch.
PATCH v3 1/1 ARM: shmobile: BOCK-W: add Ether support
Hello.
Quoted 6 lines · Simon Horman
Quoted 5 lines
Register Ether device from
bockw_init(), passing the platform data to it, adding only the RMII pin group to bockw_pinctrl_map[]. Although the LINK signal exists on the board, it's connected to the link/activity LED output of the PHY, thus the link disappears and reappears after each packet. We'd be better off ignoring such signal and getting the link state from the PHY indirectly.
Quoted 8 lines
Quoted 6 lines
Signed-off-by Sergei Shtylyov <[email protected]>---
The patch is atop of Simon's 'renesas.git' repo, 'renesas-next-20130528' tag and the USB patches just reposted. I decided to move it ahead of the VIN patches as it can be merged right now since all dependecies have been already met.Thanks, queued up in the boards branch.
Has this been pulled by Olof/Arnd? If not, is it possible to amend
this patch or should I send an incremental one? I forgot to update the platform device name from "sh-eth" to "r8a777x-ether" in the PinMux table, in accordance to the R8A7778 Ether device name fix. It would be good if this got into 3.11 as otherwise Ether support on BOCK-W wouldn't work. I have discovered the mistake only yesterday.
WBR, Sergei
PATCH v3 1/1 ARM: shmobile: BOCK-W: add Ether support
Quoted 19 lines · Sergei Shtylyov
Hello.
Quoted 6 lines · Simon Horman
Quoted 5 lines
Register Ether device from
bockw_init(), passing the platform data to it, adding only the RMII pin group to bockw_pinctrl_map[]. Although the LINK signal exists on the board, it's connected to the link/activity LED output of the PHY, thus the link disappears and reappears after each packet. We'd be better off ignoring such signal and getting the link state from the PHY indirectly.Quoted 8 lines
Quoted 6 lines
Signed-off-by Sergei Shtylyov <[email protected]>---
The patch is atop of Simon's 'renesas.git' repo, 'renesas-next-20130528' tag and the USB patches just reposted. I decided to move it ahead of the VIN patches as it can be merged right now since all dependecies have been already met.Thanks, queued up in the boards branch.
Quoted 7 lines
Has this been pulled by Olof/Arnd? If not, is it possible to
amend this patch or should I send an incremental one? I forgot to update the platform device name from "sh-eth" to "r8a777x-ether" in the PinMux table, in accordance to the R8A7778 Ether device name fix. It would be
good if this got into 3.11 as otherwise Ether support on BOCK-W wouldn't work. I have discovered the mistake only yesterday.
This patch is not present in arm-soc nor have I sent a pull request for it, though I was planing to do so today.
I think that the best thing would be if you sent an incremental patch which I can add to the boards branch and then send a pull-request for that branch to Olof and Arnd.
PATCH v3 1/1 ARM: shmobile: BOCK-W: add Ether support
In reply to Sergei ShtylyovQuoted 39 lines · Sergei Shtylyov
Register Ether device from
bockw_init(), passing the platform data to it, adding only the RMII pin group to bockw_pinctrl_map[]. Although the LINK signal exists on the board, it's connected to the link/activity LED output of the PHY, thus the link disappears and reappears after each packet. We'd be better off ignoring such signal and getting the link state from the PHY indirectly.Signed-off-by Sergei Shtylyov <[email protected]>---
The patch is atop of Simon's 'renesas.git' repo, 'renesas-next-20130528' tag and the USB patches just reposted. I decided to move it ahead of the VIN patches as it can be merged right now since all dependecies have been already met.Changes from version 2:
- resolved rejects due to patch move;
- removed the code dealing with the pin conflict with VIN1 and the note related to it from the changelog.Changes from the original posting:
- refreshed the patch.arch/arm/mach-shmobile/board-bockw.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)Index:
renesas/arch/arm/mach-shmobile/board-bockw.c
===================================================================arch/arm/mach-shmobile/board-bockw.c +7
-0@@ -65,7 +65,24 @@ static struct sh_mobile_sdhi_info sdhi0_static struct rcar_phy_platform_data usb_phy_platform_data__initdata ; +static struct sh_eth_plat_data ether_platform_data__initdata = { + .phy =0x01 , + .edmac_endian =EDMAC_LITTLE_ENDIAN , + .register_type =SH_ETH_REG_FAST_RCAR , + .phy_interface =PHY_INTERFACE_MODE_RMII , +/* +* Although the LINK signal is available on the board, it's connected to
arch/arm/mach-shmobile/board-bockw.c static struct sh_mobile_sdhi_info sdhi0_ · line 84
Quoted 10 lines
arch/arm/mach-shmobile/board-bockw.c +9
-0+* the link/activity LED output of the PHY, thus the link disappears and +* reappears after each packet. We'd be better off ignoring such signal +* and getting the link state from the PHY indirectly. +*/ + .no_ether_link = 1, +}; +static const struct pinctrl_map bockw_pinctrl_map[] = { +/* Ether */ + PIN_MAP_MUX_GROUP_DEFAULT("sh-eth", "pfc-r8a7778",
Darn, I should have changed that to "r8a777x-ether" in view of the
changes queued in the 'net-next.git' repo and the v2 of the "fix Ether device name" patch. I've completely overlooked that...
WBR, Sergei