mmc: dw_mmc: remove the MMC_CAP_8_BIT_DATA in dw_mmc_caps[]
Jaehoon Chung
maintainerPATCH 1/1 mmc: dw_mmc: remove the MMC_CAP_8_BIT_DATA in dw_mmc_caps[]
This capability didn't need to set in dw_mmc_caps[]. In dw-mmc.c, this capability could be set with bus_width value.
--- drivers/mmc/host/dw_mmc-exynos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mmc/host/dw_mmc-exynos.c +1 -2
@@ -154,8 +154,7 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host)/* Common capabilities of Exynos4/Exynos5 SoC */ static unsigned long exynos_dwmmc_caps[4 ] = { -MMC_CAP_UHS_DDR50 |MMC_CAP_1_8V_DDR | -MMC_CAP_8_BIT_DATA |MMC_CAP_CMD23 , +MMC_CAP_UHS_DDR50 |MMC_CAP_1_8V_DDR |MMC_CAP_CMD23 ,MMC_CAP_CMD23 ,MMC_CAP_CMD23 ,MMC_CAP_CMD23 ,
Signature · 1 line
1.7.9.5
Quoted 2 lines · Jaehoon Chung
This capability didn't need to set in dw_mmc_caps[]. In
dw-mmc.c, this capability could be set withbus_widthvalue.
You're right. It can be set from dw_mci_of_get_bus_wd. But I have another idea. exynos_dwmmc_caps is host own capability. As we know, host#0 support 8-bit widths.
This capability is meaningful by default at this view. On the other hand, we don't need to refer to bus_width value.
If we exclude bus-width capability from exynos_dwmmc_caps, it should assume that bus-width is decided from outside. Then, I think the related comment should be included.
Thanks,
Seungwon Jeon
Quoted 26 lines
Signed-off-by Jaehoon Chung <[email protected]>--- drivers/mmc/host/dw_mmc-exynos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/mmc/host/dw_mmc-exynos.c +1
-3@@ -154,8 +154,7 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host)/* Common capabilities of Exynos4/Exynos5 SoC */ static unsigned long exynos_dwmmc_caps[4 ] = { -MMC_CAP_UHS_DDR50 |MMC_CAP_1_8V_DDR | -MMC_CAP_8_BIT_DATA |MMC_CAP_CMD23 , +MMC_CAP_UHS_DDR50 |MMC_CAP_1_8V_DDR |MMC_CAP_CMD23 ,MMC_CAP_CMD23 ,MMC_CAP_CMD23 ,MMC_CAP_CMD23 , --1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html