ARM: mxs: Make the console buffer smaller
PATCH 1/1 ARM: mxs: Make the console buffer smaller
Using 1024 bytes for console buffer is unnecessarily too much, lower the amount for all MXS boards to 256.
--- include/configs/mxs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Note: This depends on http://patchwork.ozlabs.org/patch/251631/
include/configs/mxs.h +1 -1
@@ -92,7 +92,7 @@#ifndef CONFIG_SYS_PROMPT #define CONFIG_SYS_PROMPT "=> "#endif -#define CONFIG_SYS_CBSIZE 1024/* Console I/O buffer size */ +#define CONFIG_SYS_CBSIZE 256/* Console I/O buffer size */ #define CONFIG_SYS_PBSIZE \ (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)/* Print buffer size */
Signature · 1 line
1.7.10.4
PATCH 1/1 ARM: mxs: Make the console buffer smaller
Hi Marek,
Quoted 20 lines · Marek Vasut
Using 1024 bytes for console buffer is unnecessarily too much, lower the amount for all MXS boards to 256.
Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Lauri Hintsala <[email protected]>Cc Otavio Salvador <[email protected]>Cc Stefano Babic <[email protected]>--- include/configs/mxs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Note: This depends on http://patchwork.ozlabs.org/patch/251631/
include/configs/mxs.h +0
-0
include/configs/mxs.h line 98
Quoted 8 lines
include/configs/mxs.h +1
-1@@ -92,7 +92,7 @@#ifndef CONFIG_SYS_PROMPT #define CONFIG_SYS_PROMPT "=> "#endif -#define CONFIG_SYS_CBSIZE 1024/* Console I/O buffer size */ +#define CONFIG_SYS_CBSIZE 256/* Console I/O buffer size */ #define CONFIG_SYS_PBSIZE \ (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)/* Print buffer size */
I am missing something: which is the real advantage to reduce the console buffer ? I do not think that the saved memory is worth, and on the other side more elaborated scripts (usings nested if-then-else) are quite long nowadays.
Best regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 ARM: mxs: Make the console buffer smaller
Hello Stefano,
I'm CCing Wolfgang,
Quoted 33 lines
Hi Marek,
Quoted 30 lines · Marek Vasut
Using 1024 bytes for console buffer is unnecessarily too much, lower the amount for all MXS boards to 256.
Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Lauri Hintsala <[email protected]>Cc Otavio Salvador <[email protected]>Cc Stefano Babic <[email protected]>---
include/configs/mxs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Note: This depends on http://patchwork.ozlabs.org/patch/251631/
include/configs/mxs.h +1
-1@@ -92,7 +92,7 @@#ifndef CONFIG_SYS_PROMPT #define CONFIG_SYS_PROMPT "=> "#endif -#define CONFIG_SYS_CBSIZE 1024/* Console I/O buffer size */ +#define CONFIG_SYS_CBSIZE 256/* Console I/O buffer size */ #define
CONFIG_SYS_PBSIZE\
Quoted 8 lines
include/configs/mxs.h line 98
Quoted 3 lines
include/configs/mxs.h +0
-0(CONFIG_SYS_CBSIZE +sizeof (CONFIG_SYS_PROMPT ) +16 )/* Print buffer size */ I am missing something: which is the real advantage to reduce the console buffer ? I do not think that the saved memory is worth, and on the other side more elaborated scripts (usings nested if-then-else) are quite long nowadays.
True, but so far they didn't overflow this limit I believe. Some of them are hanging on the verge of blowing it though, good point.
Best regards,
Marek Vasut
PATCH 1/1 ARM: mxs: Make the console buffer smaller
Hallo Marek,
Quoted 7 lines · Marek Vasut
Quoted 4 lines
I am missing something: which is the real advantage to reduce the console buffer ? I do not think that the saved memory is worth, and on the other side more elaborated scripts (usings nested if-then-else) are quite long nowadays.
True, but so far they didn't overflow this limit I believe. Some of them are hanging on the verge of blowing it though, good point.
I think that a point to consider is if all scripts are already provided or we let the user/owner of the board to add his own scripts, as I presume. It is pity if he cannot do what u-boot really supports only to save some bytes.
Best regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 ARM: mxs: Make the console buffer smaller
Quoted 9 lines · Stefano Babic
Hallo Marek,
Quoted 5 lines · Marek Vasut
Quoted 4 lines
I am missing something: which is the real advantage to reduce the console buffer ? I do not think that the saved memory is worth, and on the other side more elaborated scripts (usings nested if-then-else) are quite long nowadays.
Quoted 7 lines
Quoted 2 lines
True, but so far they didn't overflow this limit I believe. Some of them are hanging on the verge of blowing it though, good point.
I think that a point to consider is if all scripts are already provided or we let the user/owner of the board to add his own scripts, as I presume. It is pity if he cannot do what u-boot really supports only to save some bytes.
I think this is more than enough to justify a bigger buffer.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750