Skip to contentSkip to conversation

ARM: dts: Enable RTC node for exynos5250

PATCH New Tushar Behera 3 participants 6 messages Jun 14, 2013 – Jun 17, 2013

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Tushar Behera

author
#0 lore raw

PATCH 1/1 ARM: dts: Enable RTC node for exynos5250

The kernel dump produced by s3c-rtc driver as reported by commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5") are no longer reproducible in latest kernel.

Hence it would be good to re-enable RTC support for EXYNOS5250.

Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/boot/dts/exynos5250.dtsi |    1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/exynos5250.dtsi +0 -1
index 0673524..ce4a150 100644
@@ -188,7 +188,6 @@
 		interrupts = <0 43 0>, <0 44 0>;
 		clocks = <&clock 337>;
 		clock-names = "rtc";
-		status = "disabled";
 	};
 
 	tmu at 10060000 {
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: dts: Enable RTC node for exynos5250

Tushar,

Quoted 10 lines · Tushar Behera

The kernel dump produced by s3c-rtc driver as reported by commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5") are no longer reproducible in latest kernel.

Hence it would be good to re-enable RTC support for EXYNOS5250.

Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/boot/dts/exynos5250.dtsi |    1 -
 1 file changed, 1 deletion(-)

I would prefer we not commit this.

The original commit wasn't just about avoiding the bug (though that was a nice side effect). My understanding is that the SoC dtsi file ought to have most peripherals disabled by default and individual board dts files should enable the peripherals that they want. I think exynos5250 is particularly bad about this right now (it starts with most peripherals enabled) but that should probably be fixed...

If my understanding is wrong, others on the list should definitely speak up! :)

-Doug

author
#2 lore raw

PATCH 1/1 ARM: dts: Enable RTC node for exynos5250

Quoted 10 lines · Doug Anderson

Tushar,

Quoted 6 lines · Tushar Behera

The kernel dump produced by s3c-rtc driver as reported by commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5") are no longer reproducible in latest kernel.

Hence it would be good to re-enable RTC support for EXYNOS5250.

Quoted 8 lines
Quoted 4 lines
Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/boot/dts/exynos5250.dtsi |    1 -
 1 file changed, 1 deletion(-)

I would prefer we not commit this.

The original commit wasn't just about avoiding the bug (though that

I thought the intention of the original commit was just that. :-)

Quoted 6 lines

was a nice side effect). My understanding is that the SoC dtsi file ought to have most peripherals disabled by default and individual board dts files should enable the peripherals that they want. I think exynos5250 is particularly bad about this right now (it starts with most peripherals enabled) but that should probably be fixed...

I agree, all the peripherals should be fixed for this, not just RTC.

Quoted 2 lines

If my understanding is wrong, others on the list should definitely speak up! :)

Let me know if you still prefer to keep RTC node disabled on exynos5250.dtsi. In that case, I would enable it only for Arndale.

Quoted 1 line

-Doug

Thanks.
--
Tushar Behera

author
#3 lore raw

PATCH v2 1/1 ARM: dts: Enable RTC node for Arndale

The issues reported in commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5") are no longer reproduced on EXYNOS5250 based Arndale board. Hence re-enabling RTC support for Arndale board.

This is helpful for testing S2R on Arndale board.

Signed-off-by Tushar Behera <[email protected]>

---
Changes for V2:
* RTC node is enabled only for Arndale board. Earlier it was enabled in exynos5250.dtsi.

 arch/arm/boot/dts/exynos5250-arndale.dts |    4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/exynos5250-arndale.dts +4 -0
index 02cfc76..b38080a 100644
@@ -449,4 +449,8 @@
 			clock-frequency = <24000000>;
 		};
 	};
+
+	rtc {
+		status = "okay";
+	};
 };
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH v2 1/1 ARM: dts: Enable RTC node for Arndale

Tushar,

Quoted 6 lines · Tushar Behera

The issues reported in commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5") are no longer reproduced on EXYNOS5250 based Arndale board. Hence re-enabling RTC support for Arndale board.

This is helpful for testing S2R on Arndale board.

Quoted 8 lines
Signed-off-by Tushar Behera <[email protected]>

---
Changes for V2:
* RTC node is enabled only for Arndale board. Earlier it was enabled in exynos5250.dtsi.

 arch/arm/boot/dts/exynos5250-arndale.dts |    4 ++++
 1 file changed, 4 insertions(+)

Looks good! I'll send up one for snow too.

Reviewed-by Doug Anderson <[email protected]>
Applied
#5 lore raw

PATCH v2 1/1 ARM: dts: Enable RTC node for Arndale

In reply to Tushar Behera
Quoted 20 lines · Tushar Behera

The issues reported in commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5") are no longer reproduced on EXYNOS5250 based Arndale board. Hence re-enabling RTC support for Arndale board.

This is helpful for testing S2R on Arndale board.

Signed-off-by Tushar Behera<[email protected]>

---
Changes for V2:
* RTC node is enabled only for Arndale board. Earlier it was enabled in exynos5250.dtsi.

  arch/arm/boot/dts/exynos5250-arndale.dts |    4 ++++
  1 file changed, 4 insertions(+)
arch/arm/boot/dts/exynos5250-arndale.dts +0 -0
index 02cfc76..b38080a 100644

arch/arm/boot/dts/exynos5250-arndale.dts line 456

Quoted 8 lines
arch/arm/boot/dts/exynos5250-arndale.dts +4 -0
@@ -449,4 +449,8 @@
  			clock-frequency =<24000000>;
  		};
  	};
+
+	rtc {
+		status = "okay";
+	};
  };

Applied, thanks.

- Kukjin