Skip to contentSkip to conversation

gpio: msm-v1: Remove errant __devinit to fix compile

PATCH In review Stephen Boyd 3 participants 5 messages Jun 4, 2013 – Jun 21, 2013

Subsystems (2)
Arm Qualcomm mailing list GPIO
lore
Share & tools
lore

Stephen Boyd

author
#0 lore raw

PATCH 1/1 gpio: msm-v1: Remove errant __devinit to fix compile

Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver, 2013-03-04) was based on an older kernel where __devinit still existed. Remove the erroneous __devinit marking.

Cc David Brown <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>
---
 drivers/gpio/gpio-msm-v1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-msm-v1.c +1 -1
index c798585a..fb2cc90 100644
@@ -630,7 +630,7 @@ static struct irq_chip msm_gpio_irq_chip = {
 	.irq_set_type  = msm_gpio_irq_set_type,
 };
 
-static int __devinit gpio_msm_v1_probe(struct platform_device *pdev)
+static int gpio_msm_v1_probe(struct platform_device *pdev)
 {
 	int i, j = 0;
 	const struct platform_device_id *dev_id = platform_get_device_id(pdev);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
#1 lore raw
Quoted 6 lines · Stephen Boyd

Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver, 2013-03-04) was based on an older kernel where __devinit still existed. Remove the erroneous __devinit marking.

Cc David Brown <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>

Patch applied.

Yours,
Linus Walleij

author
#2 lore raw
Quoted 11 lines · Linus Walleij
Quoted 6 lines · Stephen Boyd

Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver, 2013-03-04) was based on an older kernel where __devinit still existed. Remove the erroneous __devinit marking.

Cc David Brown <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>

Patch applied.

Thanks. It looks like David picked this up and sent it off to arm-soc last week. Cc'ing Olof for awareness of a possible duplicate.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
#3 lore raw
Quoted 7 lines · Stephen Boyd
Quoted 6 lines · Linus Walleij
Quoted 4 lines · Stephen Boyd

Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver, 2013-03-04) was based on an older kernel where __devinit still existed. Remove the erroneous __devinit marking.

Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
Cc David Brown <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>

Patch applied.

Thanks. It looks like David picked this up and sent it off to arm-soc last week. Cc'ing Olof for awareness of a possible duplicate.

Did that get ack by some GPIO maintainer?

This needs to go through the GPIO tree, but I guess GIT will survive if it ends up in two trees.

Yours,
Linus Walleij

#4 lore raw
Quoted 12 lines · Linus Walleij
Quoted 11 lines · Stephen Boyd
Quoted 9 lines · Linus Walleij
Quoted 6 lines · Stephen Boyd

Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver, 2013-03-04) was based on an older kernel where __devinit still existed. Remove the erroneous __devinit marking.

Cc David Brown <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>

Patch applied.

Quoted 7 lines
Quoted 2 lines

Thanks. It looks like David picked this up and sent it off to arm-soc last week. Cc'ing Olof for awareness of a possible duplicate.

Did that get ack by some GPIO maintainer?

This needs to go through the GPIO tree, but I guess GIT will survive if it ends up in two trees.

Nope, and it slipped through the cracks. More and more patches that we see lack proper acks, and it's becoming a problem. I have to go search for them on the lists and see if they came in without being tagged on the patch, etc.

Time to get more strict on that, obviously. :(

But yeah, one duplicate trivial patch like this shouldn't be an issue.

-Olof