Skip to contentSkip to conversation

ARM: dts: OMAP3: Updates for Overo

PATCH New Florian Vaussard 3 participants 8 messages Jun 11, 2013 – Jun 19, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

cover ARM: dts: OMAP3: Updates for Overo

Hello,

This series performs several updates to omap3-overo and omap3-tobi. Patch 1 is necessary to patch 2 for the IRQ constant. The SMSC911X is largely taken from omap3-igep.

Regards,

Florian

Florian Vaussard (4):
ARM: dts: OMAP3: Include IRQ header
ARM: dts: omap3-tobi: Add SMSC911X node
ARM: dts: omap3-tobi: Correct polarity for GPIO LED
ARM: dts: omap3-overo: Add default trigger for TWL4030 LED

 arch/arm/boot/dts/omap3-overo.dtsi |    1 +
 arch/arm/boot/dts/omap3-tobi.dts   |   50 +++++++++++++++++++++++++++++++++++-
 arch/arm/boot/dts/omap3.dtsi       |    1 +
 3 files changed, 51 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/4 ARM: dts: OMAP3: Include IRQ header

Some nodes in OMAP3 DTS now use edge or level sensitive interrupts.

---
 arch/arm/boot/dts/omap3.dtsi |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap3.dtsi +1 -0
index 6d05ee0..8e1a87f 100644
@@ -9,6 +9,7 @@
  */
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/pinctrl/omap.h>
 
 #include "skeleton.dtsi"
Signature · 1 line
1.7.5.4
#2 lore raw

PATCH 2/4 ARM: dts: omap3-tobi: Add SMSC911X node

In reply to Florian Vaussard

The Tobi expansion boards embeds a SMSC LAN8700 PHY. Add the corresponding node into the DT. The regulators are not designed to be turned off.

---
 arch/arm/boot/dts/omap3-tobi.dts |   48 ++++++++++++++++++++++++++++++++++++++
 1 files changed, 48 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap3-tobi.dts +48 -0
index c7eebbf..dea726f 100644
@@ -24,6 +24,54 @@
 			linux,default-trigger = "heartbeat";
 		};
 	};
+
+	vddvario: regulator-vddvario {
+		  compatible = "regulator-fixed";
+		  regulator-name = "vddvario";
+		  regulator-always-on;
+	};
+
+	vdd33a: regulator-vdd33a {
+		compatible = "regulator-fixed";
+		regulator-name = "vdd33a";
+		regulator-always-on;
+	};
+};
+
+&gpmc {
+	ranges = <5 0 0x2c000000 0x1000000>;	/* CS5 */
+
+	ethernet@5,0 {
+		compatible = "smsc,lan9221", "smsc,lan9115";
+		reg = <5 0 0xff>;
+		bank-width = <2>;
+
+		gpmc,mux-add-data;
+		gpmc,cs-on-ns = <0>;
+		gpmc,cs-rd-off-ns = <42>;
+		gpmc,cs-wr-off-ns = <36>;
+		gpmc,adv-on-ns = <6>;
+		gpmc,adv-rd-off-ns = <12>;
+		gpmc,adv-wr-off-ns = <12>;
+		gpmc,oe-on-ns = <0>;
+		gpmc,oe-off-ns = <42>;
+		gpmc,we-on-ns = <0>;
+		gpmc,we-off-ns = <36>;
+		gpmc,rd-cycle-ns = <60>;
+		gpmc,wr-cycle-ns = <54>;
+		gpmc,access-ns = <36>;
+		gpmc,page-burst-access-ns = <0>;
+		gpmc,bus-turnaround-ns = <0>;
+		gpmc,cycle2cycle-delay-ns = <0>;
+		gpmc,wr-data-mux-bus-ns = <18>;
+		gpmc,wr-access-ns = <42>;
+		gpmc,cycle2cycle-samecsen;
+		gpmc,cycle2cycle-diffcsen;
+
+		interrupt-parent = <&gpio6>;
+		interrupts = <16 IRQ_TYPE_LEVEL_LOW>;	/* GPIO 176*/
+		reg-io-width = <4>;
+	};
 };
 
 &i2c3 {
Signature · 1 line
1.7.5.4
#3 lore raw

PATCH 2/4 ARM: dts: omap3-tobi: Add SMSC911X node

Quoted 59 lines · Florian Vaussard

The Tobi expansion boards embeds a SMSC LAN8700 PHY. Add the corresponding node into the DT. The regulators are not designed to be turned off.

---
 arch/arm/boot/dts/omap3-tobi.dts |   48 ++++++++++++++++++++++++++++++++++++++
 1 files changed, 48 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap3-tobi.dts +41 -0
index c7eebbf..dea726f 100644
@@ -24,6 +24,54 @@
 			linux,default-trigger = "heartbeat";
 		};
 	};
+
+	vddvario: regulator-vddvario {
+		  compatible = "regulator-fixed";
+		  regulator-name = "vddvario";
+		  regulator-always-on;
+	};
+
+	vdd33a: regulator-vdd33a {
+		compatible = "regulator-fixed";
+		regulator-name = "vdd33a";
+		regulator-always-on;
+	};
+};
+
+&gpmc {
+	ranges = <5 0 0x2c000000 0x1000000>;	/* CS5 */
+
+	ethernet at 5,0 {
+		compatible = "smsc,lan9221", "smsc,lan9115";
+		reg = <5 0 0xff>;
+		bank-width = <2>;
+
+		gpmc,mux-add-data;
+		gpmc,cs-on-ns = <0>;
+		gpmc,cs-rd-off-ns = <42>;
+		gpmc,cs-wr-off-ns = <36>;
+		gpmc,adv-on-ns = <6>;
+		gpmc,adv-rd-off-ns = <12>;
+		gpmc,adv-wr-off-ns = <12>;
+		gpmc,oe-on-ns = <0>;
+		gpmc,oe-off-ns = <42>;
+		gpmc,we-on-ns = <0>;
+		gpmc,we-off-ns = <36>;
+		gpmc,rd-cycle-ns = <60>;
+		gpmc,wr-cycle-ns = <54>;
+		gpmc,access-ns = <36>;
+		gpmc,page-burst-access-ns = <0>;
+		gpmc,bus-turnaround-ns = <0>;
+		gpmc,cycle2cycle-delay-ns = <0>;
+		gpmc,wr-data-mux-bus-ns = <18>;
+		gpmc,wr-access-ns = <42>;

arch/arm/boot/dts/omap3-tobi.dts line 77

Quoted 10 lines
arch/arm/boot/dts/omap3-tobi.dts +7 -0
+		gpmc,cycle2cycle-samecsen;
+		gpmc,cycle2cycle-diffcsen;
+
+		interrupt-parent = <&gpio6>;
+		interrupts = <16 IRQ_TYPE_LEVEL_LOW>;	/* GPIO 176*/
+		reg-io-width = <4>;
+	};
 };
 
 &i2c3 {
#4 lore raw

PATCH 3/4 ARM: dts: omap3-tobi: Correct polarity for GPIO LED

In reply to Florian Vaussard

The LED is active low, not active high.

---
 arch/arm/boot/dts/omap3-tobi.dts |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/boot/dts/omap3-tobi.dts +1 -1
index dea726f..1458591 100644
@@ -20,7 +20,7 @@
 		compatible = "gpio-leds";
 		heartbeat {
 			label = "overo:red:gpio21";
-			gpios = <&gpio1 21 GPIO_ACTIVE_HIGH>;
+			gpios = <&gpio1 21 GPIO_ACTIVE_LOW>;
 			linux,default-trigger = "heartbeat";
 		};
 	};
Signature · 1 line
1.7.5.4
#5 lore raw

PATCH 4/4 ARM: dts: omap3-overo: Add default trigger for TWL4030 LED

In reply to Florian Vaussard

Commit c971ff1 'leds: leds-pwm: Defer led_pwm_set() if PWM can sleep' fixed a crash when using a trigger with a pwm-led provided by an external chip. Now it is safe to add the default trigger according to board-overo.c.

---
 arch/arm/boot/dts/omap3-overo.dtsi |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap3-overo.dtsi +1 -0
index e112a42..0bcc284 100644
@@ -21,6 +21,7 @@
 			label = "overo:blue:COM";
 			pwms = <&twl_pwmled 1 7812500>;
 			max-brightness = <127>;
+			linux,default-trigger = "mmc0";
 		};
 	};
 
Signature · 1 line
1.7.5.4
#6 lore raw

cover ARM: dts: OMAP3: Updates for Overo

In reply to Florian Vaussard

Hello Benoit,

Any comments on this series?

Regards,
Florian

Quoted 21 lines · Florian Vaussard

Hello,

This series performs several updates to omap3-overo and omap3-tobi. Patch 1 is necessary to patch 2 for the IRQ constant. The SMSC911X is largely taken from omap3-igep.

Regards,

Florian

Florian Vaussard (4):
ARM: dts: OMAP3: Include IRQ header
ARM: dts: omap3-tobi: Add SMSC911X node
ARM: dts: omap3-tobi: Correct polarity for GPIO LED
ARM: dts: omap3-overo: Add default trigger for TWL4030 LED

  arch/arm/boot/dts/omap3-overo.dtsi |    1 +
  arch/arm/boot/dts/omap3-tobi.dts   |   50 +++++++++++++++++++++++++++++++++++-
  arch/arm/boot/dts/omap3.dtsi       |    1 +
  3 files changed, 51 insertions(+), 1 deletions(-)
#7 lore raw

cover ARM: dts: OMAP3: Updates for Overo

Quoted 3 lines · Florian Vaussard

Hello Benoit,

Any comments on this series?

That series looks good to me. I've just applied it.

Thanks,
Benoit

Quoted 27 lines

Regards,
Florian

Quoted 22 lines · Florian Vaussard

Hello,

This series performs several updates to omap3-overo and omap3-tobi. Patch 1 is necessary to patch 2 for the IRQ constant. The SMSC911X is largely taken from omap3-igep.

Regards,

Florian

Florian Vaussard (4):
ARM: dts: OMAP3: Include IRQ header
ARM: dts: omap3-tobi: Add SMSC911X node
ARM: dts: omap3-tobi: Correct polarity for GPIO LED
ARM: dts: omap3-overo: Add default trigger for TWL4030 LED

  arch/arm/boot/dts/omap3-overo.dtsi |    1 +
  arch/arm/boot/dts/omap3-tobi.dts   |   50
+++++++++++++++++++++++++++++++++++-
  arch/arm/boot/dts/omap3.dtsi       |    1 +
  3 files changed, 51 insertions(+), 1 deletions(-)