Skip to contentSkip to conversation

nand onfi 8bit/16bit bus support

U-Boot Michal Simek 2 participants 6 messages May 6, 2013 – Jun 20, 2013

lore
Share & tools
lore
#0 lore raw

Hi guys,

Zynq supports 8 and 16bit ONFI nand flashes. We can count number of connected pins and from that we know if 8bit or 16bit nand flash is used.

I have looked at the code and contains ONFI detection with correct detection of bus width + checking later. Why also not setup proper chip->options for NAND_BUSWIDTH_16?

Not sure how others but if driver expect just ONFI devices and support 8 and 16bit options why not just to setup chip options based on information from ONFI or
not check that (busw != (chip->options & NAND_BUSWIDTH_16)) for onfi case.

Just wanted to get input from you before I will try to create patch to support this.
I just want to be sure that I am not doing something what it is wrong for other platforms.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130506/dc2e5acc/attachment.pgp>
#1 lore raw
Quoted 10 lines · Michal Simek

Hi guys,

Zynq supports 8 and 16bit ONFI nand flashes. We can count number of connected pins and from that we know if 8bit or 16bit nand flash is used.

I have looked at the code and contains ONFI detection with correct detection of bus width + checking later. Why also not setup proper chip->options for NAND_BUSWIDTH_16?

Quoted 5 lines

Not sure how others but if driver expect just ONFI devices and support 8 and 16bit options why not just to setup chip options based on information from ONFI or
not check that (busw != (chip->options & NAND_BUSWIDTH_16)) for onfi case.

This is fixed in current Linux, with NAND_BUSWIDTH_AUTO. There was a patchset to merge in recent Linux MTD code a while back, but an expected respin didn't come. I'll try to fix it up when I process this merge window's patches.

-Scott

#2 lore raw
Quoted 11 lines · Scott Wood
Quoted 10 lines · Michal Simek

Hi guys,

Zynq supports 8 and 16bit ONFI nand flashes. We can count number of connected pins and from that we know if 8bit or 16bit nand flash is used.

I have looked at the code and contains ONFI detection with correct detection of bus width + checking later. Why also not setup proper chip->options for NAND_BUSWIDTH_16?

Quoted 7 lines
Quoted 5 lines

Not sure how others but if driver expect just ONFI devices and support 8 and 16bit options why not just to setup chip options based on information from ONFI or
not check that (busw != (chip->options & NAND_BUSWIDTH_16)) for onfi case.

This is fixed in current Linux, with NAND_BUSWIDTH_AUTO.

There was a patchset to merge in recent Linux MTD code a while back,
but an expected respin didn't come. I'll try to fix it up when I process this merge window's patches.

Ok. Nice. That will be really helpful.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130510/9c91b244/attachment.pgp>
#3 lore raw
In reply to Scott Wood

Hi Scott,

Quoted 11 lines · Scott Wood
Quoted 10 lines · Michal Simek

Hi guys,

Zynq supports 8 and 16bit ONFI nand flashes. We can count number of connected pins and from that we know if 8bit or 16bit nand flash is used.

I have looked at the code and contains ONFI detection with correct detection of bus width + checking later. Why also not setup proper chip->options for NAND_BUSWIDTH_16?

Quoted 7 lines
Quoted 5 lines

Not sure how others but if driver expect just ONFI devices and support 8 and 16bit options why not just to setup chip options based on information from ONFI or
not check that (busw != (chip->options & NAND_BUSWIDTH_16)) for onfi case.

This is fixed in current Linux, with NAND_BUSWIDTH_AUTO. There was a patchset to merge in recent Linux MTD code a while back, but an expected respin didn't come. I'll try to fix it up when I process this merge window's patches.

Have you done this change?
I have grepped the latest version and I can't see it there.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130619/bff7c58d/attachment.pgp>
#4 lore raw
Quoted 20 lines · Michal Simek

Hi Scott,

Quoted 17 lines · Scott Wood
Quoted 15 lines · Michal Simek

Hi guys,

Zynq supports 8 and 16bit ONFI nand flashes. We can count number of connected pins and from that we know if 8bit or 16bit nand flash is used.

I have looked at the code and contains ONFI detection with correct detection of bus width + checking later. Why also not setup proper chip->options for NAND_BUSWIDTH_16?

Not sure how others but if driver expect just ONFI devices and support 8 and 16bit options why not just to setup chip options based on information from ONFI or
not check that (busw != (chip->options & NAND_BUSWIDTH_16)) for onfi case.

Quoted 7 lines
Quoted 1 line

This is fixed in current Linux, with NAND_BUSWIDTH_AUTO. There was

a patchset to merge in recent Linux MTD code a while back, but an expected respin didn't come. I'll try to fix it up when I process this merge window's patches.

Have you done this change?
I have grepped the latest version and I can't see it there.

MTD from 3.7.1 (which was what was current when the patch was posted months ago) was merged in. It looks like NAND_BUSWIDTH_AUTO was added in 3.8. We can do another MTD update in the next merge window, which would pick this up. Or if you'd like to submit a patch that just fixes this problem (in the same way as in Linux, so it doesn't conflict too badly when we do the merge), it could be applied now as a bugfix.

-Scott

#5 lore raw
Quoted 23 lines · Scott Wood
Quoted 22 lines · Michal Simek

Hi Scott,

Quoted 18 lines · Scott Wood
Quoted 10 lines · Michal Simek

Hi guys,

Zynq supports 8 and 16bit ONFI nand flashes. We can count number of connected pins and from that we know if 8bit or 16bit nand flash is used.

I have looked at the code and contains ONFI detection with correct detection of bus width + checking later. Why also not setup proper chip->options for NAND_BUSWIDTH_16?

Quoted 5 lines

Not sure how others but if driver expect just ONFI devices and support 8 and 16bit options why not just to setup chip options based on information from ONFI or
not check that (busw != (chip->options & NAND_BUSWIDTH_16)) for onfi case.

This is fixed in current Linux, with NAND_BUSWIDTH_AUTO. There was a patchset to merge in recent Linux MTD code a while back, but an expected respin didn't come. I'll try to fix it up when I process this merge window's patches.

Quoted 7 lines
Quoted 2 lines

Have you done this change?
I have grepped the latest version and I can't see it there.

MTD from 3.7.1 (which was what was current when the patch was posted months ago) was merged in.
It looks like NAND_BUSWIDTH_AUTO was added in 3.8. We can do another MTD update in the next merge window, which would pick this up. Or if you'd like to submit a patch that just fixes this problem
(in the same way as in Linux, so it doesn't conflict too badly when we do the merge), it could be applied now as a bugfix.

Ah ok. From my point of view it is not bug fix but new features and should go to the u-boot in proper merge window.
No problem to wait just wanted to get update on this to be able to better plan our work.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130620/228b9908/attachment.pgp>