Skip to contentSkip to conversation

Section mismatch in drivers/usb/gadget/fotg210-udc.c

DISCUSSION Paul Gortmaker 4 participants 5 messages Jun 19, 2013 – Jul 3, 2013 3 messages not in the archive Linux-next tree

lore
Share & tools
lore

Paul Gortmaker

author
#0 lore raw

Hi guys,

This was seen on a linux-next (Jun18th tree) allmodconfig build:

WARNING: drivers/usb/gadget/fotg210-udc.o(.data+0x0): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe() The variable fotg210_driver references
the function __init fotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Paul.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Re: [PATCH] usb: gadget: fotg210-udc: Use module_platform_driver_probe macro

Hi,

Quoted 5 lines · Yuan-Hsin Chen

Because fotg210-udc is configured as a non-hotpluggable device, that makes sense to use module_platform_driver_probe() instead of module_platform_driver(). This also fixes the section mismatch issue.

Signed-off-by Yuan-Hsin Chen <[email protected]>

I would rather see you remove __init annotation from your probe() function. The reason being that it will users to bind/unbind the driver through sysfs, which is pretty good for testing, at least.

Signature · 1 line
balbi

A message that is not in the archive (sent off-list or not yet received): 20130620121610.GE9817-S8G//mZuvNWo5Im9Ml3/[email protected]

#4 lore raw

Re: [PATCH] usb: gadget: fotg210-udc: Use module_platform_driver_probe macro

Hi,

Quoted 8 lines · Felipe Balbi

Hi,

Quoted 4 lines · Yuan-Hsin Chen

Because fotg210-udc is configured as a non-hotpluggable device, that makes sense to use module_platform_driver_probe() instead of module_platform_driver(). This also fixes the section mismatch issue.

Quoted 5 lines
Quoted 1 line
Signed-off-by Yuan-Hsin Chen <[email protected]>

I would rather see you remove __init annotation from your probe() function. The reason being that it will users to bind/unbind the driver through sysfs, which is pretty good for testing, at least.

I see and will send a patch later. Thanks.

Yuan-Hsin

Quoted 4 lines

--
balbi

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#5 lore raw
In reply to Paul Gortmaker
Quoted 10 lines · Paul Gortmaker

Hi guys,

This was seen on a linux-next (Jun18th tree) allmodconfig build:

WARNING: drivers/usb/gadget/fotg210-udc.o(.data+0x0): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe() The variable fotg210_driver references
the function __init fotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Hi,

Wondering if this fell through the cracks? I recall the fix being discussed,
but yet I'm still seeing the problem when I build today's linux-next, and the merge window has already opened on Monday.

Paul.
--

Quoted 6 lines

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAP=VYLpsF7bmF2HZ84_WV0YtbGqHoPDMaE=a9p9UhovHeckkRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#7 lore raw
Quoted 13 lines · Paul Gortmaker
Quoted 10 lines · Paul Gortmaker

Hi guys,

This was seen on a linux-next (Jun18th tree) allmodconfig build:

WARNING: drivers/usb/gadget/fotg210-udc.o(.data+0x0): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe() The variable fotg210_driver references
the function __init fotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Quoted 5 lines

Hi,

Wondering if this fell through the cracks? I recall the fix being discussed,
but yet I'm still seeing the problem when I build today's linux-next, and the merge window has already opened on Monday.

I guess Yuan-Hsin isn't even able to see these mails; I'm getting a rather odd bounce message:

-----------------
Technical details of permanent failure:
Google tried to deliver your message, but it was rejected by the server for the recipient domain faraday-tech.com by mailhost1.faraday-tech.com. [210.59.249.140].

The error that the other server returned was:
553 5.1.3 <[email protected]>... Check FTC account failure!
-----------------

I've no idea what that means, other than the fix will probably have to come from someone other than Yuan-Hsin...

Paul.
--

Quoted 11 lines

Paul.
--

Quoted 6 lines

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html