ARM: dts: AM33XX: Add support for IGEP AQUILA EXPANSION board.

PATCH Javier Martinez Canillas 2 participants 2 messages Jun 22, 2013 – Jun 24, 2013

lore

Share & tools

lore

Javier Martinez Canillas

author Reviewed-by

2013-06-22 14:48 UTC #0 lore raw

Review

Quoted 33 lines · Enric Balletbo i Serra

The IGEP AQUILA EXPANSION board is a development platform for the IGEP COM AQUILA AM335x boards.
The board adds the following connectivity:
o USB OTG
o USB HOST
o HDMI
o Ethernet
o Serial Debug (3.3V)
o 2x46 pin headers
o EEPROM
Signed-off-by Enric Balletbo i Serra <[email protected]>
---
 arch/arm/boot/dts/Makefile            |  1 +
 arch/arm/boot/dts/am335x-base0033.dts | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)
 create mode 100644 arch/arm/boot/dts/am335x-base0033.dts
arch/arm/boot/dts/Makefile +1 -0
index 8e50761..cb675d2 100644
@@ -154,6 +154,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
        am335x-evm.dtb \
        am335x-evmsk.dtb \
        am335x-bone.dtb \
+       am335x-base0033.dtb \
        am3517-evm.dtb \
        am3517_mt_ventoux.dtb
 dtb-$(CONFIG_ARCH_ORION5X) += orion5x-lacie-ethernet-disk-mini-v2.dtb
(quoted diff) +0 -0

b/arch/arm/boot/dts/am335x-base0033.dts

Quoted 22 lines

new file mode 100644
index 0000000..d6bb791

arch/arm/boot/dts/am335x-base0033.dts new file +16 -1

@@ -0,0 +1,16 @@
+/*
+ * am335x-base0033.dtsi - Device Tree file for IGEP AQUILA EXPANSION
+ *
+ * Copyright (C) 2013 ISEE 2007 SL - http://www.isee.biz
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "am335x-igep0033.dtsi"
+
+/ {
+       model = "IGEP COM AM335x on AQUILA Expansion";
+       compatible = "ti,am335x-base0033", "ti,am335x-igep0033", "ti,am33xx";
+};
--

Quoted 2 lines

1.8.1.2

Hi Enric

Just small comment. I think it's better to make it compatible with "isee,am335x-base0033", "isee,am335x-igep0033", "ti,am33xx" since these boards are manufactured by ISEE and not by Texas Instrument.

I see that other boards such as the omap3-tobi.dts use the same convention that you are using here and make it compatible with "ti,omap3-tobi", "ti,omap3-overo", "ti,omap3" instead of something like "gumstix,omap3-tobi", "gumstix,omap3-overo", "ti,omap3" that I think it would be better.

But maybe I'm just wrong and misunderstanding the convention on how to define the compatible string for boards.

Anyway, the patch looks good to me now:

Reviewed-by Javier Martinez Canillas <[email protected]>

Florian Vaussard

2013-06-24 08:58 UTC #1 lore raw

Hello Javier,

Quoted 63 lines · Javier Martinez Canillas

Review
Quoted 33 lines · Enric Balletbo i Serra
The IGEP AQUILA EXPANSION board is a development platform for the IGEP COM AQUILA AM335x boards.
The board adds the following connectivity:
o USB OTG
o USB HOST
o HDMI
o Ethernet
o Serial Debug (3.3V)
o 2x46 pin headers
o EEPROM
Signed-off-by Enric Balletbo i Serra <[email protected]>
---
  arch/arm/boot/dts/Makefile            |  1 +
  arch/arm/boot/dts/am335x-base0033.dts | 16 ++++++++++++++++
  2 files changed, 17 insertions(+)
create mode 100644 arch/arm/boot/dts/am335x-base0033.dts
arch/arm/boot/dts/Makefile +1 -0
index 8e50761..cb675d2 100644
@@ -154,6 +154,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
         am335x-evm.dtb \
         am335x-evmsk.dtb \
         am335x-bone.dtb \
+       am335x-base0033.dtb \
         am3517-evm.dtb \
         am3517_mt_ventoux.dtb
  dtb-$(CONFIG_ARCH_ORION5X) += orion5x-lacie-ethernet-disk-mini-v2.dtb
(quoted diff) +0 -0
b/arch/arm/boot/dts/am335x-base0033.dts
Quoted 22 lines
new file mode 100644
index 0000000..d6bb791
arch/arm/boot/dts/am335x-base0033.dts new file +16 -1
@@ -0,0 +1,16 @@
+/*
+ * am335x-base0033.dtsi - Device Tree file for IGEP AQUILA EXPANSION
+ *
+ * Copyright (C) 2013 ISEE 2007 SL - http://www.isee.biz
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "am335x-igep0033.dtsi"
+
+/ {
+       model = "IGEP COM AM335x on AQUILA Expansion";
+       compatible = "ti,am335x-base0033", "ti,am335x-igep0033", "ti,am33xx";
+};
--
Quoted 2 lines
1.8.1.2
Hi Enric

Quoted 9 lines

Just small comment. I think it's better to make it compatible with "isee,am335x-base0033", "isee,am335x-igep0033", "ti,am33xx" since these boards are manufactured by ISEE and not by Texas Instrument.
I see that other boards such as the omap3-tobi.dts use the same convention that you are using here and make it compatible with "ti,omap3-tobi", "ti,omap3-overo", "ti,omap3" instead of something like "gumstix,omap3-tobi", "gumstix,omap3-overo", "ti,omap3" that I think it would be better.

Your approach makes sense to me, as the board manufacturer is the one of importance here.

I rapidly looked at the OF norm (IEEE 1275), all I could find is that "compatible" should follow the same convention that the "name" property:

"For plug-in devices, the value string shall begin with a company name string in one of the following forms, followed by a comma (',')."

As for the form of the company name, it can be:

- an Organizationally Unique Identifier (OUI) assigned by IEEE
- "one to five uppercase letters representing the stock symbol of the company on any stock exchange"
- any other string, as long as it cannot be confused with one of the two above- mentioned form

Quoted 3 lines

But maybe I'm just wrong and misunderstanding the convention on how to define the compatible string for boards.

I do not know either, but I agree with you.

Regards,
Florian