Skip to contentSkip to conversation

SLIP: Is there a maintainer for drivers/net/slip/slip.c ?

DISCUSSION Dean Jenkins 3 participants 4 messages Jun 24, 2013

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Dean Jenkins

author
#0 lore raw

Hi,

Using the Linux v3.9 tag, I note that

./scripts/get_maintainer.pl -f drivers/net/slip/slip.c [email protected] (open list:NETWORKING DRIVERS) [email protected] (open list)

There seems to be no maintainer for drivers/net/slip/slip.c, is that true ?

I am asking because sl_encaps() and slip_write_wakeup() do not handle error codes from tty->ops->write() and a recursive stack overflow crash can occur if the tty->ops->write() fails to write all the characters. I have some patches to fix this but would like some feedback on an appropriate solution.

Thanks,

Dean Jenkins
Mentor Graphics

#1 lore raw
Quoted 7 lines · Dean Jenkins

Using the Linux v3.9 tag, I note that

./scripts/get_maintainer.pl -f drivers/net/slip/slip.c [email protected] (open list:NETWORKING DRIVERS) [email protected] (open list)

There seems to be no maintainer for drivers/net/slip/slip.c, is that true ?

netdev seems to be the most appropriate mailing list, cfr. what get_maintainer.pl reported, hence CC netdev added.

Quoted 4 lines

I am asking because sl_encaps() and slip_write_wakeup() do not handle error codes from tty->ops->write() and a recursive stack overflow crash can occur if the tty->ops->write() fails to write all the characters. I have some patches to fix this but would like some feedback on an appropriate solution.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
In reply to Dean Jenkins
Quoted 11 lines · Dean Jenkins

Hi,

Using the Linux v3.9 tag, I note that

./scripts/get_maintainer.pl -f drivers/net/slip/slip.c [email protected] (open list:NETWORKING DRIVERS) [email protected] (open list)

There seems to be no maintainer for drivers/net/slip/slip.c, is that true ?

I am asking because sl_encaps() and slip_write_wakeup() do not handle error codes from tty->ops->write() and a recursive stack overflow crash can occur if the tty->ops->write() fails to write all the characters. I have some patches to fix this but would like some feedback on an appropriate solution.

SLIP changes would likely go through David Miller <[email protected]>. TTY changes would go through Greg Kroah-Hartman <[email protected]>

Regards,
Peter Hurley

author
#3 lore raw

Hi Peter,

Quoted 9 lines · Peter Hurley
Quoted 8 lines · Dean Jenkins

Hi,

Using the Linux v3.9 tag, I note that

./scripts/get_maintainer.pl -f drivers/net/slip/slip.c [email protected] (open list:NETWORKING DRIVERS) [email protected] (open list)

Quoted 6 lines
Quoted 3 lines

There seems to be no maintainer for drivers/net/slip/slip.c, is that true ?

I am asking because sl_encaps() and slip_write_wakeup() do not handle error codes from tty->ops->write() and a recursive stack overflow crash can occur if the tty->ops->write() fails to write all the characters. I have some patches to fix this but would like some feedback on an appropriate solution.

SLIP changes would likely go through David Miller <[email protected]>. TTY changes would go through Greg Kroah-Hartman <[email protected]>

I have already sent an E-mail to David Miller and the netdev mailing list but so far got not reply from David.

So I guess I have sent my patches to the correct place ;)

Thanks,

Regards,
Dean Jenkins
Mentor Graphics