ARM: smp_twd: twd_update_frequency need be run on all online CPUs
PATCH 1/1 ARM: smp_twd: twd_update_frequency need be run on all online CPUs
When the local timer freq changed, the twd_update_frequency function should be run all the CPUs include itself, otherwise, the twd freq will not get updated and the local timer will not run correcttly.
smp_call_function will run functions on all other CPUs, but not include himself, this is not correct,use on_each_cpu instead to fix this issue.
--- arch/arm/kernel/smp_twd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/kernel/smp_twd.c +1 -1
@@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block *nb,* changing cpu. */ if (flags ==POST_RATE_CHANGE ) -smp_call_function (twd_update_frequency, +on_each_cpu (twd_update_frequency, (void *)&cnd->new_rate,1 );return NOTIFY_OK ;
Signature · 1 line
1.7.10.4
PATCH 1/1 ARM: smp_twd: twd_update_frequency need be run on all online CPUs
Quoted 7 lines · Jason Liu
When the local timer freq changed, the
twd_update_frequencyfunction should be run all the CPUs include itself, otherwise, the twd freq will not get updated and the local timer will not run correcttly.
smp_call_functionwill run functions on all other CPUs, but not include himself, this is not correct,useon_each_cpuinstead to fix this issue.
Quoted 7 lines
Signed-off-by Jason Liu <[email protected]>Cc Russell King <[email protected]>Cc Linus Walleij <[email protected]>Cc Rob Herring <[email protected]>Cc Shawn Guo <[email protected]>Cc Arnd Bergmann <[email protected]>Cc stable at vger.kernel.org
Mike Turquette wrote this code, so let him look at it.
But it makes sense to me:
Please mark this for stable and put it into Russell's patch tracker after allowing some time for others to have a look.
Yours,
Linus Walleij
PATCH 1/1 ARM: smp_twd: twd_update_frequency need be run on all online CPUs
Quoted 26 lines
-----Original Message-----
From: Linus Walleij [mailto:linus.walleij at linaro.org]
Sent: Thursday, June 13, 2013 4:00 PM
To: Liu Hui-R64343; Mike Turquette
Cc: linux-arm-kernel at lists.infradead.org; Russell King - ARM Linux
Subject: Re: [PATCH] ARM:smp_twd:twd_update_frequencyneed be run on all online CPUsQuoted 6 lines · Jason Liu
When the local timer freq changed, the
twd_update_frequencyfunction should be run all the CPUs include itself, otherwise, the twd freq will not get updated and the local timer will not run correcttly.
smp_call_functionwill run functions on all other CPUs, but not include himself, this is not correct,useon_each_cpuinstead to fixthis issue.
Quoted 8 lines
Signed-off-by Jason Liu <[email protected]>Cc Russell King <[email protected]>Cc Linus Walleij <[email protected]>Cc Rob Herring <[email protected]>Cc Shawn Guo <[email protected]>Cc Arnd Bergmann <[email protected]>Cc stable at vger.kernel.org
Quoted 1 line
Mike Turquette wrote this code, so let him look at it.
Mike, could you please look at it?
Quoted 3 lines
But it makes sense to me:
Acked-by Linus Walleij <[email protected]>
Thanks Linus W.
Quoted 3 lines
Please mark this for stable and put it into Russell's patch tracker after allowing some time for others to have a look.
Sure, Will do it after others look at it.
Quoted 3 lines
Yours,
Linus Walleij
PATCH 1/1 ARM: smp_twd: twd_update_frequency need be run on all online CPUs
In reply to Jason LiuQuoted 4 lines · Jason Liu
When the local timer freq changed, the
twd_update_frequencyfunction should be run all the CPUs include itself, otherwise, the twd freq will not get updated and the local timer will not run correcttly.
Quoted 8 lines
smp_call_functionwill run functions on all other CPUs, but not include himself, this is not correct,useon_each_cpuinstead to fix this issue.Signed-off-by Jason Liu <[email protected]>Cc Russell King <[email protected]>Cc Linus Walleij <[email protected]>Cc Rob Herring <[email protected]>Cc Shawn Guo <[email protected]>
BTW, is there anything wrong with your mailer (git send-email command line)? I do not see people you put on Cc tag here show up in Cc of the email. And that might the be reason why people are not responding so far.
Shawn
Quoted 28 lines
Cc Arnd Bergmann <[email protected]>Cc stable at vger.kernel.org--- arch/arm/kernel/smp_twd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/kernel/smp_twd.c +1
-1@@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block *nb,* changing cpu. */ if (flags ==POST_RATE_CHANGE ) -smp_call_function (twd_update_frequency, +on_each_cpu (twd_update_frequency, (void *)&cnd->new_rate,1 );return NOTIFY_OK ;Signature · 8 lines
1.7.10.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 ARM: smp_twd: twd_update_frequency need be run on all online CPUs
Quoted 17 lines
-----Original Message-----
From: Shawn Guo [mailto:shawn.guo at linaro.org]
Sent: Monday, June 17, 2013 3:31 PM
To: Liu Hui-R64343
Cc: linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH] ARM:smp_twd:twd_update_frequencyneed be run on all online CPUsQuoted 6 lines · Jason Liu
When the local timer freq changed, the
twd_update_frequencyfunction should be run all the CPUs include itself, otherwise, the twd freq will not get updated and the local timer will not run correcttly.
smp_call_functionwill run functions on all other CPUs, but not include himself, this is not correct,useon_each_cpuinstead to fixthis issue.
Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Signed-off-by Jason Liu <[email protected]>Cc Russell King <[email protected]>Cc Linus Walleij <[email protected]>Cc Rob Herring <[email protected]>Cc Shawn Guo <[email protected]>Acked-by Shawn Guo <[email protected]>
Thanks Shawn.
Quoted 5 lines
BTW, is there anything wrong with your mailer (git send-email command line)? I do not see people you put on Cc tag here show up in Cc of the email. And that might the be reason why people are not responding so far.
Yes, there is one issue in my script and get fixed. I will put the patch Into Russell's patch tracking system after Mike and Russell reviewed it And also Cc stable kernel as Linus W. said.
Quoted 32 lines
Shawn
arch/arm/kernel/smp_twd.c static int twd_rate_change(struct notifier_block
Quoted 11 lines
Cc Arnd Bergmann <[email protected]>Cc stable at vger.kernel.org--- arch/arm/kernel/smp_twd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/kernel/smp_twd.c +0
-0@@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block*nb,
Quoted 17 lines
arch/arm/kernel/smp_twd.c +1
-2* changing cpu. */ if (flags ==POST_RATE_CHANGE ) -smp_call_function (twd_update_frequency, +on_each_cpu (twd_update_frequency, (void *)&cnd->new_rate,1 );return NOTIFY_OK ; --1.7.10.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 ARM: smp_twd: twd_update_frequency need be run on all online CPUs
Quoted 28 lines · On 17.06.2013 10:11, Liu Hui-R64343 wrote:
Quoted 17 lines
-----Original Message-----
From: Shawn Guo [mailto:shawn.guo at linaro.org]
Sent: Monday, June 17, 2013 3:31 PM
To: Liu Hui-R64343
Cc: linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH] ARM:smp_twd:twd_update_frequencyneed be run on all online CPUsQuoted 6 lines · Jason Liu
When the local timer freq changed, the
twd_update_frequencyfunction should be run all the CPUs include itself, otherwise, the twd freq will not get updated and the local timer will not run correcttly.
smp_call_functionwill run functions on all other CPUs, but not include himself, this is not correct,useon_each_cpuinstead to fixthis issue.
Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Signed-off-by Jason Liu <[email protected]>Cc Russell King <[email protected]>Cc Linus Walleij <[email protected]>Cc Rob Herring <[email protected]>Cc Shawn Guo <[email protected]>Acked-by Shawn Guo <[email protected]>Thanks Shawn.
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
BTW, is there anything wrong with your mailer (git send-email command line)? I do not see people you put on Cc tag here show up in Cc of the email. And that might the be reason why people are not responding so far.
Yes, there is one issue in my script and get fixed. I will put the patch Into Russell's patch tracking system after Mike and Russell reviewed it And also Cc stable kernel as Linus W. said.
Any news on this?
Thanks
Dirk
Quoted 24 lines
Quoted 24 lines
Shawn
arch/arm/kernel/smp_twd.c static int twd_rate_change(struct notifier_block
Quoted 11 lines
Cc Arnd Bergmann <[email protected]>Cc stable at vger.kernel.org--- arch/arm/kernel/smp_twd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/kernel/smp_twd.c +0
-0@@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block*nb,
Quoted 10 lines
arch/arm/kernel/smp_twd.c +1
-2* changing cpu. */ if (flags ==POST_RATE_CHANGE ) -smp_call_function (twd_update_frequency, +on_each_cpu (twd_update_frequency, (void *)&cnd->new_rate,1 );return NOTIFY_OK ; --1.7.10.4
PATCH 1/1 ARM: smp_twd: twd_update_frequency need be run on all online CPUs
Quoted 43 lines
-----Original Message-----
From: Dirk Behme [mailto:dirk.behme at de.bosch.com]
Sent: Wednesday, June 26, 2013 8:29 PM
To: Liu Hui-R64343; Mike Turquette
Cc: Shawn Guo; Linus Walleij; rob.herring at calxeda.com; Russell King - ARM Linux; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH] ARM:smp_twd:twd_update_frequencyneed be run on all online CPUsQuoted 33 lines · On 17.06.2013 10:11, Liu Hui-R64343 wrote:
Quoted 17 lines
-----Original Message-----
From: Shawn Guo [mailto:shawn.guo at linaro.org]
Sent: Monday, June 17, 2013 3:31 PM
To: Liu Hui-R64343
Cc: linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH] ARM:smp_twd:twd_update_frequencyneed be run on all online CPUsQuoted 6 lines · Jason Liu
When the local timer freq changed, the
twd_update_frequencyfunction should be run all the CPUs include itself, otherwise, the twd freq will not get updated and the local timer will not run correcttly.
smp_call_functionwill run functions on all other CPUs, but not include himself, this is not correct,useon_each_cpuinstead to fixthis issue.
Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Signed-off-by Jason Liu <[email protected]>Cc Russell King <[email protected]>Cc Linus Walleij <[email protected]>Cc Rob Herring <[email protected]>Cc Shawn Guo <[email protected]>Acked-by Shawn Guo <[email protected]>Thanks Shawn.
Quoted 5 lines
BTW, is there anything wrong with your mailer (git send-email command line)? I do not see people you put on Cc tag here show up in Cc of the email. And that might the be reason why people are not responding so far.
Quoted 5 lines
Quoted 3 lines
Yes, there is one issue in my script and get fixed. I will put the patch Into Russell's patch tracking system after Mike and Russell reviewed it And also Cc stable kernel as Linus W. said.
Any news on this?
I have put the patch into Russell's patch tracking system.
Quoted 3 lines
Thanks