include/asm-generic/pci.h: include generic "pci-dma-compat.h"

PATCH In review Chen Gang 2 participants 3 messages Jun 27, 2013

Subsystems (2)

PCI Generic include/asm header files

lore

Share & tools

lore

Chen Gang

author

2013-06-27 04:03 UTC #0 lore raw

PATCH 1/1 include/asm-generic/pci.h: include generic "pci-dma-compat.h"

If an architecture need "generic pci.h", it also need generic "pci-dma- compat.h", so recommend to include it in asm-generic directly.

And now, for arm64 and m32r, may cause compiling error about it.

The related error (with allmodconfig):

drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors

Signed-off-by Chen Gang <[email protected]>

---
 include/asm-generic/pci.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

include/asm-generic/pci.h +2 -0

index e80a049..64e2a15 100644
@@ -6,6 +6,8 @@
 #ifndef _ASM_GENERIC_PCI_H
 #define _ASM_GENERIC_PCI_H
 
+#include <asm-generic/pci-dma-compat.h>
+
 static inline struct resource *
 pcibios_select_root(struct pci_dev *pdev, struct resource *res)
 {

Signature · 1 line

1.7.7.6

Catalin Marinas

Acked-by on v1 1/1

2013-06-27 08:29 UTC #1 lore raw

Quoted 15 lines · Chen Gang

If an architecture need "generic pci.h", it also need generic "pci-dma- compat.h", so recommend to include it in asm-generic directly.
And now, for arm64 and m32r, may cause compiling error about it.
The related error (with allmodconfig):
drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors

Quoted 3 lines

Signed-off-by Chen Gang <[email protected]>
From the arm64 perspective:

Acked-by Catalin Marinas <[email protected]>

(but make sure it doesn't break other archs)

Chen Gang

author

2013-06-27 10:14 UTC #2 lore raw

Quoted 16 lines · Catalin Marinas

Quoted 15 lines · Chen Gang
Quoted 15 lines
If an architecture need "generic pci.h", it also need generic "pci-dma- compat.h", so recommend to include it in asm-generic directly.
And now, for arm64 and m32r, may cause compiling error about it.
The related error (with allmodconfig):
drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors

Quoted 5 lines

Quoted 1 line
Quoted 1 line
Signed-off-by Chen Gang <[email protected]>
From the arm64 perspective:
Acked-by Catalin Marinas <[email protected]>

Thanks.

Quoted 1 line

(but make sure it doesn't break other archs)

I will try to check all related archs with allmodconfig (which can also find more another patches, and can let me familiar the compiler step by step). ;-)

Thanks.

Signature · 1 line

Chen Gang