arch: arm64: include: asm: add pci.h to pass compiling

Need add pci.h for compiling, the related error (with allmodconfig):

drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors

Signed-off-by Chen Gang <[email protected]>

---
 arch/arm64/include/asm/pci.h |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm64/include/asm/pci.h

arch/arm64/include/asm/pci.h new file +1 -0

new file mode 100644
index 0000000..2ed467f
@@ -0,0 +1,11 @@
+#ifndef ASMARM64_PCI_H

Quoted 27 lines · Chen Gang

Quoted 27 lines

Need add pci.h for compiling, the related error (with allmodconfig):

drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors

Signed-off-by Chen Gang <[email protected]>

---
 arch/arm64/include/asm/pci.h |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm64/include/asm/pci.h

arch/arm64/include/asm/pci.h new file +6 -0

new file mode 100644
index 0000000..2ed467f
@@ -0,0 +1,11 @@
+#ifndef ASMARM64_PCI_H
+#define ASMARM64_PCI_H
+
+#ifdef __KERNEL__
+
+#include <asm-generic/pci-dma-compat.h>

Quoted 5 lines

arch/arm64/include/asm/pci.h line 11

Quoted 5 lines

arch/arm64/include/asm/pci.h new file +5 -0

+#include <asm-generic/pci.h>
+
+#endif /* __KERNEL__ */
+
+#endif

I wonder whether it makes sense to include pci-dma-compat.h in asm-generic/pci.h, I don't see why one would want the generic pci.h but not the generic pci-dma-compat.h (cc'ing Arnd).

Quoted 28 lines · Catalin Marinas

Quoted 27 lines · Chen Gang

Quoted 27 lines

Need add pci.h for compiling, the related error (with allmodconfig):

drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors

Signed-off-by Chen Gang <[email protected]>

---
 arch/arm64/include/asm/pci.h |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm64/include/asm/pci.h

arch/arm64/include/asm/pci.h new file +6 -0

new file mode 100644
index 0000000..2ed467f
@@ -0,0 +1,11 @@
+#ifndef ASMARM64_PCI_H
+#define ASMARM64_PCI_H
+
+#ifdef __KERNEL__
+
+#include <asm-generic/pci-dma-compat.h>

Quoted 8 lines

Quoted 5 lines

arch/arm64/include/asm/pci.h line 11

Quoted 5 lines

arch/arm64/include/asm/pci.h new file +5 -0

+#include <asm-generic/pci.h>
+
+#endif /* __KERNEL__ */
+
+#endif

I wonder whether it makes sense to include pci-dma-compat.h in asm-generic/pci.h, I don't see why one would want the generic pci.h but not the generic pci-dma-compat.h (cc'ing Arnd).

I think, it will let architecture guys easier to add their own pci-dma-compat.h (although they still need generic pci_dma_compat.h, and generic pci.h, too).

e.g. one architecture want include generic pci-dma-compat.h firstly, then define its own features in its own pci-dma-compat.h.

Thanks.

Quoted 30 lines · Chen Gang

Quoted 29 lines · Catalin Marinas

Quoted 28 lines · Chen Gang

Quoted 28 lines

Need add pci.h for compiling, the related error (with allmodconfig):

drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration] drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors

Signed-off-by Chen Gang <[email protected]>

---
 arch/arm64/include/asm/pci.h |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm64/include/asm/pci.h

arch/arm64/include/asm/pci.h new file +7 -0

new file mode 100644
index 0000000..2ed467f
@@ -0,0 +1,11 @@
+#ifndef ASMARM64_PCI_H
+#define ASMARM64_PCI_H
+
+#ifdef __KERNEL__
+
+#include <asm-generic/pci-dma-compat.h>
+#include <asm-generic/pci.h>

Quoted 8 lines

Quoted 7 lines

Quoted 4 lines

arch/arm64/include/asm/pci.h line 11

Quoted 4 lines

arch/arm64/include/asm/pci.h new file +4 -0

+
+#endif /* __KERNEL__ */
+
+#endif

I wonder whether it makes sense to include pci-dma-compat.h in asm-generic/pci.h, I don't see why one would want the generic pci.h but not the generic pci-dma-compat.h (cc'ing Arnd).

For m32r, it needs generic pci.h but not the generic pci-dma-compat.h.

I am just compiling it with allmodconfig to see whether it will can cause issue too, if so I will send the patch for asm-generic. :-)

And, sorry for the original reply below is incorrect.

Quoted 9 lines

I think, it will let architecture guys easier to add their own pci-dma-compat.h (although they still need generic pci_dma_compat.h, and generic pci.h, too).

e.g. one architecture want include generic pci-dma-compat.h firstly, then define its own features in its own pci-dma-compat.h.

Thanks.

Quoted 4 lines · Catalin Marinas

On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
I wonder whether it makes sense to include pci-dma-compat.h in asm-generic/pci.h, I don't see why one would want the generic pci.h but not the generic pci-dma-compat.h (cc'ing Arnd).

I think, it will let architecture guys easier to add their own pci-dma-compat.h (although they still need generic pci_dma_compat.h, and generic pci.h, too).

e.g. one architecture want include generic pci-dma-compat.h firstly, then define its own features in its own pci-dma-compat.h.

Quoted 10 lines · On Thursday 27 June 2013 08:30:40 Chen Gang wrote:

Quoted 10 lines · Catalin Marinas

Quoted 4 lines

Quoted 4 lines · Chen Gang

I wonder whether it makes sense to include pci-dma-compat.h in asm-generic/pci.h, I don't see why one would want the generic pci.h but not the generic pci-dma-compat.h (cc'ing Arnd).

I think, it will let architecture guys easier to add their own pci-dma-compat.h (although they still need generic pci_dma_compat.h, and generic pci.h, too).

Quoted 2 lines

Quoted 2 lines

e.g. one architecture want include generic pci-dma-compat.h firstly, then define its own features in its own pci-dma-compat.h.

I think there is no excuse for still keeping the asm-generic/pci-dma-compat.h header around any more.

All architectures use the same implementation and have done so for years. We should just convert the remaining users to use the dma_mapping.h interfaces directly.