Skip to contentSkip to conversation

include/asm-generic/iomap.h: trivial: use '__GENERIC_IOMAP_H' instead of '__GENERIC_IO_H'

PATCH Superseded Chen Gang 2 participants 4 messages Jun 28, 2013 – Jul 5, 2013 Generic include/asm header files

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 include/asm-generic/iomap.h: trivial: use '__GENERIC_IOMAP_H' instead of '__GENERIC_IO_H'

Recommend to let the header file macro mark match the file name.

---
 include/asm-generic/iomap.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/asm-generic/iomap.h +3 -3
index 6afd7d6..236c78c 100644
@@ -1,5 +1,5 @@
-#ifndef __GENERIC_IO_H
-#define __GENERIC_IO_H
+#ifndef __GENERIC_IOMAP_H
+#define __GENERIC_IOMAP_H
 
 #include <linux/linkage.h>
 #include <asm/byteorder.h>
@@ -78,4 +78,4 @@ static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
 
 #include <asm-generic/pci_iomap.h>
 
-#endif
+#endif /* __GENERIC_IOMAP_H */
Signature · 1 line
1.7.7.6
author
#1 lore raw

Oh, sorry, need use '__ASM_GENERIC_IOMAP_H, instead.

I will send patch v2.

Quoted 26 lines · Chen Gang

Recommend to let the header file macro mark match the file name.

---
 include/asm-generic/iomap.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/asm-generic/iomap.h +3 -3
index 6afd7d6..236c78c 100644
@@ -1,5 +1,5 @@
-#ifndef __GENERIC_IO_H
-#define __GENERIC_IO_H
+#ifndef __GENERIC_IOMAP_H
+#define __GENERIC_IOMAP_H
 
 #include <linux/linkage.h>
 #include <asm/byteorder.h>
@@ -78,4 +78,4 @@ static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
 
 #include <asm-generic/pci_iomap.h>
 
-#endif
+#endif /* __GENERIC_IOMAP_H */
Signature · 1 line
Chen Gang
author
#2 lore raw

PATCH v2 1/1 include/asm-generic/iomap.h: trivial: use '__ASM_GENERIC_IOMAP_H' instead of '__GENERIC_IO_H'

Recommend to let the header file macro mark match the file name.

---
 include/asm-generic/iomap.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/asm-generic/iomap.h +3 -3
index 6afd7d6..facfb39 100644
@@ -1,5 +1,5 @@
-#ifndef __GENERIC_IO_H
-#define __GENERIC_IO_H
+#ifndef __ASM_GENERIC_IOMAP_H
+#define __ASM_GENERIC_IOMAP_H
 
 #include <linux/linkage.h>
 #include <asm/byteorder.h>
@@ -78,4 +78,4 @@ static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
 
 #include <asm-generic/pci_iomap.h>
 
-#endif
+#endif /* __ASM_GENERIC_IOMAP_H */
Signature · 1 line
1.7.7.6
#3 lore raw

Re: [PATCH v2] include/asm-generic/iomap.h: trivial: use '__ASM_GENERIC_IOMAP_H' instead of '__GENERIC_IO_H'

Hello maintainers:

Please help check this patch whether OK, when you have time.

Thanks.

Quoted 26 lines · Chen Gang

Recommend to let the header file macro mark match the file name.

---
 include/asm-generic/iomap.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/asm-generic/iomap.h +3 -3
index 6afd7d6..facfb39 100644
@@ -1,5 +1,5 @@
-#ifndef __GENERIC_IO_H
-#define __GENERIC_IO_H
+#ifndef __ASM_GENERIC_IOMAP_H
+#define __ASM_GENERIC_IOMAP_H
 
 #include <linux/linkage.h>
 #include <asm/byteorder.h>
@@ -78,4 +78,4 @@ static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
 
 #include <asm-generic/pci_iomap.h>
 
-#endif
+#endif /* __ASM_GENERIC_IOMAP_H */
Signature · 1 line
Chen Gang