Skip to contentSkip to conversation

ARM: cpuidle: davinci: Fix target residency

PATCH Superseded Daniel Lezcano 2 participants 3 messages Jun 27, 2013 – Jul 11, 2013

Subsystems (3)
Arm (32-bit) Arm sub-architectures TI DaVinci machine support
lore
Share & tools
lore

Daniel Lezcano

author
#0 lore raw

PATCH v2 1/1 ARM: cpuidle: davinci: Fix target residency

The commit 19976c2a88d125aec16b9255c7197c297bbdd637 changed the target residency to 100000, assuming this is a careless mistake.

commit 19976c2a88d125aec16b9255c7197c297bbdd637

Author: Robert Lee <[email protected]>
Date:   Tue Mar 20 15:22:45 2012 -0500

ARM: davinci: Consolidate time keeping and irq enable

Enable core cpuidle timekeeping and irq enabling and remove that handling from this code.

Signed-off-by Robert Lee <[email protected]>
Reviewed-by Kevin Hilman <[email protected]>
Reviewed-by Daniel Lezcano <[email protected]>
Acked-by Jean Pihet <[email protected]>
Signed-off-by Len Brown <[email protected]>

The same happened to the at91's cpuidle driver.

Fix it by putting the initial value to 10000.

Signed-off-by Daniel Lezcano <[email protected]>
---
 arch/arm/mach-davinci/cpuidle.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-davinci/cpuidle.c +1 -1
index 36aef3a..f1ac1c9 100644
@@ -65,7 +65,7 @@ static struct cpuidle_driver davinci_idle_driver = {
 	.states[1]		= {
 		.enter			= davinci_enter_idle,
 		.exit_latency		= 10,
-		.target_residency	= 100000,
+		.target_residency	= 10000,
 		.flags			= CPUIDLE_FLAG_TIME_VALID,
 		.name			= "DDR SR",
 		.desc			= "WFI and DDR Self Refresh",
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 ARM: cpuidle: davinci: Fix target residency

Quoted 18 lines · Daniel Lezcano

The commit 19976c2a88d125aec16b9255c7197c297bbdd637 changed the target residency to 100000, assuming this is a careless mistake.

commit 19976c2a88d125aec16b9255c7197c297bbdd637

Author: Robert Lee <[email protected]>
Date:   Tue Mar 20 15:22:45 2012 -0500

ARM: davinci: Consolidate time keeping and irq enable

Enable core cpuidle timekeeping and irq enabling and remove that handling from this code.

Signed-off-by Robert Lee <[email protected]>
Reviewed-by Kevin Hilman <[email protected]>
Reviewed-by Daniel Lezcano <[email protected]>
Acked-by Jean Pihet <[email protected]>
Signed-off-by Len Brown <[email protected]>
Quoted 5 lines

The same happened to the at91's cpuidle driver.

Fix it by putting the initial value to 10000.

Signed-off-by Daniel Lezcano <[email protected]>
Acked-by Sekhar Nori <[email protected]>

Thanks,
Sekhar

author
#2 lore raw

PATCH v2 1/1 ARM: cpuidle: davinci: Fix target residency

Quoted 19 lines · Sekhar Nori
Quoted 18 lines · Daniel Lezcano

The commit 19976c2a88d125aec16b9255c7197c297bbdd637 changed the target residency to 100000, assuming this is a careless mistake.

commit 19976c2a88d125aec16b9255c7197c297bbdd637

Author: Robert Lee <[email protected]>
Date:   Tue Mar 20 15:22:45 2012 -0500

ARM: davinci: Consolidate time keeping and irq enable

Enable core cpuidle timekeeping and irq enabling and remove that handling from this code.

Signed-off-by Robert Lee <[email protected]>
Reviewed-by Kevin Hilman <[email protected]>
Reviewed-by Daniel Lezcano <[email protected]>
Acked-by Jean Pihet <[email protected]>
Signed-off-by Len Brown <[email protected]>
Quoted 7 lines
Quoted 5 lines

The same happened to the at91's cpuidle driver.

Fix it by putting the initial value to 10000.

Signed-off-by Daniel Lezcano <[email protected]>
Acked-by Sekhar Nori <[email protected]>

Hi Sekhar,

I applied this patch on my tree for the next PM pull request.

Thanks
-- Daniel

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog