Skip to contentSkip to conversation

mm: sched: numa: fix NUMA balancing when !SCHED_DEBUG

PATCH In review Dave Kleikamp 2 participants 2 messages Jun 28, 2013 – Jul 11, 2013

Subsystems (2)
Memory management Scheduler
lore
Share & tools
lore

Dave Kleikamp

author
#0 lore raw

PATCH 1/1 mm: sched: numa: fix NUMA balancing when !SCHED_DEBUG

Commit 3105b86a defined numabalancing_enabled to control the enabling and disabling of automatic NUMA balancing, but it is never used.

I believe the intention was to use this in place of sched_feat_numa(NUMA).

Currently, if SCHED_DEBUG is not defined, sched_feat_numa(NUMA) will never be changed from the initial "false".

Signed-off-by Dave Kleikamp <[email protected]>
---
 kernel/sched/fair.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/sched/fair.c +2 -2
index c61a614..fc11c2f 100644
@@ -813,7 +813,7 @@ void task_numa_fault(int node, int pages, bool migrated)
 {
 	struct task_struct *p = current;
 
-	if (!sched_feat_numa(NUMA))
+	if (!numabalancing_enabled)
 		return;
 
 	/* FIXME: Allocate task-specific structure for placement policy here */

@@ -5751,7 +5751,7 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
 		entity_tick(cfs_rq, se, queued);
 	}
 
-	if (sched_feat_numa(NUMA))
+	if (numabalancing_enabled)
 		task_tick_numa(rq, curr);
 
 	update_rq_runnable_avg(rq, 1);
Signature · 7 lines
1.8.3.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Dave Kleikamp

Commit 3105b86a defined numabalancing_enabled to control the enabling and disabling of automatic NUMA balancing, but it is never used.

I believe the intention was to use this in place of sched_feat_numa(NUMA).

Currently, if SCHED_DEBUG is not defined, sched_feat_numa(NUMA) will never be changed from the initial "false".

Signed-off-by Dave Kleikamp <[email protected]>
Acked-by Mel Gorman <[email protected]>
Signature · 8 lines
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>