Skip to contentSkip to conversation

rt2x00: rt2800lib: add RFCSR register initialization for RT3593

PATCH Xose Vazquez Perez 2 participants 2 messages Jun 28, 2013 – Jun 29, 2013

lore
Share & tools
lore

Xose Vazquez Perez

author
#0 lore raw
Quoted 2 lines · Gabor Juhos

Based on the Ralink DPO_RT5572_LinuxSTA_2.6.0.1_20120629 driver.

There is a more recent version: DPO_RT5572_LinuxSTA_2.6.1.3_20121022

drivers/net/wireless/rt2x00/rt2800lib.c

Quoted 8 lines
drivers/net/wireless/rt2x00/rt2800lib.c +3 -0
index 32ecd1a..0041b2c 100644
[...]
+	/* Initialize default register values */
+	rt2800_rfcsr_write(rt2x00dev, 1, 0x03);
+	rt2800_rfcsr_write(rt2x00dev, 3, 0x80);

from ./20120911_RT3573_Linux_STA_v2.5.0.0_Rev1_DPO/chips/rt3593.c

{RF_R02, 0x80}

but it was deleted in ./DPO_RT5572_LinuxSTA_2.6.1.3_20121022/chips/rt3593.c

Was it deliberate ? or a mistake ??

#1 lore raw

2013.06.28. 23:42 keltezéssel, Xose Vazquez Perez írta:

Quoted 6 lines
Quoted 2 lines · Gabor Juhos

Based on the Ralink DPO_RT5572_LinuxSTA_2.6.0.1_20120629 driver.

There is a more recent version: DPO_RT5572_LinuxSTA_2.6.1.3_20121022

Yes, I know. However I wanted to test AP mode with the vendor driver and that is only supported in the '2.6.0.1_20120629' version.

Quoted 12 lines

drivers/net/wireless/rt2x00/rt2800lib.c

Quoted 9 lines
drivers/net/wireless/rt2x00/rt2800lib.c +3 -0
index 32ecd1a..0041b2c 100644
[...]
+	/* Initialize default register values */
+	rt2800_rfcsr_write(rt2x00dev, 1, 0x03);
+	rt2800_rfcsr_write(rt2x00dev, 3, 0x80);

from ./20120911_RT3573_Linux_STA_v2.5.0.0_Rev1_DPO/chips/rt3593.c

Quoted 5 lines

{RF_R02, 0x80}

but it was deleted in ./DPO_RT5572_LinuxSTA_2.6.1.3_20121022/chips/rt3593.c

Was it deliberate ? or a mistake ??

It is intentional. The patch is based on the *2.6.0.1* driver, and the value is not present in that.

-Gabor