Skip to contentSkip to conversation

Pull request for branch yem-misc-updates

GIT PULL New Yann E. MORIN 3 participants 7 messages Jun 29, 2013 – Jul 1, 2013

lore
Share & tools
lore
#0 lore raw

From: "Yann E. MORIN" <[email protected]>

Hello All!

This two-patch series adds some cosmetics to the legacy menu.

The first patch displays the removal date in the menuconfig, to show the user how old the legacy options he's using are.

The second patch adds to the top-level comment, that legacy options will be removed at some point in the future, and that non-updated .config files may fail to build, or run, in unpredictable ways.

If we do not intend to remove legacy options, let's just drop patch #2, of course.

Regards,
Yann E. MORIN.

The following changes since commit fc034397fc5c85115a7cc29b8dcc6738a1f8cdc3:

openvpn: define license (2013-06-28 21:47:43 +0200)

are available in the git repository at:

git://gitorious.org/buildroot/buildroot.git yem-misc-updates

for you to fetch changes up to 0e43364c4b19cbab8f8297f38ab009475beba3d6:

legacy: make it clear legacy options will be removed at some point (2013-06-30 00:28:49 +0200)

----------------------------------------------------------------
Yann E. MORIN (2):
legacy: print removal date in menuconfig
legacy: make it clear legacy options will be removed at some point

 Config.in.legacy | 31 +++++++++++++++----------------
 1 file changed, 15 insertions(+), 16 deletions(-)
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#1 lore raw

PATCH 1/2 legacy: print removal date in menuconfig

From: "Yann E. MORIN" <[email protected]>

Show the user how old the legacy options are, as a subtle suggestion for him to update mopre often. ;-)

---
 Config.in.legacy | 27 +++++++++++----------------
 1 file changed, 11 insertions(+), 16 deletions(-)
Config.in.legacy +11 -16
index cd23492..1252d16 100644
@@ -40,9 +40,8 @@ comment "As long as these options stay selected, the build   "
 comment "will fail.                                          "
 endif
 
-#
-# Legacy options since 2013.08
-#
+###############################################################################
+comment "Legacy options removed in 2013.08"
 
 config BR2_PACKAGE_DOSFSTOOLS_DOSFSCK
 	bool "dosfstools dosfsck renamed to fsck.fat"
@@ -65,9 +64,8 @@ config BR2_PACKAGE_DOSFSTOOLS_MKDOSFS
 	help
 	  mkdosfs was renamed upstream to mkfs.fat for consistency.
 
-#
-# Legacy options since 2013.05
-#
+###############################################################################
+comment "Legacy options removed in 2013.05"
 
 config BR2_PACKAGE_LINUX_FIRMWARE_RTL_8192
 	bool "Realtek 8192 replaced by Realtek 81xx"
@@ -83,9 +81,8 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RTL_8712
 	help
 	  Now covers the whole Realtek 87xx familly: 8712/8723.
 
-#
-# Legacy options since 2013.02
-#
+###############################################################################
+comment "Legacy options removed in 2013.02"
 
 config BR2_sa110
 	bool "sa110 ARM target switched to strongarm"
@@ -151,9 +148,9 @@ config BR2_PACKAGE_DIRECTB_TESTS
 	  The option has been renamed
 	  BR2_PACKAGE_DIRECTFB_TESTS.
 
-#
-# Legacy options since 2012.11
-#
+###############################################################################
+comment "Legacy options removed in 2012.11"
+
 config BR2_PACKAGE_CUSTOMIZE
 	bool "customize package has been removed"
 	select BR2_LEGACY
@@ -188,10 +185,8 @@ config BR2_PACKAGE_PTHREAD_STUBS
 	  For consistency reason, the pthread-stubs package has been
 	  renamed to xlib_libpthread-stubs.
 
-
-#
-# Legacy options since 2012.08
-#
+###############################################################################
+comment "Legacy options removed in 2012.08"
 
 config BR2_PACKAGE_GETTEXT_STATIC
 	bool "libgettext.a is now selected by BR2_PREFER_STATIC_LIB"
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 1/2 legacy: print removal date in menuconfig

Quoted 6 lines · Yann E. MORIN

From: "Yann E. MORIN"<[email protected]>

Show the user how old the legacy options are, as a subtle suggestion for him to update mopre often.;-)

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 2/2 legacy: make it clear legacy options will be removed at some point

In reply to Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

---
 Config.in.legacy | 4 ++++
 1 file changed, 4 insertions(+)
Config.in.legacy +4 -0
index 1252d16..921a0eb 100644
@@ -38,6 +38,10 @@ comment "Please look at the options which have been selected "
 comment "and read their help text.                           "
 comment "As long as these options stay selected, the build   "
 comment "will fail.                                          "
+comment "Note: at some point in the future, the oldest legacy"
+comment "options will be removed, and configuration files    "
+comment "that still have those options set, will fail to     "
+comment "build, or run, in unpredictable ways.               "
 endif
 
 ###############################################################################
Signature · 1 line
1.8.1.2
#4 lore raw
In reply to Yann E. MORIN
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Yann> From: "Yann E. MORIN" <[email protected]> Yann> Hello All!

Yann> This two-patch series adds some cosmetics to the legacy menu.

Yann> The first patch displays the removal date in the menuconfig, to show Yann> the user how old the legacy options he's using are.

Yann> The second patch adds to the top-level comment, that legacy options Yann> will be removed at some point in the future, and that non-updated Yann> .config files may fail to build, or run, in unpredictable ways.

Yann> If we do not intend to remove legacy options, let's just drop patch #2, Yann> of course.

I think we do, question is how soon? 6 months, 1 year?

They are not very expensive, so I suggest we keep them for 1 year.

Committed series, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw
Quoted 14 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Yann> From: "Yann E. MORIN" <[email protected]> Yann> Hello All!

Yann> This two-patch series adds some cosmetics to the legacy menu.

Yann> The first patch displays the removal date in the menuconfig, to show Yann> the user how old the legacy options he's using are.

Yann> The second patch adds to the top-level comment, that legacy options Yann> will be removed at some point in the future, and that non-updated Yann> .config files may fail to build, or run, in unpredictable ways.

Quoted 6 lines

Yann> If we do not intend to remove legacy options, let's just drop patch #2, Yann> of course.

I think we do, question is how soon? 6 months, 1 year?

They are not very expensive, so I suggest we keep them for 1 year.

I would keep them much longer, at least three years. Most distros have
a 3 year or more 'stable' branch, so anything inexpensive that we can do to approximate that is good I think.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#6 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Yann> If we do not intend to remove legacy options, let's just drop patch #2, Yann> of course.

Quoted 4 lines
Quoted 4 lines

I think we do, question is how soon? 6 months, 1 year?

They are not very expensive, so I suggest we keep them for 1 year.

Arnout> I would keep them much longer, at least three years. Most Arnout> distros have a 3 year or more 'stable' branch, so anything Arnout> inexpensive that we can do to approximate that is good I think.

Ok, 3 years it is.

Signature · 1 line
Bye, Peter Korsgaard