Skip to contentSkip to conversation

brcm: add brcmfmac sdio firmware for bcm43241

PATCH In review Arend van Spriel 2 participants 5 messages May 29, 2013 – Jul 8, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 brcm: add brcmfmac sdio firmware for bcm43241

From: Franky Lin <[email protected]>

Add missing firmware file for the BCM43241 SDIO device. The firmware version is v6.10.170.4

---
Hi Ben,

Somehow this firmware got forgotten although brcmfmac has support for the device for a while now.

Regards,
Arend

---
 WHENCE                 |    1 +
 brcm/brcmfmac43241.bin |  Bin 0 -> 414238 bytes
 2 files changed, 1 insertion(+)
 create mode 100644 brcm/brcmfmac43241.bin
WHENCE +1 -0
index ef64612..5eca1d0 100644
@@ -1652,6 +1652,7 @@ Driver: brcmfmac - Broadcom 802.11n fullmac wireless LAN driver.
 
 File: brcm/bcm4329-fullmac-4.bin
 File: brcm/brcmfmac43236b.bin
+File: brcm/brcmfmac43241.bin
 File: brcm/brcmfmac4329.bin
 File: brcm/brcmfmac4330.bin
 File: brcm/brcmfmac4334.bin
brcm/brcmfmac43241.bin new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..37892fa8c21cb6cf1797381896e47648843e7894
GIT binary patch
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 27 lines · Arend van Spriel

From: Franky Lin <[email protected]>

Add missing firmware file for the BCM43241 SDIO device. The firmware version is v6.10.170.4

---
Hi Ben,

Somehow this firmware got forgotten although brcmfmac has support for the device for a while now.

Regards,
Arend

---
 WHENCE                 |    1 +
 brcm/brcmfmac43241.bin |  Bin 0 -> 414238 bytes
 2 files changed, 1 insertion(+)
 create mode 100644 brcm/brcmfmac43241.bin
WHENCE +0 -0
index ef64612..5eca1d0 100644

WHENCE Driver: brcmfmac - Broadcom 802.11n fullmac wireless LAN driver. · line 1658

Quoted 7 lines
WHENCE +1 -0
@@ -1652,6 +1652,7 @@ Driver: brcmfmac - Broadcom 802.11n fullmac wireless LAN driver.
 
 File: brcm/bcm4329-fullmac-4.bin
 File: brcm/brcmfmac43236b.bin
+File: brcm/brcmfmac43241.bin
 File: brcm/brcmfmac4329.bin
 File: brcm/brcmfmac4330.bin
 File: brcm/brcmfmac4334.bin

[...]

Unless you're doing something very clever with macros, I don't believe you've posted any driver code that uses this file... or several of the others. The current driver in net-next (I don't know what you've sent to Nvidia) appears to request only these files:

- brcm/brcmfmac43143.bin
- brcm/brcmfmac43236b.bin
- brcm/brcmfmac43242a.bin
- brcm/brcmfmac-sdio.bin
- brcm/brcmfmac-sdio.txt

Looking through the git history, I can see that various other names have been used:

- brcm/bcm4329-fullmac-4.bin (renamed to brcm/brcmfmac-sdio.bin)
- brcm/bcm4329-fullmac-4.txt (renamed to brcm/brcmfmac-sdio.txt)
- brcm/brcmfmac-usb.bin (renamed to brcm/brcmfmac43236b.bin)
- brcm/brcmfmac.bin (renamed to brcm/brcmfmac-sdio.bin)
- brcm/brcmfmac.txt (renamed to brcm/brcmfmac-sdio.txt)

So I think, before this patch is applied, you owe me and David patches to:

1. Add brcm/brcmfmac43143.bin, brcm/brcmfmac43242a.bin and brcm/brcmfmac-sdio.txt.
2. Rename brcm/bcm4329-fullmac-4.bin to brcm/brcmfmac-sdio.bin.
3. Add symlinks from all the old names to the new names. (As linux-firmware should support old in-tree drivers indefinitely.)

and you owe linux-wireless some driver patches.

linux-firmware.git is not the appropriate place to send firmware used only by out-of-tree code, and any firmware blob that has never been referenced by in-tree code is subject to removal.

Ben.

Signature · 2 lines
Ben Hutchings
Tomorrow will be cancelled due to lack of interest.
#2 lore raw
Quoted 37 lines · Ben Hutchings
Quoted 34 lines · Arend van Spriel

From: Franky Lin <[email protected]>

Add missing firmware file for the BCM43241 SDIO device. The firmware version is v6.10.170.4

---
Hi Ben,

Somehow this firmware got forgotten although brcmfmac has support for the device for a while now.

Regards,
Arend

---
  WHENCE                 |    1 +
  brcm/brcmfmac43241.bin |  Bin 0 -> 414238 bytes
  2 files changed, 1 insertion(+)

create mode 100644 brcm/brcmfmac43241.bin

WHENCE +1 -0
index ef64612..5eca1d0 100644
@@ -1652,6 +1652,7 @@ Driver: brcmfmac - Broadcom 802.11n fullmac wireless LAN driver.
 
  File: brcm/bcm4329-fullmac-4.bin
  File: brcm/brcmfmac43236b.bin
+File: brcm/brcmfmac43241.bin
  File: brcm/brcmfmac4329.bin
  File: brcm/brcmfmac4330.bin
  File: brcm/brcmfmac4334.bin

[...]

Quoted 4 lines

Unless you're doing something very clever with macros, I don't believe you've posted any driver code that uses this file... or several of the others. The current driver in net-next (I don't know what you've sent to Nvidia) appears to request only these files:

Hi, Ben

Nvidia was just using the upstream brcmfmac driver. The "clever" thing we are doing for the SDIO part of our brcmfmac driver is that the firmware filename requested by the driver is always brcmfmac-sdio.bin. We explain on wireless.kernel.org that people should link/copy the firmware file for their device to brcmfmac-sdio.bin and get brcmfmac-sdio.txt from their board supplier as it is very board specific initialization data. I understand this complicates your job in finding out where the firmware is actually used and I apologize.

Quoted 3 lines

- brcm/brcmfmac43143.bin
- brcm/brcmfmac43236b.bin
- brcm/brcmfmac43242a.bin

These are used by USB part of brcmfmac and

Quoted 12 lines

- brcm/brcmfmac-sdio.bin
- brcm/brcmfmac-sdio.txt

Looking through the git history, I can see that various other names have been used:

- brcm/bcm4329-fullmac-4.bin (renamed to brcm/brcmfmac-sdio.bin)
- brcm/bcm4329-fullmac-4.txt (renamed to brcm/brcmfmac-sdio.txt)
- brcm/brcmfmac-usb.bin (renamed to brcm/brcmfmac43236b.bin)
- brcm/brcmfmac.bin (renamed to brcm/brcmfmac-sdio.bin)
- brcm/brcmfmac.txt (renamed to brcm/brcmfmac-sdio.txt)

Quoted 5 lines

So I think, before this patch is applied, you owe me and David patches to:

1. Add brcm/brcmfmac43143.bin, brcm/brcmfmac43242a.bin and brcm/brcmfmac-sdio.txt.

The 43143 and 43242 bin files will be submitted, but these firmwares have not yet been released. I have to wait for a green light on that.

Quoted 1 line

2. Rename brcm/bcm4329-fullmac-4.bin to brcm/brcmfmac-sdio.bin.

That file is there for brcmfmac in older kernels (< v3.3) as the replacement brcmfmac4329.bin does not work with brcmfmac in those older kernels.

Quoted 2 lines

3. Add symlinks from all the old names to the new names. (As linux-firmware should support old in-tree drivers indefinitely.)

I will look into this to see what names were used by brcmfmac since it was mainlined.

Quoted 5 lines

and you owe linux-wireless some driver patches.

linux-firmware.git is not the appropriate place to send firmware used only by out-of-tree code, and any firmware blob that has never been referenced by in-tree code is subject to removal.

I am aware and none of the firmwares we released are for out-of-tree code. We actually got feedback that using the same firmware filename for multiple devices was not very user-friendly. Therefore we will get rid of this quirky approach in the next kernel and the firmware files in linux-firmware will be listed in brcmfmac using the MODULE_FIRMWARE() macro.

Regards,
Arend

#3 lore raw
Quoted 2 lines · Arend van Spriel
Quoted 1 line · Ben Hutchings

On Wed, 2013-05-29 at 15:13 +0200, Arend van Spriel wrote:

[...]

Quoted 17 lines
Quoted 12 lines
Quoted 10 lines
WHENCE +1 -0
@@ -1652,6 +1652,7 @@ Driver: brcmfmac - Broadcom 802.11n fullmac wireless LAN driver.
 
  File: brcm/bcm4329-fullmac-4.bin
  File: brcm/brcmfmac43236b.bin
+File: brcm/brcmfmac43241.bin
  File: brcm/brcmfmac4329.bin
  File: brcm/brcmfmac4330.bin
  File: brcm/brcmfmac4334.bin

[...]

Quoted 4 lines

Unless you're doing something very clever with macros, I don't believe you've posted any driver code that uses this file... or several of the others. The current driver in net-next (I don't know what you've sent to Nvidia) appears to request only these files:

Quoted 7 lines

Hi, Ben

Nvidia was just using the upstream brcmfmac driver. The "clever" thing we are doing for the SDIO part of our brcmfmac driver is that the firmware filename requested by the driver is always brcmfmac-sdio.bin. We explain on wireless.kernel.org that people should link/copy the firmware file for their device to brcmfmac-sdio.bin

Not a great idea, but I think you recognise that now.

Quoted 3 lines

and get
brcmfmac-sdio.txt from their board supplier as it is very board specific initialization data.

What if someone wants to put more than one of these devices in the same system?

[...]

Quoted 6 lines
Quoted 5 lines

So I think, before this patch is applied, you owe me and David patches to:

1. Add brcm/brcmfmac43143.bin, brcm/brcmfmac43242a.bin and brcm/brcmfmac-sdio.txt.

Quoted 8 lines

The 43143 and 43242 bin files will be submitted, but these firmwares have not yet been released. I have to wait for a green light on that.

Quoted 1 line

2. Rename brcm/bcm4329-fullmac-4.bin to brcm/brcmfmac-sdio.bin.

That file is there for brcmfmac in older kernels (< v3.3) as the replacement brcmfmac4329.bin does not work with brcmfmac in those older kernels.

OK.

Quoted 5 lines
Quoted 2 lines

3. Add symlinks from all the old names to the new names. (As linux-firmware should support old in-tree drivers indefinitely.)

I will look into this to see what names were used by brcmfmac since it was mainlined.

As I said, all the names that have been used should be supported. So either provide multiple versions of the firmware or add symlinks, as appropriate.

Quoted 11 lines
Quoted 5 lines

and you owe linux-wireless some driver patches.

linux-firmware.git is not the appropriate place to send firmware used only by out-of-tree code, and any firmware blob that has never been referenced by in-tree code is subject to removal.

I am aware and none of the firmwares we released are for out-of-tree code. We actually got feedback that using the same firmware filename for multiple devices was not very user-friendly. Therefore we will get rid of this quirky approach in the next kernel and the firmware files in linux-firmware will be listed in brcmfmac using the MODULE_FIRMWARE() macro.

Thanks for clearing this up.

Please re-send the new firmware, and include the firmware version in WHENCE.

Ben.

Signature · 2 lines
Ben Hutchings
Tomorrow will be cancelled due to lack of interest.
#4 lore raw
Quoted 29 lines · Ben Hutchings
Quoted 2 lines · Arend van Spriel
Quoted 1 line · Ben Hutchings

On Wed, 2013-05-29 at 15:13 +0200, Arend van Spriel wrote:

[...]

Quoted 17 lines
Quoted 12 lines
Quoted 10 lines
WHENCE +1 -0
@@ -1652,6 +1652,7 @@ Driver: brcmfmac - Broadcom 802.11n fullmac wireless LAN driver.
 
   File: brcm/bcm4329-fullmac-4.bin
   File: brcm/brcmfmac43236b.bin
+File: brcm/brcmfmac43241.bin
   File: brcm/brcmfmac4329.bin
   File: brcm/brcmfmac4330.bin
   File: brcm/brcmfmac4334.bin

[...]

Quoted 4 lines

Unless you're doing something very clever with macros, I don't believe you've posted any driver code that uses this file... or several of the others. The current driver in net-next (I don't know what you've sent to Nvidia) appears to request only these files:

Quoted 7 lines

Hi, Ben

Nvidia was just using the upstream brcmfmac driver. The "clever" thing we are doing for the SDIO part of our brcmfmac driver is that the firmware filename requested by the driver is always brcmfmac-sdio.bin. We explain on wireless.kernel.org that people should link/copy the firmware file for their device to brcmfmac-sdio.bin

Quoted 8 lines

Not a great idea, but I think you recognise that now.

Quoted 3 lines

and get
brcmfmac-sdio.txt from their board supplier as it is very board specific initialization data.

What if someone wants to put more than one of these devices in the same system?

It is the same issue as the firmware.

Quoted 21 lines

[...]

Quoted 6 lines
Quoted 5 lines

So I think, before this patch is applied, you owe me and David patches to:

1. Add brcm/brcmfmac43143.bin, brcm/brcmfmac43242a.bin and brcm/brcmfmac-sdio.txt.

Quoted 8 lines

The 43143 and 43242 bin files will be submitted, but these firmwares have not yet been released. I have to wait for a green light on that.

Quoted 1 line

2. Rename brcm/bcm4329-fullmac-4.bin to brcm/brcmfmac-sdio.bin.

That file is there for brcmfmac in older kernels (< v3.3) as the replacement brcmfmac4329.bin does not work with brcmfmac in those older kernels.

OK.

Quoted 3 lines
Quoted 2 lines

3. Add symlinks from all the old names to the new names. (As linux-firmware should support old in-tree drivers indefinitely.)

Quoted 6 lines
Quoted 2 lines

I will look into this to see what names were used by brcmfmac since it was mainlined.

As I said, all the names that have been used should be supported. So either provide multiple versions of the firmware or add symlinks, as appropriate.

Will do.

Quoted 12 lines
Quoted 11 lines
Quoted 5 lines

and you owe linux-wireless some driver patches.

linux-firmware.git is not the appropriate place to send firmware used only by out-of-tree code, and any firmware blob that has never been referenced by in-tree code is subject to removal.

I am aware and none of the firmwares we released are for out-of-tree code. We actually got feedback that using the same firmware filename for multiple devices was not very user-friendly. Therefore we will get rid of this quirky approach in the next kernel and the firmware files in linux-firmware will be listed in brcmfmac using the MODULE_FIRMWARE() macro.

Quoted 4 lines

Thanks for clearing this up.

Please re-send the new firmware, and include the firmware version in WHENCE.

I will prepare patches to address item #3 above and to add the new firmware.

Thanks,
Arend