Skip to contentSkip to conversation

media: s5p-tv: Fix Warn on driver probe

PATCH In review Mateusz Krawczuk 2 participants 2 messages Jul 5, 2013 – Jul 9, 2013 Media (V4L/DVB)

lore
Share & tools
lore

Mateusz Krawczuk

author
#0 lore raw

PATCH 1/1 media: s5p-tv: Fix Warn on driver probe

From 2cbf0f259fe24d0e3fe9f5b45036dcae3ffb6213 Mon Sep 17 00:00:00 2001
From: Mateusz Krawczuk<[email protected]>
Date: Wed, 3 Jul 2013 14:51:45 +0200
Subject: [PATCH] media: s5p-tv: Fix Warn on driver probe

The timestamp_type field in struct vb2_queue wasn`t initalized at s5p-tv probe. This caused warn on message at boot. This patch fixed this issue.

Signed-off-by Mateusz Krawczuk<[email protected]>
Acked-by Tomasz Stanislawski<[email protected]>
---
 drivers/media/platform/s5p-tv/mixer_video.c |    1 +
 1 file changed, 1 insertion(+)
drivers/media/platform/s5p-tv/mixer_video.c +1 -0
index 641b1f0..87e3b0a 100644
@@ -1125,6 +1125,7 @@ struct mxr_layer *mxr_base_layer_create(struct mxr_device *mdev,
 		.buf_struct_size = sizeof(struct mxr_buffer),
 		.ops = &mxr_video_qops,
 		.mem_ops = &vb2_dma_contig_memops,
+		.timestamp_type = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC,
 	};
 
 	return layer;

-- 1.7.9.5

#1 lore raw

Hi Mateusz,

Thank you for this patch. However if you set timestamp type to monotonic it is necessary for the driver to set the timestamp value.

You can use the v4l2_get_timestamp helper to set the timestamp. According to the documentation it should be set to the time when the first data byte was sent to hardware.

Here you can find more information on how the timestamp field should be handled in drivers https://patchwork.linuxtv.org/patch/18813/

Best wishes,

Signature · 3 lines
Kamil Debski
Linux Kernel Developer
Samsung R&D Institute Poland
Quoted 42 lines

-----Original Message-----
From: [email protected] [mailto:linux-media- [email protected]] On Behalf Of Mateusz Krawczuk
Sent: Friday, July 05, 2013 9:39 AM
To: [email protected]
Subject: [PATCH] media: s5p-tv: Fix Warn on driver probe

From 2cbf0f259fe24d0e3fe9f5b45036dcae3ffb6213 Mon Sep 17 00:00:00 2001
From: Mateusz Krawczuk<[email protected]>
Date: Wed, 3 Jul 2013 14:51:45 +0200
Subject: [PATCH] media: s5p-tv: Fix Warn on driver probe

The timestamp_type field in struct vb2_queue wasn`t initalized at s5p- tv probe.
This caused warn on message at boot. This patch fixed this issue.

Signed-off-by Mateusz Krawczuk<[email protected]>
Acked-by Tomasz Stanislawski<[email protected]>
---
  drivers/media/platform/s5p-tv/mixer_video.c |    1 +
  1 file changed, 1 insertion(+)
drivers/media/platform/s5p-tv/mixer_video.c +1 -0
index 641b1f0..87e3b0a 100644
@@ -1125,6 +1125,7 @@ struct mxr_layer *mxr_base_layer_create(struct
 mxr_device *mdev,
  		.buf_struct_size = sizeof(struct mxr_buffer),
  		.ops = &mxr_video_qops,
  		.mem_ops = &vb2_dma_contig_memops,
+		.timestamp_type = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC,
  	};

return layer;
-- 1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html