Add support for Newflow NanoBone board

PATCH Superseded Mark Jackson 2 participants 3 messages Jul 8, 2013 – Aug 11, 2013

Subsystems (2)

Device tree bindings Arm and arm64 SoC sub-architectures (common parts)

lore

Share & tools

lore

Mark Jackson

author

2013-07-08 18:57 UTC #0 lore raw

PATCH 1/1 Add support for Newflow NanoBone board

NanoBone Specification:
-----------------------
CPU:
TI AM335x @ 720MHz

Memory:
256MB DDR3
128MB NOR flash
128KB FRAM

Ethernet:
2 x 10/100 connected to SMSC LAN8710 PHY

USB:
1 x USB2.0 Type A

I2C:
2Kbit EEPROM (Microchip 24AA02)
RTC (Maxim DS1338)
GPIO Expander (Microchip MCP23017)

Expansion connector:
6 x UART
1 x MMC/SD
1 x USB2.0

Signed-off-by Mark Jackson <[email protected]>

---
 MAINTAINERS                       |    6 +
 arch/arm/boot/dts/Makefile        |    1 +
 arch/arm/boot/dts/am335x-nano.dts |  388 +++++++++++++++++++++++++++++++++++++
 3 files changed, 395 insertions(+)
 create mode 100644 arch/arm/boot/dts/am335x-nano.dts

MAINTAINERS +6 -0

index 97762ad..d4e0da0 100644
@@ -5952,6 +5952,12 @@ L:	[email protected]
 S:	Maintained
 F:	drivers/gpio/gpio-omap.c
 
+OMAP/NEWFLOW NANOBONE MACHINE SUPPORT
+M:	Mark Jackson <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	arch/arm/boot/dts/am335x-nano.dts
+
 OMFS FILESYSTEM
 M:	Bob Copeland <[email protected]>
 L:	[email protected]

arch/arm/boot/dts/Makefile +1 -0

index 641b3c9..0d99a55 100644
@@ -171,6 +171,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
 	am335x-evm.dtb \
 	am335x-evmsk.dtb \
 	am335x-bone.dtb \
+	am335x-nano.dtb \
 	am3517-evm.dtb \
 	am3517_mt_ventoux.dtb \
 	am43x-epos-evm.dtb

arch/arm/boot/dts/am335x-nano.dts new file +388 -0

388 lines not on this page · raw message

Signature · 5 lines

1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Javier Martinez Canillas

Reviewed-by

2013-08-11 11:35 UTC #2 lore raw

Quoted 35 lines · Mark Jackson

Quoted 26 lines · Mark Jackson
NanoBone Specification:
-----------------------
CPU:
TI AM335x @ 720MHz
Memory:
256MB DDR3
128MB NOR flash
128KB FRAM
Ethernet:
2 x 10/100 connected to SMSC LAN8710 PHY
USB:
1 x USB2.0 Type A
I2C:
2Kbit EEPROM (Microchip 24AA02)
RTC (Maxim DS1338)
GPIO Expander (Microchip MCP23017)
Expansion connector:
6 x UART
1 x MMC/SD
1 x USB2.0
Quoted 7 lines
Signed-off-by Mark Jackson <[email protected]>
---
 MAINTAINERS                       |    6 +
 arch/arm/boot/dts/Makefile        |    1 +
 arch/arm/boot/dts/am335x-nano.dts |  388 +++++++++++++++++++++++++++++++++++++
 3 files changed, 395 insertions(+)
 create mode 100644 arch/arm/boot/dts/am335x-nano.dts

Quoted 1 line

Any comments on this new board file ?

Hi Mark,

Overall it looks very good to me, I just have one small comment. Please don't redefine device nodes that are already defined in the included am33xx.dtsi file (pinmux, ocp, gpmc, etc). You should just use what is defined there instead of defining it again in your board DT file.

Also these are IP modules that are internal details of the SoC so is better to keep them outside of board DT files definition.

Please take a look to my am33xx cleanups series [1] to see how it should be defined. Once you have made that changes feel free to add my:

Reviewed-by Javier Martinez Canillas <[email protected]>

Benoit seems to be on holidays so please be patient with him taking your patch.

[1]: http://www.mail-archive.com/[email protected]/msg93738.html

Thanks a lot and best regards,
Javier