Skip to contentSkip to conversation

udev: add runtime dependency on blkid

PATCH In review [email protected] 3 participants 5 messages Jul 8, 2013 – Jul 9, 2013

lore
Share & tools
lore
#0 lore raw

cover udev: add runtime dependency on blkid

From: Jackie Huang <[email protected]>

The following changes since commit 3e1dbabbf33a2e461abc92ff10cd970fe604ee38:

sysstat: backport a patch to fix a parallel building error (2013-07-02 07:58:10 -0700)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib jhuang0/r_bbappend_udev_0708_1
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/r_bbappend_udev_0708_1

Jackie Huang (1):
udev: add runtime dependency on blkid

 meta/recipes-core/udev/udev_182.bb |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 udev: add runtime dependency on blkid

From: Jackie Huang <[email protected]>

udev requires blkid, but this wasn't explicit. Note that the dependency is on util-linux specifically, the one from e2fsprogs won't work.

---
 meta/recipes-core/udev/udev_182.bb |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
meta/recipes-core/udev/udev_182.bb +4 -0
index d66292e..114a557 100644
@@ -5,5 +5,9 @@ PR = "r7"
 # module-init-tools from kmod_git will provide libkmod runtime
 DEPENDS += "module-init-tools"
 
+# Needs blkid from this particular package. The one in e2fsprogs is
+# old and incompatible.
+RDEPENDS_${PN} += "util-linux-blkid"
+
 SRC_URI[md5sum] = "1b964456177fbf48023dfee7db3a708d"
 SRC_URI[sha256sum] = "7857ed19fafd8f3ca8de410194e8c7336e9eb8a20626ea8a4ba6449b017faba4"
Signature · 1 line
1.7.4.1
#2 lore raw
Quoted 6 lines · On 07/08/2013 12:10 AM, [email protected] wrote:

From: Jackie Huang <[email protected]>

udev requires blkid, but this wasn't explicit. Note that the dependency is on util-linux specifically, the one from e2fsprogs won't work.

Doesn't udev use an internal builtin-blkid? Or is the configure finding that we have util-linux and using it instead of the built-in?

If it's a configure test, then it might need to be a DEPENDS, not RDEPENDS.

Sau!

Quoted 21 lines
---
  meta/recipes-core/udev/udev_182.bb |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)
meta/recipes-core/udev/udev_182.bb +4 -0
index d66292e..114a557 100644
@@ -5,5 +5,9 @@ PR = "r7"
  # module-init-tools from kmod_git will provide libkmod runtime
  DEPENDS += "module-init-tools"
 
+# Needs blkid from this particular package. The one in e2fsprogs is
+# old and incompatible.
+RDEPENDS_${PN} += "util-linux-blkid"
+
  SRC_URI[md5sum] = "1b964456177fbf48023dfee7db3a708d"
  SRC_URI[sha256sum] = "7857ed19fafd8f3ca8de410194e8c7336e9eb8a20626ea8a4ba6449b017faba4"
#3 lore raw
Quoted 9 lines · Saul Wold
Quoted 6 lines · On 07/08/2013 12:10 AM, [email protected] wrote:

From: Jackie Huang <[email protected]>

udev requires blkid, but this wasn't explicit. Note that the dependency is on util-linux specifically, the one from e2fsprogs won't work.

Doesn't udev use an internal builtin-blkid? Or is the configure finding that we have util-linux and using it instead of the built-in?

I think (I'm really stale here) I wrote that patch against a udev version prior to the addition of the builtin. And in any case didn't I see that blkid got yanked from the e2fsprogs package at some point anyway? Pretty sure this is not needed in upstream oe-core. Not sure if it ever was.

Andy

author
#4 lore raw
Quoted 8 lines · Andy Ross
Quoted 7 lines · Saul Wold
Quoted 6 lines · On 07/08/2013 12:10 AM, [email protected] wrote:

From: Jackie Huang <[email protected]>

udev requires blkid, but this wasn't explicit. Note that the dependency is on util-linux specifically, the one from e2fsprogs won't work.

Quoted 7 lines
Quoted 2 lines

Doesn't udev use an internal builtin-blkid? Or is the configure finding that we have util-linux and using it instead of the built-in?

I think (I'm really stale here) I wrote that patch against a udev version prior to the addition of the builtin. And in any case didn't I see that blkid got yanked from the e2fsprogs package at some point anyway? Pretty sure this is not needed in upstream oe-core. Not sure

Thanks for clarifying this, I think it it not needed in our layer's bbappend file as well since we had sync up with upstream oe-core, I will check that and clean up the bbappend.

Thanks,
Jackie

Quoted 5 lines

if it ever was.

Andy

Signature · 5 lines
Jackie Huang
WIND RIVER | China Development Center
MSN:[email protected]
Tel: +86 8477 8594
Mobile: +86 138 1027 4745