Skip to contentSkip to conversation

x86 platform drivers: fix gpio leak

PATCH RESEND New Libo Chen 1 participant 1 message Jul 9, 2013 x86 platform drivers

lore
Share & tools
lore

Libo Chen

author
#0 lore raw

PATCH RESEND 1/1 x86 platform drivers: fix gpio leak

when request_irq fails, we should release gpiochip

v2:
fix warning: ignoring return value of 'gpiochip_remove

Signed-off-by Libo Chen <[email protected]>
---
 drivers/platform/x86/intel_pmic_gpio.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
drivers/platform/x86/intel_pmic_gpio.c +5 -1
index 6f4b728..9830264 100644
@@ -288,7 +288,7 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev)
 	retval = request_irq(pg->irq, pmic_irq_handler, 0, "pmic", pg);
 	if (retval) {
 		pr_warn("Interrupt request failed\n");
-		goto err;
+		goto fail_request_irq;
 	}
 
 	for (i = 0; i < 8; i++) {

@@ -299,6 +299,10 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev)
 		irq_set_chip_data(i + pg->irq_base, pg);
 	}
 	return 0;
+
+fail_request_irq:
+	if (gpiochip_remove(&pg->chip))
+		pr_err("gpiochip_remove failed\n");
 err:
 	iounmap(pg->gpiointr);
 err2:
Signature · 1 line
1.7.1