ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference

PATCH New Magnus Damm 4 participants 6 messages Jul 9, 2013 – Aug 4, 2013

Subsystems (2)

Device tree bindings SuperH

lore

Share & tools

lore

Magnus Damm

author

2013-07-09 04:26 UTC #0 lore raw

PATCH 1/1 ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference

From: Magnus Damm <[email protected]>

Add support for the SMSC ethernet controller found on the KZM9D board to the KZM9D DT Reference code.

Signed-off-by Magnus Damm <[email protected]>

---

Built on top of renesas-next-20130704v2 and [PATCH] ARM: shmobile: KZM9D DT reference implementation

 arch/arm/boot/dts/emev2-kzm9d-reference.dts |   31 +++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

arch/arm/boot/dts/emev2-kzm9d-reference.dts +31 -0

@@ -23,4 +23,35 @@
 	chosen {
 		bootargs = "console=ttyS1,115200n81 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096";
 	};
+
+	reg_1p8v: regulator at 0 {
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-1.8V";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	reg_3p3v: regulator at 1 {
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-3.3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	lan9220 at 20000000 {
+		compatible = "smsc,lan9220", "smsc,lan9115";
+		reg = <0x20000000 0x10000>;
+		phy-mode = "mii";
+		interrupt-parent = <&gpio0>;
+		interrupts = <1 1>;	/* active high */
+		reg-io-width = <4>;
+		smsc,irq-active-high;
+		smsc,irq-push-pull;
+		vddvario-supply = <&reg_1p8v>;
+		vdd33a-supply = <&reg_3p3v>;
+	};
 };

Magnus Damm

author

2013-07-09 13:03 UTC #2 lore raw

PATCH 1/1 ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference

Hi Sergei,

Quoted 32 lines · Sergei Shtylyov

Hello.
Quoted 24 lines · Magnus Damm
From: Magnus Damm <[email protected]>
Add support for the SMSC ethernet controller found on the KZM9D board to the KZM9D DT Reference code.
Signed-off-by Magnus Damm <[email protected]>
---
Built on top of renesas-next-20130704v2 and [PATCH] ARM: shmobile: KZM9D DT reference implementation
  arch/arm/boot/dts/emev2-kzm9d-reference.dts |   31
+++++++++++++++++++++++++++
  1 file changed, 31 insertions(+)
arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 renamed from arch/arm/boot/dts/emev2-kzm9d-reference.dts +0 -0
13:06:47.000000000 +0900
arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 renamed from arch/arm/boot/dts/emev2-kzm9d-reference.dts +0 -0
@@ -23,4 +23,35 @@
[...]
Quoted 1 line

Quoted 4 lines

Quoted 1 line
+ lan9220 at 20000000 {
Shouldn't all the Ethernet nodes be called "ethernet"?

Good question. Grepping in arch/arm/boot/dts shows various ways to name the Ethernet nodes. Exactly what is correct or not I can't really say.

Thanks for your feedback.

Cheers,

/ magnus

Sergei Shtylyov

2013-07-09 13:09 UTC #3 lore raw

PATCH 1/1 ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference

Hello.

Quoted 22 lines · Magnus Damm

Quoted 21 lines
Quoted 19 lines
From: Magnus Damm <[email protected]>
Add support for the SMSC ethernet controller found on the KZM9D board to the KZM9D DT Reference code.
Signed-off-by Magnus Damm <[email protected]>
---
Built on top of renesas-next-20130704v2 and [PATCH] ARM: shmobile: KZM9D DT reference implementation
   arch/arm/boot/dts/emev2-kzm9d-reference.dts |   31
+++++++++++++++++++++++++++
   1 file changed, 31 insertions(+)
arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 renamed from arch/arm/boot/dts/emev2-kzm9d-reference.dts +0 -0
13:06:47.000000000 +0900
arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 renamed from arch/arm/boot/dts/emev2-kzm9d-reference.dts +0 -0
@@ -23,4 +23,35 @@
[...]

Quoted 7 lines

Quoted 3 lines
Quoted 1 line
+ lan9220 at 20000000 {
Shouldn't all the Ethernet nodes be called "ethernet"?
Good question. Grepping in arch/arm/boot/dts shows various ways to name the Ethernet nodes. Exactly what is correct or not I can't really say.

See "Node Names" section of [1].

[1] http://www.devicetree.org/Device_Tree_Usage

Quoted 5 lines

Thanks for your feedback.
Cheers,
/ magnus

WBR, Sergei

Simon Horman

2013-07-10 01:03 UTC #4 lore raw

PATCH 1/1 ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference

Quoted 30 lines · Sergei Shtylyov

Hello.
Quoted 25 lines · Magnus Damm
Quoted 25 lines
Quoted 19 lines
From: Magnus Damm <[email protected]>
Add support for the SMSC ethernet controller found on the KZM9D board to the KZM9D DT Reference code.
Signed-off-by Magnus Damm <[email protected]>
---
Built on top of renesas-next-20130704v2 and [PATCH] ARM: shmobile: KZM9D DT reference implementation
  arch/arm/boot/dts/emev2-kzm9d-reference.dts |   31
+++++++++++++++++++++++++++
  1 file changed, 31 insertions(+)
arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 renamed from arch/arm/boot/dts/emev2-kzm9d-reference.dts +0 -0
13:06:47.000000000 +0900
arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 renamed from arch/arm/boot/dts/emev2-kzm9d-reference.dts +0 -0
@@ -23,4 +23,35 @@
[...]
Quoted 1 line
+ lan9220 at 20000000 {
Shouldn't all the Ethernet nodes be called "ethernet"?

Quoted 7 lines

Quoted 3 lines
Good question. Grepping in arch/arm/boot/dts shows various ways to name the Ethernet nodes. Exactly what is correct or not I can't really say.
See "Node Names" section of [1].
[1] http://www.devicetree.org/Device_Tree_Usage

I will queue up this patch for v3.12 in the dt branch and it should appear in renesas-next-20130710.

If there is a desire to consistently name nodes as "ethernet" for shmobile then I would appreciate a cleanup patches to fix all the relevant dts and dtsi files. One SoC or board per patch.

Olof Johansson

2013-08-04 18:51 UTC #5 lore raw

PATCH 1/1 ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference

Quoted 37 lines · Simon Horman

Quoted 36 lines · Sergei Shtylyov
Hello.
Quoted 22 lines · Magnus Damm
Quoted 21 lines
Quoted 19 lines
From: Magnus Damm <[email protected]>
Add support for the SMSC ethernet controller found on the KZM9D board to the KZM9D DT Reference code.
Signed-off-by Magnus Damm <[email protected]>
---
Built on top of renesas-next-20130704v2 and [PATCH] ARM: shmobile: KZM9D DT reference implementation
  arch/arm/boot/dts/emev2-kzm9d-reference.dts |   31
+++++++++++++++++++++++++++
  1 file changed, 31 insertions(+)
arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 renamed from arch/arm/boot/dts/emev2-kzm9d-reference.dts +0 -0
13:06:47.000000000 +0900
arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 renamed from arch/arm/boot/dts/emev2-kzm9d-reference.dts +0 -0
@@ -23,4 +23,35 @@
[...]
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
+ lan9220 at 20000000 {
Shouldn't all the Ethernet nodes be called "ethernet"?
Good question. Grepping in arch/arm/boot/dts shows various ways to name the Ethernet nodes. Exactly what is correct or not I can't really say.
See "Node Names" section of [1].

Quoted 8 lines

Quoted 1 line
[1] http://www.devicetree.org/Device_Tree_Usage
I will queue up this patch for v3.12 in the dt branch and it should appear in renesas-next-20130710.
If there is a desire to consistently name nodes as "ethernet" for shmobile then I would appreciate a cleanup patches to fix all the relevant dts and dtsi files. One SoC or board per patch.

Yes, they should be named ethernet. Rename when you have a chance and/or are touching the files for other nearby changes.

Also, the 9220 chips are usually located on a general-purpose external parallel bus, but they're not modelled that way here. You might want to add proper bindings for future devices on said busses (handling chipselects, etc, as needed).

-Olof