Resolve i2c compilation error for non-FDT case
Subsystems (2)
PATCH 1/1 Resolve i2c compilation error for non-FDT case
This patch resolves the below mentiond compilation error of i2c driver for non-FDT case.
Compilation error:s3c24x0_i2c.c: In function 'board_i2c_init':
s3c24x0_i2c.c:544:18: error: 'CONFIG_MAX_I2C_NUM' undeclared (first use in this function) s3c24x0_i2c.c:544:18: note: each undeclared identifier is reported only once for each function it appears in s3c24x0_i2c.c:545:3: warning: implicit declaration of function 'exynos_pinmux_config' [-Wimplicit-function-declaration] s3c24x0_i2c.c:545:25: error: 'PERIPH_ID_I2C0' undeclared (first use in this function) s3c24x0_i2c.c:546:10: error: 'PINMUX_FLAG_NONE' undeclared (first use in this function) make[1]: *** [/home/albert/src/u-boot-arm/build/VCMA9/drivers/i2c/s3c24x0_i2c.o] Error 1 make: *** [/home/albert/src/u-boot-arm/build/VCMA9/drivers/i2c/libi2c.o] Error 2
--- board/samsung/smdk5250/smdk5250.c | 9 +++++++++ drivers/i2c/s3c24x0_i2c.c | 9 +-------- 2 files changed, 10 insertions(+), 8 deletions(-)
board/samsung/smdk5250/smdk5250.c +9 -0
@@ -332,6 +332,15 @@ static int board_uart_init(void)return ret; } +void board_i2c_init (const void *blob) +{ +int i; +for (i =0 ; i <CONFIG_MAX_I2C_NUM ; i++) { +exynos_pinmux_config ((PERIPH_ID_I2C0 + i), +PINMUX_FLAG_NONE ); + } +} +#ifdef CONFIG_BOARD_EARLY_INIT_F int board_early_init_f (void ) {
drivers/i2c/s3c24x0_i2c.c +1 -8
@@ -515,10 +515,10 @@ int i2c_write(uchar chip, uint addr, int alen, uchar *buffer, int len) len) != 0); } +#ifdef CONFIG_OF_CONTROL void board_i2c_init (const void *blob) {int i; -#ifdef CONFIG_OF_CONTROL int node_list[CONFIG_MAX_I2C_NUM ];int count;
@@ -540,15 +540,8 @@ void board_i2c_init(const void *blob) bus->bus_num = i2c_busses++;exynos_pinmux_config (bus->id,0 ); } -#else -for (i =0 ; i <CONFIG_MAX_I2C_NUM ; i++) { -exynos_pinmux_config ((PERIPH_ID_I2C0 + i), -PINMUX_FLAG_NONE ); - } -#endif } -#ifdef CONFIG_OF_CONTROL static struct s3c24x0_i2c_bus *get_bus (unsigned int bus_idx) {if (bus_idx < i2c_busses)
Signature · 1 line
1.7.3.rc2
PATCH 1/1 Resolve i2c compilation error for non-FDT case
Dear amar_g
On 09/07/13 21:44, amar_g wrote:
Please add prefix at title.
Quoted 1 line
This patch resolves the below mentiond compilation error of i2c driver
typo. -> mentiond
Quoted 28 lines
for non-FDT case.
Compilation error:
s3c24x0_i2c.c: In function 'board_i2c_init':
s3c24x0_i2c.c:544:18: error: 'CONFIG_MAX_I2C_NUM' undeclared (first use in this function) s3c24x0_i2c.c:544:18: note: each undeclared identifier is reported only once for each function it appears in s3c24x0_i2c.c:545:3: warning: implicit declaration of function 'exynos_pinmux_config' [-Wimplicit-function-declaration] s3c24x0_i2c.c:545:25: error: 'PERIPH_ID_I2C0' undeclared (first use in this function) s3c24x0_i2c.c:546:10: error: 'PINMUX_FLAG_NONE' undeclared (first use in this function) make[1]: *** [/home/albert/src/u-boot-arm/build/VCMA9/drivers/i2c/s3c24x0_i2c.o] Error 1 make: *** [/home/albert/src/u-boot-arm/build/VCMA9/drivers/i2c/libi2c.o] Error 2Signed-off-by Rajeshwari Shinde <[email protected]>Signed-off-by Amar <[email protected]>--- board/samsung/smdk5250/smdk5250.c | 9 +++++++++ drivers/i2c/s3c24x0_i2c.c | 9 +-------- 2 files changed, 10 insertions(+), 8 deletions(-)board/samsung/smdk5250/smdk5250.c +0
-0
board/samsung/smdk5250/smdk5250.c static int board_uart_init(void) · line 337
Quoted 6 lines
board/samsung/smdk5250/smdk5250.c +3
-0@@ -332,6 +332,15 @@ static int board_uart_init(void)return ret; } +void board_i2c_init (const void *blob) +{ +int i;
please add blank line here.
board/samsung/smdk5250/smdk5250.c static int board_uart_init(void) · line 343
Quoted 6 lines
board/samsung/smdk5250/smdk5250.c +6
-0+for (i =0 ; i <CONFIG_MAX_I2C_NUM ; i++) { +exynos_pinmux_config ((PERIPH_ID_I2C0 + i), +PINMUX_FLAG_NONE ); + } +} +
This is for non-fdt case, right?
Quoted 26 lines
board/samsung/smdk5250/smdk5250.c +0
-0#ifdef CONFIG_BOARD_EARLY_INIT_F int board_early_init_f (void ) {drivers/i2c/s3c24x0_i2c.c +1
-3@@ -515,10 +515,10 @@ int i2c_write(uchar chip, uint addr, int alen, uchar *buffer, int len) len) != 0); } +#ifdef CONFIG_OF_CONTROL void board_i2c_init (const void *blob) {int i; -#ifdef CONFIG_OF_CONTROL int node_list[CONFIG_MAX_I2C_NUM ];int count;@@ -540,15 +540,8 @@ void board_i2c_init(const void *blob) bus->bus_num = i2c_busses++;exynos_pinmux_config (bus->id,0 ); } -#else -for (i =0 ; i <CONFIG_MAX_I2C_NUM ; i++) {
drivers/i2c/s3c24x0_i2c.c void board_i2c_init(const void *blob) · line 547
Quoted 10 lines
drivers/i2c/s3c24x0_i2c.c +0
-5-exynos_pinmux_config ((PERIPH_ID_I2C0 + i), -PINMUX_FLAG_NONE ); - } -#endif } -#ifdef CONFIG_OF_CONTROL static struct s3c24x0_i2c_bus *get_bus (unsigned int bus_idx) {if (bus_idx < i2c_busses)
Thanks,
Minkyu Kang.
PATCH 1/1 Resolve i2c compilation error for non-FDT case
Dear Minkyu,
Please find my responses below.
Thanks & Regards
Amarendra Reddy
Quoted 48 lines · Minkyu Kang
Dear
amar_gOn 09/07/13 21:44,
amar_gwrote:Please add prefix at title.
OK shall add aprefix 'EXYNOS' at title in the next patch.
Quoted 1 line
This patch resolves the below mentiond compilation error of i2c driver
typo. -> mentiond
OK shall remove the '.' form "for non-FDT case."
Quoted 16 lines
for non-FDT case.
Compilation error:
s3c24x0_i2c.c: In function 'board_i2c_init':
s3c24x0_i2c.c:544:18: error: 'CONFIG_MAX_I2C_NUM' undeclared (first use in this function) s3c24x0_i2c.c:544:18: note: each undeclared identifier is reported only once for each function it appears in s3c24x0_i2c.c:545:3: warning: implicit declaration of function 'exynos_pinmux_config' [-Wimplicit-function-declaration] s3c24x0_i2c.c:545:25: error: 'PERIPH_ID_I2C0' undeclared (first use in this function) s3c24x0_i2c.c:546:10: error: 'PINMUX_FLAG_NONE' undeclared (first use in this function) make[1]: *** [/home/albert/src/u-boot-arm/build/VCMA9/drivers/i2c/s3c24x0_i2c.o] Error 1 make: *** [/home/albert/src/u-boot-arm/build/VCMA9/drivers/i2c/libi2c.o] Error 2Review
Quoted 8 lines
Signed-off-by Rajeshwari Shinde <[email protected]>Signed-off-by Amar <[email protected]>--- board/samsung/smdk5250/smdk5250.c | 9 +++++++++ drivers/i2c/s3c24x0_i2c.c | 9 +-------- 2 files changed, 10 insertions(+), 8 deletions(-)(quoted diff) +0
-0
b/board/samsung/smdk5250/smdk5250.cQuoted 7 lines
index ae1f077..262398f 100644
board/samsung/smdk5250/smdk5250.c +0
-0@@ -332,6 +332,15 @@ static int board_uart_init(void)return ret; }
Quoted 6 lines
board/samsung/smdk5250/smdk5250.c static int board_uart_init(void) · line 337
Quoted 3 lines
board/samsung/smdk5250/smdk5250.c +3
-0+void board_i2c_init (const void *blob) +{ +int i;please add blank line here.
Ok shall add a new line here.
Quoted 8 lines
board/samsung/smdk5250/smdk5250.c static int board_uart_init(void) · line 343
Quoted 6 lines
board/samsung/smdk5250/smdk5250.c +6
-0+for (i =0 ; i <CONFIG_MAX_I2C_NUM ; i++) { +exynos_pinmux_config ((PERIPH_ID_I2C0 + i), +PINMUX_FLAG_NONE ); + } +} +This is for non-fdt case, right?
Yes, it is for non-fdt case.
Quoted 48 lines
drivers/i2c/s3c24x0_i2c.c int i2c_write(uchar chip, uint addr, int alen,
Quoted 11 lines
board/samsung/smdk5250/smdk5250.c +0
-0#ifdef CONFIG_BOARD_EARLY_INIT_F int board_early_init_f (void ) {drivers/i2c/s3c24x0_i2c.c +0
-0@@ -515,10 +515,10 @@ int i2c_write(uchar chip, uint addr, int alen,uchar *buffer, int len)
Quoted 18 lines
drivers/i2c/s3c24x0_i2c.c +1
-3len) != 0); } +#ifdef CONFIG_OF_CONTROL void board_i2c_init (const void *blob) {int i; -#ifdef CONFIG_OF_CONTROL int node_list[CONFIG_MAX_I2C_NUM ];int count;@@ -540,15 +540,8 @@ void board_i2c_init(const void *blob) bus->bus_num = i2c_busses++;exynos_pinmux_config (bus->id,0 ); } -#else -for (i =0 ; i <CONFIG_MAX_I2C_NUM ; i++) {drivers/i2c/s3c24x0_i2c.c void board_i2c_init(const void *blob) · line 547
Quoted 10 lines
drivers/i2c/s3c24x0_i2c.c +0
-5-exynos_pinmux_config ((PERIPH_ID_I2C0 + i), -PINMUX_FLAG_NONE ); - } -#endif } -#ifdef CONFIG_OF_CONTROL static struct s3c24x0_i2c_bus *get_bus (unsigned int bus_idx) {if (bus_idx < i2c_busses)Thanks,
Minkyu Kang.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot