Skip to contentSkip to conversation

ifb: fix oops when loading the ifb failed

PATCH Applied Ding Tianhong 2 participants 2 messages Jul 11, 2013

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ding Tianhong

author
#0 lore raw

PATCH 2/2 ifb: fix oops when loading the ifb failed

If __rtnl_link_register() return faild when loading the ifb, it will take the wrong path and get oops, so fix it just like dummy.

Signed-off-by Ding Tianhong <[email protected]>
---
 drivers/net/ifb.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ifb.c +4 -0
index dc9f6a4..23a33e3 100644
@@ -291,11 +291,15 @@ static int __init ifb_init_module(void)
 
 	rtnl_lock();
 	err = __rtnl_link_register(&ifb_link_ops);
+	if (err < 0)
+		goto out;
 
 	for (i = 0; i < numifbs && !err; i++)
 		err = ifb_init_one(i);
 	if (err)
 		__rtnl_link_unregister(&ifb_link_ops);
+
+out:
 	rtnl_unlock();
 
 	return err;
Signature · 1 line
1.8.0