Skip to contentSkip to conversation

net: fec: Remove bogus flush_dcache_range() call

PATCH New Marek Vasut 2 participants 2 messages Jul 11, 2013 – Jul 12, 2013 Network drivers

lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/1 net: fec: Remove bogus flush_dcache_range() call

Remove incorrectly called and duplicate flush_dcache_range() call from fec_mxc driver. The call is not needed, since the caches are already flushed in fec_tbd_init(), moreover the second argument should be the ending address, not size.

Signed-off-by Marek Vasut <[email protected]>
Reported-by Albert Aribaud <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Tom Rini <[email protected]>
---
 drivers/net/fec_mxc.c |    1 -
 1 file changed, 1 deletion(-)
drivers/net/fec_mxc.c +0 -1
index da95e28..97bf8fe 100644
@@ -560,7 +560,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd)
 		}
 		memset(fec->tbd_base, 0, size);
 		fec_tbd_init(fec);
-		flush_dcache_range((unsigned)fec->tbd_base, size);
 	}
 
 	/*
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 net: fec: Remove bogus flush_dcache_range() call

Quoted 19 lines · Marek Vasut

Remove incorrectly called and duplicate flush_dcache_range() call from fec_mxc driver. The call is not needed, since the caches are already flushed in fec_tbd_init(), moreover the second argument should be the ending address, not size.

Signed-off-by Marek Vasut <[email protected]>
Reported-by Albert Aribaud <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Tom Rini <[email protected]>
---
 drivers/net/fec_mxc.c |    1 -
 1 file changed, 1 deletion(-)
drivers/net/fec_mxc.c +0 -0
index da95e28..97bf8fe 100644

drivers/net/fec_mxc.c static int fec_init(struct eth_device *dev, bd_t* bd) · line 565

Quoted 7 lines
drivers/net/fec_mxc.c +0 -1
@@ -560,7 +560,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd)
 		}
 		memset(fec->tbd_base, 0, size);
 		fec_tbd_init(fec);
-		flush_dcache_range((unsigned)fec->tbd_base, size);
 	}
 
 	/*

Applied to u-boot-imx (fix), thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================