Skip to contentSkip to conversation

CIFS ACL build failure without CONFIG_KEYS

3.0-rc1 Darren Salt 2 participants 2 messages May 31, 2011 – Jun 6, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

In 3.0-rc1, without CONFIG_KEYS, cifs-acl.c compilation fails with various errors, including one about trying to dereference an incomplete type (struct keys, defined in <linux/key.h>).

I'm including two patches for this since I don't know which way to go on this
one: pick whichever is more correct :-)

Signature · 5 lines
| Darren Salt  | linux or ds at  | nr. Ashington, |  _  ASCII ribbon
| using Debian | youmustbejoking | Northumberland | ( ) campaign against
| GNU/Linux    | ,demon,co,uk    |                |  X  HTML e-mail
                                                    / \ www.asciiribbon.org
Live every day like it's your last, because one day you'll be right.

From: Darren Salt <[email protected]>
Subject: CIFS ACL support needs CONFIG_KEYS, so select it

fs/cifs/Kconfig renamed from fs/cifs/Kconfig.base +1 -0
@@ -149,6 +149,7 @@
 config CIFS_ACL
 	  bool "Provide CIFS ACL support (EXPERIMENTAL)"
 	  depends on EXPERIMENTAL && CIFS_XATTR
+	  select KEYS
 	  help
 	    Allows to fetch CIFS/NTFS ACL from the server.  The DACL blob
 	    is handed over to the application/caller.

From: Darren Salt <[email protected]>
Subject: CIFS ACL support needs CONFIG_KEYS, so depend on it

Build fails if CONFIG_KEYS is not selected.

fs/cifs/Kconfig renamed from fs/cifs/Kconfig.base +1 -1
@@ -148,7 +148,7 @@
 
 config CIFS_ACL
 	  bool "Provide CIFS ACL support (EXPERIMENTAL)"
-	  depends on EXPERIMENTAL && CIFS_XATTR
+	  depends on EXPERIMENTAL && CIFS_XATTR && KEYS
 	  help
 	    Allows to fetch CIFS/NTFS ACL from the server.  The DACL blob
 	    is handed over to the application/caller.
#1 lore raw

I merged the 2nd of the two.

Quoted 15 lines · Darren Salt

In 3.0-rc1, without CONFIG_KEYS, cifs-acl.c compilation fails with various errors, including one about trying to dereference an incomplete type (struct keys, defined in <linux/key.h>).

I'm including two patches for this since I don't know which way to go on this
one: pick whichever is more correct :-)

--

| Darren Salt  | linux or ds at  | nr. Ashington, |  _  ASCII ribbon
| using Debian | youmustbejoking | Northumberland | ( ) campaign against
| GNU/Linux    | ,demon,co,uk    |                |  X  HTML e-mail

                                                   / \ www.asciiribbon.org Live every day like it's your last, because one day you'll be right.

Signature · 3 lines
Thanks,

Steve