Final Review Pending

Ross, Paul:

Please do a review of this set from over the weekend.

Hongxu's patch set includes an atom-pc patch that should have been on poky, I removed it from here.

I have reviewed the 2 package from the Auto Package Update (my recipes) and they are correct.

Thanks
Sau!

The following changes since commit 43c28375f97161e618fa54349c65be2058c33c53:

distrodata.bbaclass: change in git and svn package reporting (2013-07-12 10:12:13 -0700)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib sgw/stage
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/stage

Alexandru Palalau (1):
lib/oeqa/runtime: add tests for syslog and df

Auto Package Upgrade (2):
libidn: upgrade to 1.28
mc: upgrade to 4.8.9

Chen Qi (1):
core-image-lsb.bb: add 'package-management' to IMAGE_FEATURES

Hongxu Jia (5):
pmount: add version 0.9.23
udev-extraconf:fix xuser write to usb storage failed
udev: fix invoking pmount failed based on sysvinit
pmount: allow users in disk group to perform pmount/pumount
xuser-account: add xuser to disk group

Laurentiu Palcu (1):
xinput-calibrator: move it from meta-oe to oe-core

Saul Wold (1):
initscripts: Update to 9.48

Stefan Stanacar (7):
lib/oeqa/runtime/dmesg.py: whitelist dmesg message for systemd net
interface name
lib/oeqa/utils/sshcontrol.py: fix passing command to subprocess testimage.bbclass, lib/oeqa/utils/qemurunner.py: make boot timeout
configurable and increase it
lib/oeqa/runtime/multilib.py: use readelf instead of file lib/oeqa/oetest.py: provide a ps command for all tests classes/testimage.bbclass: use a copy of rootfs for tests testimage.bbclass, lib/oeqa: add headers and comments

 meta/classes/testimage.bbclass                     |  43 +++++++-
 meta/lib/oeqa/oetest.py                            |  14 ++-
 meta/lib/oeqa/runtime/connman.py                   |   5 -
 meta/lib/oeqa/runtime/df.py                        |  13 +++
 meta/lib/oeqa/runtime/dmesg.py                     |   2 +-
 meta/lib/oeqa/runtime/multilib.py                  |   9 +-
 meta/lib/oeqa/runtime/syslog.py                    |  34 ++++++
 meta/lib/oeqa/utils/decorators.py                  |   8 ++
 meta/lib/oeqa/utils/qemurunner.py                  |  12 +--
 meta/lib/oeqa/utils/sshcontrol.py                  |  49 ++++-----
 meta/recipes-core/udev/udev-extraconf/mount.sh     |  31 +++++-
 meta/recipes-core/udev/udev/init                   |   1 +
 meta/recipes-extended/images/core-image-lsb.bb     |   2 +-
 .../libidn/{libidn_1.27.bb => libidn_1.28.bb}      |   4 +-
 ...binitscripts_9.47.bb => lsbinitscripts_9.48.bb} |   6 +-
 .../mc/{mc_4.8.8.bb => mc_4.8.9.bb}                |   4 +-
 ...-option-f-to-mount-already-mounted-device.patch | 115 +++++++++++++++++++++
 meta/recipes-extended/pmount/pmount_0.9.23.bb      |  34 ++++++
 .../pointercal-xinput/pointercal.xinput            |   1 +
 .../xinput-calibrator/pointercal-xinput_0.0.bb     |  18 ++++
 .../xinput-calibrator/30xinput_calibrate.sh        |   7 ++
 ...t_calibrator_pointercal.sh-to-be-run-as-n.patch |  66 ++++++++++++
 .../xinput-calibrator/xinput-calibrator_git.bb     |  30 ++++++
 .../user-creation/xuser-account_0.1.bb             |   2 +-
 24 files changed, 455 insertions(+), 55 deletions(-)
 create mode 100644 meta/lib/oeqa/runtime/df.py
 create mode 100644 meta/lib/oeqa/runtime/syslog.py
 mode change 100644 => 100755 meta/recipes-core/udev/udev-extraconf/mount.sh
 rename meta/recipes-extended/libidn/{libidn_1.27.bb => libidn_1.28.bb} (91%)
 rename meta/recipes-extended/lsb/{lsbinitscripts_9.47.bb => lsbinitscripts_9.48.bb} (78%)
 rename meta/recipes-extended/mc/{mc_4.8.8.bb => mc_4.8.9.bb} (93%)
 create mode 100644 meta/recipes-extended/pmount/files/pmount-add-option-f-to-mount-already-mounted-device.patch
 create mode 100644 meta/recipes-extended/pmount/pmount_0.9.23.bb
 create mode 100644 meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal.xinput
 create mode 100644 meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb
 create mode 100644 meta/recipes-graphics/xinput-calibrator/xinput-calibrator/30xinput_calibrate.sh
 create mode 100644 meta/recipes-graphics/xinput-calibrator/xinput-calibrator/Allow-xinput_calibrator_pointercal.sh-to-be-run-as-n.patch
 create mode 100644 meta/recipes-graphics/xinput-calibrator/xinput-calibrator_git.bb

1.8.1.4

The author field for these isn't set correctly.

I have some reservations about these changes. pmount is obsolete according to its author:

https://lists.ubuntu.com/archives/ubuntu-devel-discuss/2011-February/012421.html

I appreciate it may solve the problem we're trying to solve but we need to be pretty confident about pulling this in before we do so since we'll likely be supporting it ourselves.

I've just noticed this drops PR (previous value was "r6"). I know it seems trivial but we're not increasing PV so if we hope to supersede the recipe from meta-oe, this will have to be preserved. Same goes for pointercal-xinput which had a PR value of "r4".

Cheers,
Paul

Paul Eggleton
Intel Open Source Technology Centre

Agreed. pmount solves a problem but it's unmaintained and going forwards we need to sort out our at_console/polkit/etc story, and this is part of it. I'd been meaning to take a good look at this series today, can we pull it for now?

Ross

Depends what you mean by "pull"... ?

Cheers,
Paul

Paul Eggleton
Intel Open Source Technology Centre

Good point!

"Drop".

Ross

Agree, if we choose pmount, we will maintain it ourselves.

But if not use this, we have to investigate the udev rules to finish the similar job, it's filesystem type dependency, and this makes the udev script more complicated and frequently modified with more and more filesystems supported.

The pmount is an easy way to handle this, and it has supported to process udf, iso9660, vfat, ntfs, hfsplus, hfs, ext3, ext2, ext4, reiserfs, reiser4, xfs, jfs, omfs, ntfs-fuse, ntfs-3g; and it also easy to maintain for us to support other filesystem in future (such as exfat).

//Hongxu

Fixed.

I was unsure at first about this one, and noone had commented on that the last 2 times it was posted, so I took them.

Dropped for now, I missed that PR change

Stefan has a new set that I will pull and put into the Pull request.

Sau!