Skip to contentSkip to conversation

arm:samsung:trats:fix: Restore proper orientation of TRATS's LCD panel

PATCH In review Lukasz Majewski 3 participants 3 messages Jul 15, 2013 – Jul 16, 2013

lore
Share & tools
lore

Lukasz Majewski

author
#0 lore raw

PATCH 1/1 arm:samsung:trats:fix: Restore proper orientation of TRATS's LCD panel

Before setting: mipi_lcd_device.reverse_panel = 1, the Trats's LCD panel was flipped by 180 degrees.

The flip was caused by following change:
Exynos: Change get_timer() to work correctly
SHA1: 3d00c0cb96ff93a929700b80d89cb905e5ab5315

This commit fixed udelay(), which is necessary (due to HW LCD controller oddity) for mipi-dsi correct operation. As a result the display orientation has been switched.

As a follow up, the hwrevision() function has been removed, since it was used only in this particular place.

Test HW: Trats Exynos4210 rev 0.

Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Minkyu Kang <[email protected]>
---
 board/samsung/trats/trats.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
board/samsung/trats/trats.c +1 -9
index e20fb3d..71fe767 100644
@@ -58,12 +58,6 @@ u32 get_board_rev(void)
 #endif
 
 static void check_hw_revision(void);
-
-static int hwrevision(int rev)
-{
-	return (board_rev & 0xf) == rev;
-}
-
 struct s3c_plat_otg_data s5pc210_otg_data;
 
 int board_init(void)

@@ -773,9 +767,7 @@ void init_panel_info(vidinfo_t *vid)
 #ifdef CONFIG_TIZEN
 	get_tizen_logo_info(vid);
 #endif
-
-	if (hwrevision(2))
-		mipi_lcd_device.reverse_panel = 1;
+	mipi_lcd_device.reverse_panel = 1;
 
 	strcpy(s6e8ax0_platform_data.lcd_panel_name, mipi_lcd_device.name);
 	s6e8ax0_platform_data.lcd_power = lcd_power;
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 arm:samsung:trats:fix: Restore proper orientation of TRATS's LCD panel

Dear Tom,

Quoted 14 lines · Lukasz Majewski

Before setting: mipi_lcd_device.reverse_panel = 1, the Trats's LCD panel was flipped by 180 degrees.

The flip was caused by following change:
Exynos: Change get_timer() to work correctly
SHA1: 3d00c0cb96ff93a929700b80d89cb905e5ab5315

This commit fixed udelay(), which is necessary (due to HW LCD controller oddity) for mipi-dsi correct operation. As a result the display orientation has been switched.

As a follow up, the hwrevision() function has been removed, since it was used only in this particular place.

Quoted 9 lines

Test HW: Trats Exynos4210 rev 0.

Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Minkyu Kang <[email protected]>
---
 board/samsung/trats/trats.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
Acked-by Minkyu Kang <[email protected]>

Thanks,
Minkyu Kang.

#2 lore raw
In reply to Lukasz Majewski
Quoted 14 lines · ??ukasz Majewski

Before setting: mipi_lcd_device.reverse_panel = 1, the Trats's LCD panel was flipped by 180 degrees.

The flip was caused by following change:
Exynos: Change get_timer() to work correctly
SHA1: 3d00c0cb96ff93a929700b80d89cb905e5ab5315

This commit fixed udelay(), which is necessary (due to HW LCD controller oddity) for mipi-dsi correct operation. As a result the display orientation has been switched.

As a follow up, the hwrevision() function has been removed, since it was used only in this particular place.

Quoted 6 lines

Test HW: Trats Exynos4210 rev 0.

Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Minkyu Kang <[email protected]>
Acked-by Minkyu Kang <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130716/5985fccc/attachment.pgp>