Skip to contentSkip to conversation

mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

PATCH New Fabio Estevam 6 participants 9 messages Jul 15, 2013 – Jul 24, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the code duplication and only use the nitrogen6x source code to make board code maintainance easier.

Tested booting a mainline device tree kernel on a mx6qsabrelite board.

---
Changes since v1:
- Update MAINTAINERS file

 MAINTAINERS                                        |   2 +-
 .../nitrogen6x/README.mx6qsabrelite}               |   0
 .../nitrogen6x/{README => README.nitrogen6x}       |   0
 board/freescale/mx6qsabrelite/Makefile             |  41 -
 board/freescale/mx6qsabrelite/mx6qsabrelite.c      | 848 ---------------------
 boards.cfg                                         |   2 +-
 include/configs/mx6qsabrelite.h                    | 297 --------
 include/configs/nitrogen6x.h                       |  80 +-
 8 files changed, 81 insertions(+), 1189 deletions(-)
 rename board/{freescale/mx6qsabrelite/README => boundary/nitrogen6x/README.mx6qsabrelite} (100%)
 rename board/boundary/nitrogen6x/{README => README.nitrogen6x} (100%)
 delete mode 100644 board/freescale/mx6qsabrelite/Makefile
 delete mode 100644 board/freescale/mx6qsabrelite/mx6qsabrelite.c
 delete mode 100644 include/configs/mx6qsabrelite.h
MAINTAINERS +1 -1
index 001b42d..c4ed128 100644
@@ -600,7 +600,6 @@ Jason Liu <[email protected]>
 	mx53evk         i.MX53
 	mx53loco        i.MX53
 	mx6qarm2	i.MX6Q
-	mx6qsabrelite   i.MX6Q
 
 Enric Balletbo i Serra <[email protected]>
 
@@ -1054,6 +1053,7 @@ Pali Roh??r <[email protected]>
 	nokia_rx51	ARM ARMV7 (OMAP34xx SoC)
 
 Eric Nelson <[email protected]>
+	mx6qsabrelite		i.MX6Q		1GB
 	nitrogen6dl		i.MX6DL		1GB
 	nitrogen6dl2g		i.MX6DL		2GB
 	nitrogen6q		i.MX6Q/6D	1GB
board/boundary/nitrogen6x/README.mx6qsabrelite renamed from board/freescale/mx6qsabrelite/README +0 -0
similarity index 100%
rename from board/freescale/mx6qsabrelite/README
rename to board/boundary/nitrogen6x/README.mx6qsabrelite
board/boundary/nitrogen6x/README.nitrogen6x renamed from board/boundary/nitrogen6x/README +0 -0
similarity index 100%
rename from board/boundary/nitrogen6x/README
rename to board/boundary/nitrogen6x/README.nitrogen6x
board/freescale/mx6qsabrelite/Makefile deleted +0 -0
deleted file mode 100644
index cf344e4..0000000
board/freescale/mx6qsabrelite/mx6qsabrelite.c deleted +0 -0
deleted file mode 100644
index 862bc30..0000000
boards.cfg +1 -1
index db56488..86e2fd6 100644
@@ -259,7 +259,7 @@ vision2                      arm         armv7       vision2             ttcontr
 cgtqmx6qeval				 arm		 armv7		 cgtqmx6eval		 congatec		mx6		cgtqmx6eval:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg,MX6Q
 mx6qarm2                     arm         armv7       mx6qarm2            freescale      mx6		mx6qarm2:IMX_CONFIG=board/freescale/mx6qarm2/imximage.cfg
 mx6qsabreauto                arm         armv7       mx6qsabreauto       freescale      mx6		mx6qsabreauto:IMX_CONFIG=board/freescale/mx6qsabreauto/imximage.cfg,MX6Q
-mx6qsabrelite                arm         armv7       mx6qsabrelite       freescale      mx6		mx6qsabrelite:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg
+mx6qsabrelite                arm         armv7       nitrogen6x          boundary       mx6		nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6q.cfg,MX6Q,DDR_MB=1024,SABRELITE
 mx6dlsabresd                 arm         armv7       mx6sabresd          freescale      mx6		mx6sabresd:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL
 mx6qsabresd                  arm         armv7       mx6sabresd          freescale      mx6		mx6sabresd:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg,MX6Q
 mx6slevk                     arm         armv7       mx6slevk            freescale      mx6		mx6slevk:IMX_CONFIG=board/freescale/mx6slevk/imximage.cfg,MX6SL
include/configs/mx6qsabrelite.h deleted +0 -0
deleted file mode 100644
index c7db81d..0000000
include/configs/nitrogen6x.h +79 -1

99 lines not on this page · raw message

Signature · 1 line
1.8.1.2
#1 lore raw

PATCH v2 1/1 mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

Quoted 7 lines · Fabio Estevam

mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the code duplication and only use the nitrogen6x source code to make board code maintainance easier.

Tested booting a mainline device tree kernel on a mx6qsabrelite board.

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750

#2 lore raw

PATCH v2 1/1 mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the code duplication and only use the nitrogen6x source code to make board code maintainance easier.

Tested booting a mainline device tree kernel on a mx6qsabrelite board.

---
Changes since v1:
- Update MAINTAINERS file

#3 lore raw

PATCH v2 1/1 mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

In reply to Fabio Estevam

Hi Fabio,

Quoted 8 lines · Fabio Estevam

mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the code duplication and only use the nitrogen6x source code to make board code maintainance easier.

Tested booting a mainline device tree kernel on a mx6qsabrelite board.

---

Hmm, why does this patch not show on Patchwork? Only its V1 does.

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

PATCH v2 1/1 mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

Hi Albert,

Quoted 9 lines · Albert ARIBAUD

Hi Fabio,

Quoted 4 lines · Fabio Estevam

mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the code duplication and only use the nitrogen6x source code to make board code maintainance easier.

Quoted 7 lines
Quoted 4 lines

Tested booting a mainline device tree kernel on a mx6qsabrelite board.

---

Hmm, why does this patch not show on Patchwork? Only its V1 does.

I am struggling for finding it, too. I have already seen a similar case in the past. Otavio remarked that when there is a rename, patchwork is not able to track it (bug in patchwork).

Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#5 lore raw

PATCH v2 1/1 mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

Hi Stefano,

Quoted 17 lines · Stefano Babic

Hi Albert,

Quoted 14 lines · Albert ARIBAUD

Hi Fabio,

Quoted 8 lines · Fabio Estevam

mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the code duplication and only use the nitrogen6x source code to make board code maintainance easier.

Tested booting a mainline device tree kernel on a mx6qsabrelite board.

---

Quoted 6 lines
Quoted 2 lines

Hmm, why does this patch not show on Patchwork? Only its V1 does.

I am struggling for finding it, too. I have already seen a similar case in the past. Otavio remarked that when there is a rename, patchwork is not able to track it (bug in patchwork).

Since we have a clear example (and on the patchwork site where the patchwork folks can dig as deep as they need), we could bring this up to the patchwork list, with the M-IDs of the V1 and V2 patches.

I'd rather someone with a handle to the U-Boot mailing list do it, as it may require digging there too.

Wolfgang?

Quoted 1 line

Stefano

Amicalement,

Signature · 1 line
Albert.
#6 lore raw

PATCH v2 1/1 mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

Quoted 25 lines · Albert ARIBAUD

Hi Stefano,

Quoted 20 lines · Stefano Babic

Hi Albert,

Quoted 16 lines · Albert ARIBAUD

Hi Fabio,

Quoted 8 lines · Fabio Estevam

mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the code duplication and only use the nitrogen6x source code to make board code maintainance easier.

Tested booting a mainline device tree kernel on a mx6qsabrelite board.

---

Hmm, why does this patch not show on Patchwork? Only its V1 does.

Quoted 7 lines
Quoted 3 lines

I am struggling for finding it, too. I have already seen a similar case in the past. Otavio remarked that when there is a rename, patchwork is not able to track it (bug in patchwork).

Since we have a clear example (and on the patchwork site where the patchwork folks can dig as deep as they need), we could bring this up to the patchwork list, with the M-IDs of the V1 and V2 patches.

A second example was :

[PATCH 5/6] mx28evk: Move README file inside board directory

This can be found in the ML, but I never found it in patchworks. This patch renamed only a file:

board/freescale/mx28evk/README

Quoted 5 lines
board/freescale/mx28evk/README renamed from doc/README.mx28evk +0 -0
similarity index 100%
rename from doc/README.mx28evk
rename to board/freescale/mx28evk/README

For this reason the disappearing of mx6qsabrelite can be related, because also this patch renames a file.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#7 lore raw

PATCH v2 1/1 mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

In reply to Fabio Estevam

Hi Fabio,

Quoted 8 lines · Fabio Estevam

mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the code duplication and only use the nitrogen6x source code to make board code maintainance easier.

Tested booting a mainline device tree kernel on a mx6qsabrelite board.

---

I get several "corrupt patch" even if it was sent as usual with git-send-email. Checking in e-mail source, seevral spaces are replaced by =20. I do not know if they are the cause: even trying to fix them, I cannot simply apply the patch. It seems that the mail server did some evil..

Could you be so kind to repush the patch ?

Thanks,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#8 lore raw

PATCH v2 1/1 mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

Hi Stefano,

Quoted 12 lines · Stefano Babic

Hi Fabio,

Quoted 8 lines · Fabio Estevam

mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the code duplication and only use the nitrogen6x source code to make board code maintainance easier.

Tested booting a mainline device tree kernel on a mx6qsabrelite board.

---

Quoted 6 lines

I get several "corrupt patch" even if it was sent as usual with git-send-email. Checking in e-mail source, seevral spaces are replaced by =20. I do not know if they are the cause: even trying to fix them, I cannot simply apply the patch. It seems that the mail server did some evil..

Could you be so kind to repush the patch ?

No problem, I will re-send it later this week.

Regards,

Fabio Estevam