Skip to contentSkip to conversation

fix: Traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (bug 4486)

PATCH Superseded Ionut Radu 2 participants 3 messages Jul 18, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Ionut Radu

author
#0 lore raw

cover fix: Traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (bug 4486)

bb.build.FuncFailed was replaced with bb.fatal

The following changes since commit 74e403705e25afec656b5e40921771a9c29bdc40:

yocto-kernel: make BBLAYERS parsing more robust (2013-07-13 18:23:39 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ionutx/work
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ionutx/work

Ionut Radu (1):
fix traceback when inheriting useradd but not setting USERADD_PARAM
or GROUPADD_PARAM (FuncFailed replaced by bb.fatal)

 meta/classes/useradd.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 1/1 fix traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (FuncFailed replaced by bb.fatal)

Signed-off-by Ionut Radu <[email protected]>
---
 meta/classes/useradd.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/useradd.bbclass +1 -1
index 3fe011d..a68b6fd 100644
@@ -219,7 +219,7 @@ def update_useradd_after_parse(d):
 
     for pkg in useradd_packages.split():
         if not d.getVar('USERADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPMEMS_PARAM_%s' % pkg, True):
-            raise bb.build.FuncFailed("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
+            bb.fatal("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
 
 python __anonymous() {
     update_useradd_after_parse(d)
Signature · 1 line
1.7.10.4
#2 lore raw

Re: [PATCH 1/1] fix traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (FuncFailed replaced by bb.fatal)

Please fix the commit message to follow the guildlines:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Thanks
Sau!

Quoted 19 lines · Ionut Radu
Signed-off-by Ionut Radu <[email protected]>
---
  meta/classes/useradd.bbclass |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/useradd.bbclass +1 -1
index 3fe011d..a68b6fd 100644
@@ -219,7 +219,7 @@ def update_useradd_after_parse(d):
 
      for pkg in useradd_packages.split():
          if not d.getVar('USERADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPMEMS_PARAM_%s' % pkg, True):
-            raise bb.build.FuncFailed("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
+            bb.fatal("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
 
  python __anonymous() {
      update_useradd_after_parse(d)