extcon: arizona: Use power efficient workqueue
PATCH 1/1 extcon: arizona: Use power efficient workqueue
From: Mark Brown <[email protected]>
None of the delayed work the driver schedules has particularly short delays and it is not performance sensitive so let the scheduler run it wherever is most efficient rather than in a per CPU workqueue by using the system power efficient workqueue.
Signed-off-by Mark Brown <[email protected]>
--- drivers/extcon/extcon-arizona.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-)
drivers/extcon/extcon-arizona.c +15 -10
@@ -890,8 +890,9 @@ static void arizona_micd_detect(struct work_struct *work) handled:if (info->detecting) -schedule_delayed_work (&info->micd_timeout_work, -msecs_to_jiffies (info->micd_timeout)); +queue_delayed_work (system_power_efficient_wq, + &info->micd_timeout_work, +msecs_to_jiffies (info->micd_timeout));pm_runtime_mark_last_busy (info->dev);mutex_unlock (&info->lock);
@@ -912,8 +913,9 @@ static irqreturn_t arizona_micdet(int irq, void *data)mutex_unlock (&info->lock);if (debounce) -schedule_delayed_work (&info->micd_detect_work, -msecs_to_jiffies (debounce)); +queue_delayed_work (system_power_efficient_wq, + &info->micd_detect_work, +msecs_to_jiffies (debounce));else arizona_micd_detect (&info->micd_detect_work.work);
@@ -967,12 +969,14 @@ static irqreturn_t arizona_jackdet(int irq, void *data)if (val == info->last_jackdet) {dev_dbg (arizona->dev,"Suppressing duplicate JACKDET\n" );if (cancelled_hp) -schedule_delayed_work (&info->hpdet_work, -msecs_to_jiffies (HPDET_DEBOUNCE )); +queue_delayed_work (system_power_efficient_wq, + &info->hpdet_work, +msecs_to_jiffies (HPDET_DEBOUNCE ));if (cancelled_mic) -schedule_delayed_work (&info->micd_timeout_work, -msecs_to_jiffies (info->micd_timeout)); +queue_delayed_work (system_power_efficient_wq, + &info->micd_timeout_work, +msecs_to_jiffies (info->micd_timeout)); goto out; }
@@ -994,8 +998,9 @@ static irqreturn_t arizona_jackdet(int irq, void *data)arizona_start_mic (info); }else { -schedule_delayed_work (&info->hpdet_work, -msecs_to_jiffies (HPDET_DEBOUNCE )); +queue_delayed_work (system_power_efficient_wq, + &info->hpdet_work, +msecs_to_jiffies (HPDET_DEBOUNCE )); } regmap_update_bits(arizona->regmap,
Signature · 1 line
1.8.3.2
Chanwoo Choi
maintainerHi Mark,
Quoted 7 lines · Mark Brown
From: Mark Brown <[email protected]>
None of the delayed work the driver schedules has particularly short delays and it is not performance sensitive so let the scheduler run it wherever is most efficient rather than in a per CPU workqueue by using the system power efficient workqueue.
Quoted 5 lines
Signed-off-by Mark Brown <[email protected]>--- drivers/extcon/extcon-arizona.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-)
Applied it.
Thanks,
Chanwoo Choi