dhcp: add config option for delayed-ack feature of dhcp server

This patch creates a config option for the ISC DHCP server to allow passing --enable-delayed-ack to its configure script.

---
 package/dhcp/Config.in |  5 +++++
 package/dhcp/dhcp.mk   |  4 ++++
 2 files changed, 9 insertions(+), 0 deletions(-)

@@ -13,6 +13,11 @@ config BR2_PACKAGE_DHCP_SERVER
 	help
 	  DHCP server from the ISC DHCP distribution.
 
+config BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK
+	bool "Enable delayed ACK feature"
+	depends on BR2_PACKAGE_DHCP_SERVER
+	help
+	  Enable delayed ACK feature in the ISC DHCP server.
 
 config BR2_PACKAGE_DHCP_RELAY
 	bool "dhcp relay"

@@ -17,6 +17,10 @@ DHCP_CONF_OPT = \
 	--with-cli-pid-file=/var/run/dhclient.pid \
 	--with-relay-pid-file=/var/run/dhcrelay.pid
 
+ifeq ($(BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK),y)
+        DHCP_CONF_OPT += --enable-delayed-ack
+endif
+
 ifneq ($(BR2_INET_IPV6),y)
         DHCP_CONF_OPT += --disable-dhcpv6
 endif

Hi Gustavo,

Maybe, I'm not an expert on the matter. The RELNOTES file says the following for 4.1.0a2:
"Delayed-ack is now a compile-time option, compiled out by default.
This feature is simply too experimental for right now, and causes some problems to some failover installations. We will revisit this in future releases."

and also the man page:
"Please note that as delayed-ack is currently experimental, the delayed-ack feature is not compiled in by default, but must be enabled at compile time with \'./configure --enable-delayed-ack\'."

but in the meantime we're several releases further. I don't know if it is still accurate.

I think you're right that it's not default-on in dhcpd.conf.

What do you say, enable it always at compile time?

Thanks,
Thomas

Oh yes it's a default, so let's just keep the option. (includes/dhcpd.h -> DEFAULT_DELAYED_ACK)
I hate build options :)
Regards.

You're right, so we have to keep the option.
Hence, the patch remains as it is.

Thanks for your feedback,
Thomas

Thomas> This patch creates a config option for the ISC DHCP server to Thomas> allow passing --enable-delayed-ack to its configure script.

Committed, thanks.

Are you really building such a big system with Buildroot that the fsyncs matter?

Bye, Peter Korsgaard