powerpc: platforms: powernv: add '__init' for pnv_pci_init_ioda2_phb()
PATCH 1/1 powerpc: platforms: powernv: add '__init' for pnv_pci_init_ioda2_phb()
pnv_pci_init_ioda2_phb() is only used during boot up, so need add '__init' to save the related memory, and avoid related warning:
The function .pnv_pci_init_ioda2_phb() references
the function __init .pnv_pci_init_ioda_phb().
This is often because .pnv_pci_init_ioda2_phb lacks a __init annotation or the annotation of .pnv_pci_init_ioda_phb is wrong.
--- arch/powerpc/platforms/powernv/pci-ioda.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/platforms/powernv/pci-ioda.c +1 -1
@@ -1266,7 +1266,7 @@ void __init pnv_pci_init_ioda_phb(struct device_node *np,opal_pci_set_pe (phb_id,0 ,0 ,7 ,1 ,1 ,OPAL_MAP_PE ); } -void pnv_pci_init_ioda2_phb (struct device_node *np) +void __init pnv_pci_init_ioda2_phb (struct device_node *np) {pnv_pci_init_ioda_phb (np,0 ,PNV_PHB_IODA2 ); }
Signature · 1 line
1.7.7.6
Quoted 10 lines · Chen Gang
pnv_pci_init_ioda2_phb()is only used during boot up, so need add '__init' to save the related memory, and avoid related warning:The function .pnv_pci_init_ioda2_phb() references
the function__init.pnv_pci_init_ioda_phb().
This is often because .pnv_pci_init_ioda2_phb lacks a__initannotation or the annotation of .pnv_pci_init_ioda_phb is wrong.Signed-off-by Chen Gang <[email protected]>
Looks right to me.
Quoted 19 lines
--- arch/powerpc/platforms/powernv/pci-ioda.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/powerpc/platforms/powernv/pci-ioda.c +1
-2@@ -1266,7 +1266,7 @@ void __init pnv_pci_init_ioda_phb(struct device_node *np,opal_pci_set_pe (phb_id,0 ,0 ,7 ,1 ,1 ,OPAL_MAP_PE ); } -void pnv_pci_init_ioda2_phb (struct device_node *np) +void __init pnv_pci_init_ioda2_phb (struct device_node *np) {pnv_pci_init_ioda_phb (np,0 ,PNV_PHB_IODA2 ); } --1.7.7.6
Quoted 10 lines · Bjorn Helgaas
Quoted 9 lines · Chen Gang
pnv_pci_init_ioda2_phb()is only used during boot up, so need add '__init' to save the related memory, and avoid related warning:The function .pnv_pci_init_ioda2_phb() references
the function__init.pnv_pci_init_ioda_phb().
This is often because .pnv_pci_init_ioda2_phb lacks a__initannotation or the annotation of .pnv_pci_init_ioda_phb is wrong.
Quoted 4 lines
Quoted 1 line
Signed-off-by Chen Gang <[email protected]>Looks right to me.
Thanks.
Quoted 21 lines
Quoted 19 lines
--- arch/powerpc/platforms/powernv/pci-ioda.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/powerpc/platforms/powernv/pci-ioda.c +1
-2@@ -1266,7 +1266,7 @@ void __init pnv_pci_init_ioda_phb(struct device_node *np,opal_pci_set_pe (phb_id,0 ,0 ,7 ,1 ,1 ,OPAL_MAP_PE ); } -void pnv_pci_init_ioda2_phb (struct device_node *np) +void __init pnv_pci_init_ioda2_phb (struct device_node *np) {pnv_pci_init_ioda_phb (np,0 ,PNV_PHB_IODA2 ); } --1.7.7.6
Signature · 1 line
Chen Gang