package/uclibc: fix big oops from fb354d5f
PATCH 1/1 package/uclibc: fix big oops from fb354d5f
--- ...0010-Rules.mak-fix-breakage-from-603af30d.patch | 31 ++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 package/uclibc/0.9.33.2/uclibc-0010-Rules.mak-fix-breakage-from-603af30d.patch
package/uclibc/0.9.33.2/uclibc-0010-Rules.mak-fix-breakage-from-603af30d.patch new file +31 -0
@@ -0,0 +1,31 @@ +From ce45262289a79dee13da1c621837716c1222d791 Mon Sep 17 00:00:00 2001 +From: Gustavo Zacarias <[email protected]> +Date: Wed, 24 Jul 2013 11:04:02 -0300 +Subject: [PATCH] Rules.mak: fix breakage from 603af30d + +Removing the whitespace from findstring for 64 bit architectures has +bad consequences since powerpc would be a match in powerpc64 and sparc +would also be a match in sparc64. +That doesn't make them 64 bits in reality causing general breakage. + +Signed-off-by: Gustavo Zacarias <[email protected]> +--- + Rules.mak | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/Rules.mak b/Rules.mak +index 889108e..09a01a3 100644 +--- a/Rules.mak ++++ b/Rules.mak +@@ -141,7 +141,7 @@ UBACKTRACE_DSO := libubacktrace.so.$(ABI_VERSION) + + UCLIBC_LDSO_NAME := ld-uClibc + ARCH_NATIVE_BIT := 32 +-ifneq ($(findstring $(TARGET_ARCH),hppa64 ia64 powerpc64 s390x sparc64 x86_64),) ++ifneq ($(findstring $(TARGET_ARCH) , hppa64 ia64 mips64 powerpc64 s390x sparc64 x86_64 ),) + UCLIBC_LDSO_NAME := ld64-uClibc + ARCH_NATIVE_BIT := 64 + else +-- +1.8.1.5 +
Signature · 1 line
1.8.1.5
PATCH 1/1 package/uclibc: fix big oops from fb354d5f
Quoted 46 lines · Gustavo Zacarias
Signed-off-by Gustavo Zacarias <[email protected]>--- ...0010-Rules.mak-fix-breakage-from-603af30d.patch | 31 ++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 package/uclibc/0.9.33.2/uclibc-0010-Rules.mak-fix-breakage-from-603af30d.patchpackage/uclibc/0.9.33.2/uclibc-0010-Rules.mak-fix-breakage-from-603af30d.patch new file +31
-1@@ -0,0 +1,31 @@ +From ce45262289a79dee13da1c621837716c1222d791 Mon Sep 17 00:00:00 2001 +From: Gustavo Zacarias <[email protected]> +Date: Wed, 24 Jul 2013 11:04:02 -0300 +Subject: [PATCH] Rules.mak: fix breakage from 603af30d + +Removing the whitespace from findstring for 64 bit architectures has +bad consequences since powerpc would be a match in powerpc64 and sparc +would also be a match in sparc64. +That doesn't make them 64 bits in reality causing general breakage. + +Signed-off-by: Gustavo Zacarias <[email protected]> +--- + Rules.mak | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/Rules.mak b/Rules.mak +index 889108e..09a01a3 100644 +--- a/Rules.mak ++++ b/Rules.mak +@@ -141,7 +141,7 @@ UBACKTRACE_DSO := libubacktrace.so.$(ABI_VERSION) + + UCLIBC_LDSO_NAME := ld-uClibc + ARCH_NATIVE_BIT := 32 +-ifneq ($(findstring $(TARGET_ARCH),hppa64 ia64 powerpc64 s390x sparc64 x86_64),) ++ifneq ($(findstring $(TARGET_ARCH) , hppa64 ia64 mips64 powerpc64 s390x sparc64 x86_64 ),) + UCLIBC_LDSO_NAME := ld64-uClibc + ARCH_NATIVE_BIT := 64 + else +-- +1.8.1.5 + --1.8.1.5
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
The patch is partially ok. It breaks mips64 that was fixed in
I've also commented on that in the uClibc list
Signature · 2 lines
Regards, Markos Chandras
PATCH 1/1 package/uclibc: fix big oops from fb354d5f
Quoted 5 lines · Markos Chandras
The patch is partially ok. It breaks mips64 that was fixed in
I've also commented on that in the uClibc list
Right, sent V2 to both lists.
Careful with whitespace and constructs in makefiles next time ;) Regards.
PATCH 1/1 package/uclibc: fix big oops from fb354d5f
Quoted 11 lines · Gustavo Zacarias
Quoted 5 lines · Markos Chandras
The patch is partially ok. It breaks mips64 that was fixed in
I've also commented on that in the uClibc list
Right, sent V2 to both lists.
Careful with whitespace and constructs in makefiles next time ;) Regards.
Well, mistakes can happen :)
Signature · 2 lines
Regards, Markos Chandras
PATCH 1/1 package/uclibc: fix big oops from fb354d5f
Quoted 1 line · Markos Chandras
Well, mistakes can happen :)
Of course, i broke shit many times :)
Regards.