driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()
PATCH v2 1/1 driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()
Commit e21d2170f36602ae2708 ("video: remove unnecessary platform_set_drvdata()") removed the unnecessary platform_set_drvdata(), but left the variable "dev" unused, delete it.
v2:
Following Geert's suggestion to make change log easier reading.
--- drivers/video/vga16fb.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/video/vga16fb.c +0 -1
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *imagestatic void vga16fb_destroy (struct fb_info *info) { - struct platform_device *dev = container_of(info->device, struct platform_device, dev);iounmap (info->screen_base);fb_dealloc_cmap (&info->cmap);/* XXX unshare VGA regions */
Signature · 7 lines
1.7.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Quoted 9 lines · Gu Zheng
Commit
e21d2170f36602ae2708("video: remove unnecessaryplatform_set_drvdata()") removed the unnecessaryplatform_set_drvdata(), but left the variable "dev" unused, delete it.v2:
Following Geert's suggestion to make change log easier reading.Signed-off-by Gu Zheng <[email protected]>---
Please send a v3, which has the version info under the above "---", instead of making it a part of the patch description to be committed.
Thanks again!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 2 lines · Geert Uytterhoeven
Please send a v3, which has the version info under the above "---", instead of making it a part of the patch description to be committed.
Grepping through my mail tells me this is the fourth time a patch has been submitted to fix this trivial issue. Perhaps (one of) the maintainers can indicate which patch, if any, the maintainers have taken or will be taking.
Paul Bolle
Quoted 8 lines · Paul Bolle
Quoted 2 lines · Geert Uytterhoeven
Please send a v3, which has the version info under the above "---", instead of making it a part of the patch description to be committed.
Grepping through my mail tells me this is the fourth time a patch has been submitted to fix this trivial issue. Perhaps (one of) the maintainers can indicate which patch, if any, the maintainers have taken or will be taking.
I took the the oldest patch for this in my mailbox, from Luis.
Tomi