Skip to contentSkip to conversation

video: mxsfb: Let device core handle pinctrl

PATCH RESEND In review Fabio Estevam 3 participants 3 messages Jul 15, 2013 – Jul 26, 2013

Subsystems (2)
Arm i.MX and Layerscape Framebuffer layer
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH RESEND 1/1 video: mxsfb: Let device core handle pinctrl

From: Fabio Estevam <[email protected]>

Since commit ab78029 (drivers/pinctrl: grab default handles from device core) we can rely on device core for handling pinctrl, so remove devm_pinctrl_get_select_default() from the driver.

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Shawn Guo <[email protected]>

---
Andrew,

Should this go via your tree?

 drivers/video/mxsfb.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/video/mxsfb.c +0 -8
index 21223d4..9d6a286 100644
@@ -46,7 +46,6 @@
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>
 #include <linux/io.h>
-#include <linux/pinctrl/consumer.h>
 #include <linux/fb.h>
 #include <linux/regulator/consumer.h>
 #include <video/of_display_timing.h>

@@ -877,7 +876,6 @@ static int mxsfb_probe(struct platform_device *pdev)
 	struct mxsfb_info *host;
 	struct fb_info *fb_info;
 	struct fb_modelist *modelist;
-	struct pinctrl *pinctrl;
 	int ret;
 
 	if (of_id)

@@ -909,12 +907,6 @@ static int mxsfb_probe(struct platform_device *pdev)
 
 	host->devdata = &mxsfb_devdata[pdev->id_entry->driver_data];
 
-	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
-	if (IS_ERR(pinctrl)) {
-		ret = PTR_ERR(pinctrl);
-		goto fb_release;
-	}
-
 	host->clk = devm_clk_get(&host->pdev->dev, NULL);
 	if (IS_ERR(host->clk)) {
 		ret = PTR_ERR(host->clk);
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 6 lines · On Mon, 15 Jul 2013 18:31:24 -0300 Fabio Estevam <[email protected]> wrote:

From: Fabio Estevam <[email protected]>

Since commit ab78029 (drivers/pinctrl: grab default handles from device core) we can rely on device core for handling pinctrl, so remove devm_pinctrl_get_select_default() from the driver.

Quoted 6 lines
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Shawn Guo <[email protected]>

---
Andrew,

Should this go via your tree?

Well, no, it should really be reviewed by and merged by Jean-Christophe. Is there a problem in fbdev land?