Skip to contentSkip to conversation

video: nuc900fb: fix to pass correct device identity to request_irq()

PATCH New Wei Yongjun 3 participants 3 messages Jul 16, 2013 – Jul 26, 2013 Framebuffer layer

lore
Share & tools
lore

Wei Yongjun

author
#0 lore raw

PATCH 1/1 video: nuc900fb: fix to pass correct device identity to request_irq()

The IRQ handler nuc900fb_irqhandler() use dev_id as a type of struct nuc900fb_info *, so we should pass fbi as the device identity to request_irq().

Signed-off-by Wei Yongjun <[email protected]>

---
Was 'video: nuc900fb: fix to pass correct device identity to free_irq()'

---
 drivers/video/nuc900fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/video/nuc900fb.c +1 -2
index 8c527e5..796e511 100644
@@ -587,8 +587,7 @@ static int nuc900fb_probe(struct platform_device *pdev)
 	fbinfo->flags			= FBINFO_FLAG_DEFAULT;
 	fbinfo->pseudo_palette		= &fbi->pseudo_pal;
 
-	ret = request_irq(irq, nuc900fb_irqhandler, 0,
-			  pdev->name, fbinfo);
+	ret = request_irq(irq, nuc900fb_irqhandler, 0, pdev->name, fbi);
 	if (ret) {
 		dev_err(&pdev->dev, "cannot register irq handler %d -err %d\n",
 			irq, ret);
#1 lore raw

PATCH 1/1 video: nuc900fb: fix to pass correct device identity to request_irq()

2013/7/16 Wei Yongjun <[email protected]>:

Quoted 5 lines

The IRQ handler nuc900fb_irqhandler() use dev_id as a type of struct nuc900fb_info *, so we should pass fbi as the device identity to request_irq().

Signed-off-by Wei Yongjun <[email protected]>
Acked-by Wan Zongshun <[email protected]>

Thanks!
Vincent Wan.

Quoted 13 lines

---
Was 'video: nuc900fb: fix to pass correct device identity to free_irq()'

---
 drivers/video/nuc900fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/video/nuc900fb.c +0 -0
index 8c527e5..796e511 100644

drivers/video/nuc900fb.c static int nuc900fb_probe(struct platform_device *pdev) · line 593

Quoted 9 lines
drivers/video/nuc900fb.c +1 -2
@@ -587,8 +587,7 @@ static int nuc900fb_probe(struct platform_device *pdev)
        fbinfo->flags                   = FBINFO_FLAG_DEFAULT;
        fbinfo->pseudo_palette          = &fbi->pseudo_pal;
 
-       ret = request_irq(irq, nuc900fb_irqhandler, 0,
-                         pdev->name, fbinfo);
+       ret = request_irq(irq, nuc900fb_irqhandler, 0, pdev->name, fbi);
        if (ret) {
                dev_err(&pdev->dev, "cannot register irq handler %d -err %d\n",
                        irq, ret);

--
Wan ZongShun.
www.mcuos.com

#2 lore raw

PATCH 1/1 video: nuc900fb: fix to pass correct device identity to request_irq()

In reply to Wei Yongjun
Quoted 17 lines · Wei Yongjun

The IRQ handler nuc900fb_irqhandler() use dev_id as a type of struct nuc900fb_info *, so we should pass fbi as the device identity to request_irq().

Signed-off-by Wei Yongjun <[email protected]>

---
Was 'video: nuc900fb: fix to pass correct device identity to free_irq()'

---
 drivers/video/nuc900fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/video/nuc900fb.c +0 -0
index 8c527e5..796e511 100644

drivers/video/nuc900fb.c static int nuc900fb_probe(struct platform_device *pdev) · line 593

Quoted 9 lines
drivers/video/nuc900fb.c +1 -2
@@ -587,8 +587,7 @@ static int nuc900fb_probe(struct platform_device *pdev)
 	fbinfo->flags			= FBINFO_FLAG_DEFAULT;
 	fbinfo->pseudo_palette		= &fbi->pseudo_pal;
 
-	ret = request_irq(irq, nuc900fb_irqhandler, 0,
-			  pdev->name, fbinfo);
+	ret = request_irq(irq, nuc900fb_irqhandler, 0, pdev->name, fbi);
 	if (ret) {
 		dev_err(&pdev->dev, "cannot register irq handler %d -err %d\n",
 			irq, ret);

Thanks, I've applied this into my 3.11-fixes/fbdev branch.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130726/d6d5ff2b/attachment.sig>