O_TMPFILE problem
Hi,
I'm doing a couple of test about O_TMPFILE on my fs. I can see that when the file is closed the blocks allocated are not freed. It happens because of i_mode, it isn't a regular file nor a directory nor a link. I added S_IFREG in my implementation of tmpfile callback when I have to call new_inode() and now it works, but am I missing something here?
Marco
Jan Kara
reviewerQuoted 6 lines · Marco Stornelli
I'm doing a couple of test about
O_TMPFILEon my fs. I can see that when the file is closed the blocks allocated are not freed. It happens because ofi_mode, it isn't a regular file nor a directory nor a link. I addedS_IFREGin my implementation of tmpfile callback when I have to callnew_inode()and now it works, but am I missing something here?
No, I think you are right. We need to add S_IFREG to the mode we pass to
->tmpfile().
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR