Skip to contentSkip to conversation

generic-ipi: Fix misleading smp_call_function_any() description

PATCH In review Xie XiuQi 2 participants 3 messages Jul 29, 2013 – Aug 19, 2013

lore
Share & tools
lore

Xie XiuQi

author
#0 lore raw

PATCH 1/1 generic-ipi: Fix misleading smp_call_function_any() description

After commit:8969a5ede0f9e17da4b943712429aef2c9bcd82b "generic-ipi: remove kmalloc()", wait = 0 can be guaranteed.

Signed-off-by Xie XiuQi <[email protected]>
Cc Sheng Yang <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Jens Axboe <[email protected]>
Cc Rusty Russell <[email protected]>
---
 kernel/smp.c | 2 --
 1 file changed, 2 deletions(-)
kernel/smp.c +0 -2
index fe9f773..b1c9034 100644
@@ -278,8 +278,6 @@ EXPORT_SYMBOL(smp_call_function_single);
  * @wait: If true, wait until function has completed.
  *
  * Returns 0 on success, else a negative status code (if no cpus were online).
- * Note that @wait will be implicitly turned on in case of allocation failures,
- * since we fall back to on-stack allocation.
  *
  * Selection preference:
  *	1) current cpu if in @mask
Signature · 1 line
1.8.2.1
author
#1 lore raw
Cc Ingo Molnar <[email protected]>
Quoted 26 lines · Xie XiuQi

After commit:8969a5ede0f9e17da4b943712429aef2c9bcd82b "generic-ipi: remove kmalloc()", wait = 0 can be guaranteed.

Signed-off-by Xie XiuQi <[email protected]>
Cc Sheng Yang <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Jens Axboe <[email protected]>
Cc Rusty Russell <[email protected]>
---
 kernel/smp.c | 2 --
 1 file changed, 2 deletions(-)
kernel/smp.c +0 -2
index fe9f773..b1c9034 100644
@@ -278,8 +278,6 @@ EXPORT_SYMBOL(smp_call_function_single);
  * @wait: If true, wait until function has completed.
  *
  * Returns 0 on success, else a negative status code (if no cpus were online).
- * Note that @wait will be implicitly turned on in case of allocation failures,
- * since we fall back to on-stack allocation.
  *
  * Selection preference:
  *	1) current cpu if in @mask
merge bot
#2 lore raw

[tip:core/locking] generic-ipi/locking: Fix misleading smp_call_function_any() description

In reply to Xie XiuQi
generic-ipi/locking: Fix misleading smp_call_function_any() description
Commit-ID:  15e71911fcc655508e02f767a3d9b8b138051d2b
Gitweb:     http://git.kernel.org/tip/15e71911fcc655508e02f767a3d9b8b138051d2b
Author:     Xie XiuQi <[email protected]>
AuthorDate: Mon, 29 Jul 2013 11:52:24 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 19 Aug 2013 09:03:50 +0200

generic-ipi/locking: Fix misleading smp_call_function_any() description

Fix locking description: after commit 8969a5ede0f9e17da4b9437 ("generic-ipi: remove kmalloc()"), wait = 0 can be guaranteed because we don't kmalloc() anymore.

Signed-off-by Xie XiuQi <[email protected]>
Cc Sheng Yang <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Jens Axboe <[email protected]>
Cc Rusty Russell <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/smp.c | 2 --
 1 file changed, 2 deletions(-)
kernel/smp.c +0 -2
index fe9f773..b1c9034 100644
@@ -278,8 +278,6 @@ EXPORT_SYMBOL(smp_call_function_single);
  * @wait: If true, wait until function has completed.
  *
  * Returns 0 on success, else a negative status code (if no cpus were online).
- * Note that @wait will be implicitly turned on in case of allocation failures,
- * since we fall back to on-stack allocation.
  *
  * Selection preference:
  *	1) current cpu if in @mask